Re: [EXTERNAL] [PATCH v3 1/9] crypto/ionic: introduce AMD Pensando driver

["Boyer, Andrew" <Andrew.Boyer@amd.com>]

> On Jun 13, 2024, at 6:07 AM, Akhil Goyal <gakhil@marvell.com> wrote:
> 
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
>> diff --git a/drivers/crypto/ionic/meson.build b/drivers/crypto/ionic/meson.build
>> new file mode 100644
>> index 0000000000..4114e13e53
>> --- /dev/null
>> +++ b/drivers/crypto/ionic/meson.build
>> @@ -0,0 +1,13 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright 2021-2024 Advanced Micro Devices, Inc.
>> +
>> +deps += ['bus_vdev']
>> +deps += ['common_ionic']
>> +
>> +sources = files(
>> +        'ionic_crypto_main.c',
>> +        'ionic_crypto_vdev.c',
>> +)
>> +name = 'ionic_crypto'
> 
> Why do you explicitly add name here?
> 
> I believe driver name as ionic should be ok.
> All other PMDs which have common name in net/crypto
> do not need to add _crypto namespace.
> 
> If you don't have objections, I can fix it while merging.
> 


That's fine. Please fix it up.

Thank you!
Andrew