From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 090D3A0547;
Thu, 9 Sep 2021 13:23:24 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 7685B40041;
Thu, 9 Sep 2021 13:23:24 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by mails.dpdk.org (Postfix) with ESMTP id B49904003E
for <dev@dpdk.org>; Thu, 9 Sep 2021 13:23:22 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10101"; a="220438047"
X-IronPort-AV: E=Sophos;i="5.85,280,1624345200"; d="scan'208";a="220438047"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
09 Sep 2021 04:23:21 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,280,1624345200"; d="scan'208";a="479616248"
Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82])
by orsmga008.jf.intel.com with ESMTP; 09 Sep 2021 04:23:21 -0700
Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by
fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Thu, 9 Sep 2021 04:23:20 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12 via Frontend Transport; Thu, 9 Sep 2021 04:23:20 -0700
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108)
by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2242.12; Thu, 9 Sep 2021 04:23:20 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=gvgRSkU/SHio+N6TtLIYgyUdodMhe/VzJuPA/nGmeHO95bowI/3DDmX1TP1qtvfoLUudhGNhV72kN8s09CNaGPCsUXcIziftMhcQwVWcPcPM56P27a13RgTh7xSvSxBmMQt8+186zXDUBP1shPRmwEW6HdIR2AMZMsx9SN/C9hVMtELTjaz09HUFSUsd6ghCT4hniPY6dqEdoWs8i9U8dHjX5jt5by+str1qVrkgUGywoGRR+FoY9cg1ZYwcE1QfQHwWi4IBwUdVHag9Ap0NFNRQG2uiev6VVPLTrQUlVzakmDhbST03YmLtyedSv/8xzbWhcPkZSncTtV2yvjeO+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=fkcXnh+W62BnFTvtEyGu0t6zvHMMn3aRTlDj1nVIipw=;
b=TlQuO3Jv4MYyzpSw8Njf0PBQPQx10S1k6WhzZCUTpa65KOGzBDzRL9B8W9wqO1fSzmOvymKMg+rbbkkeT1eRINGMyBk3p5emZj3IOgcGaH/2COoYWsNYLWXrC2c/ViHuXFe5/nGuTvJd1dXIkgPkxlPSbqwHerbbGBJ6tVDw0DJqFyPPMcrgT1pldfsc6pDD/r6IlCb0UH1mdwveBhK1RzQRaJiVhY9Uz0FYw+Lf/ZjTNe93R8NiXG6Nh55EsmHVq9vSvbOVMvqRXBMmjPc1PCz7dt8PSCUAn4cSzuziTYG5VHLs+aznQlImQVAXCojy+2YqNvh6MeHpaUN2xuB4VQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=fkcXnh+W62BnFTvtEyGu0t6zvHMMn3aRTlDj1nVIipw=;
b=zNcyOYzWUHx/64lgVRIR63BmDFQ+JXpO5ryC/F4ggOz85URZxzAhFtSoFF0+SBcsdS49q5QUsl/kM5gE351yf3SD/fNVqP5qiwcgio/ejOK6p9x7QgU1C+ni0RJJkxUBNfB4qrBtITCeNc4hH4rEV4Gu375n8HpQkxF7m4UZ5A4=
Authentication-Results: marvell.com; dkim=none (message not signed)
header.d=none;marvell.com; dmarc=none action=none header.from=intel.com;
Received: from SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23)
by SA2PR11MB4905.namprd11.prod.outlook.com (2603:10b6:806:117::7)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Thu, 9 Sep
2021 11:23:17 +0000
Received: from SA2PR11MB5210.namprd11.prod.outlook.com
([fe80::e5f6:85a1:af0d:705e]) by SA2PR11MB5210.namprd11.prod.outlook.com
([fe80::e5f6:85a1:af0d:705e%7]) with mapi id 15.20.4500.017; Thu, 9 Sep 2021
11:23:17 +0000
To: Kevin Laatz <kevin.laatz@intel.com>, <dev@dpdk.org>
CC: <bruce.richardson@intel.com>, <fengchengwen@huawei.com>,
<jerinj@marvell.com>
References: <20210903105001.1179328-1-kevin.laatz@intel.com>
<20210908103016.1661914-1-kevin.laatz@intel.com>
<20210908103016.1661914-8-kevin.laatz@intel.com>
From: Conor Walsh <conor.walsh@intel.com>
Message-ID: <6021612c-c114-e46b-a3bd-32831390fdda@intel.com>
Date: Thu, 9 Sep 2021 12:23:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
Thunderbird/78.14.0
In-Reply-To: <20210908103016.1661914-8-kevin.laatz@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-ClientProxiedBy: DB6PR0501CA0008.eurprd05.prod.outlook.com
(2603:10a6:4:8f::18) To SA2PR11MB5210.namprd11.prod.outlook.com
(2603:10b6:806:fa::23)
MIME-Version: 1.0
Received: from [192.168.1.20] (109.79.8.55) by
DB6PR0501CA0008.eurprd05.prod.outlook.com (2603:10a6:4:8f::18) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.4500.14 via Frontend Transport; Thu, 9 Sep 2021 11:23:16 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d09f9a85-3fbf-42f1-301c-08d973843897
X-MS-TrafficTypeDiagnostic: SA2PR11MB4905:
X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <SA2PR11MB4905C60E51EC40B9DD5E65BEFFD59@SA2PR11MB4905.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2331;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 9pDQV5kWQxJcxVp+ucvXFLjJMBTw5VhIDtWnxO3jzJk0e2tw8a8x5ysRvLTS+fJuNbEddGB5RRJ8rDqAiizsbKcm2GiBtxGxRR2HyGalIw22I8fUcX/3WfXdPgWfmjHDddc8z7Z+9MAjhaecp5HB3QNkLgH/9+GxllchoawH2T42b0LE09yYhPrnraLEaVVvcXG9o7f0vuCpO4coXGOopkiVdkrPc/VmUGE1WLHinY2b6OgGK2dHA2Du4oSUsgaT2xk+r0mXNkh6NFaPA9GjXhm7ZBufgCH6Zuaq9u+JPHY61FfSLqdxgWRsXSmrxYA8AVFkmpNZMMzeLt97AfjSdWXrhajLzUdjPeFFaK/ol4KNYwbHG++zIGCCH8d0OoxTT1ilzzjFW76y+1K6hma17ebPOZXhUNidcfK66q6BSA9KBdDUgJ+MuWUtQKN2laAm6VGHtOTiF0Xp9elA3NrecpIJXEHIar3ZVoN8rg+WU9jzj6RtmBqRYI2svSAaSXfmenCfzKETMykc6AdHSLqG7ah+yLZ0u/lTuXlNVmYqMhCC0Qm8W+xeSnd9qKoC78hnV0fAsJfUPwWNm/XBvpXPz558cVLxf2r3lJz1auJVapkdQQCQM0e8MV93uZQhx4r+yfTp6fdf6ZqZd8nXi0xE2GuDqQrlt7yZTiIed22PkU4qjF4D8MlVqg8Uz6w2Ojy1G37kRKIgr4gU5/sQ9AeUhI7+XCWOY1pBmvTWMTFiHzI=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:SA2PR11MB5210.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(366004)(346002)(376002)(136003)(396003)(39860400002)(6486002)(2906002)(186003)(66476007)(2616005)(956004)(31696002)(31686004)(38100700002)(316002)(4326008)(26005)(44832011)(86362001)(8936002)(16576012)(66946007)(6666004)(8676002)(36756003)(66556008)(478600001)(5660300002)(43740500002)(45980500001);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHRSeUVBU1V5RHBSRXV4SDRhNDd1L1B0cTBYTWVjOXVyOEd6NlVGamFHbUti?=
=?utf-8?B?R3F0b004YXNoaDU3QXk5NEhBK2tKNkZvdnhoWEZ5b3RMbGIxWGx2RXJnbVQx?=
=?utf-8?B?QUJLc0JWNjFuR0Q1NHozV3J5K2NGdDhDK1RBSXJrSHNTc2tBQzRqc3EyVFFZ?=
=?utf-8?B?QjI1U0ZIRFBBZ0hlNlB4MG5NWWJ3c0VCQ25yZUVic0FHcnAxOExmSitSUGta?=
=?utf-8?B?dzhJUWdoMzJ2VDUyMEQ4anZueU96L2gwK09VRmxCTTc1UTBHMWZhMWNPRU9C?=
=?utf-8?B?eWhScFlicCtuK3dUUkZaQUVCMlBGUjVWZE43bVg4UW8zRGdaMG5SV1lmZXVM?=
=?utf-8?B?RERLcVBwcjdTb1RZLzRNMk1ZK09ra1QxVDZRUlJjR0ZKK0hpRk9Ha1FHcmk3?=
=?utf-8?B?Wlhxa2c5aWdQeUg3cnVmNXpSUEJDUXM4MFU4TndvYWpqOXdMT2hBeHFFUUwr?=
=?utf-8?B?ZWhvTVdIRXY1NHVxYWF6U1pPOUk1Wmx4ZzE2VDBBdkFyY3hYbk1XVGJzVkFI?=
=?utf-8?B?bjRMdlc1VmVFK1pTTEtkSkRFM0xRRzZKKzhCMlJsa2RQazFxWk9JOWh6STls?=
=?utf-8?B?OGpZdkhtS3JVME1pVVpoZ3dtM214YlZuSi9HWWhTOVhZam1pNkxZZWNBWW9Y?=
=?utf-8?B?Ym1KT0treHZ2ZEVKOEMzUGhtTTN0S005YWNzVEs0WTNIQUM1cG12SC9RWDll?=
=?utf-8?B?Z0tTK0xNVm5DNU5iVWFxNW5jZklFV2FUb0dzWlg0YVd0MnNKbVc4SnJVR2lw?=
=?utf-8?B?RlZrOWhjcGlIUXNqYmE4U0kweUIwV2U5dFJzaGFIcE9aZCtwUHMzNTBhTEhy?=
=?utf-8?B?OHRvQTZ5bkp2ak1hMkNpMnR3RDB1ekVFQU9oVkhCdTZCU2RucTNTWEwxVG9C?=
=?utf-8?B?cVZjQytEck5LblpuZTltUnE3dEU0VW1vdnVrSk8xMSsySTR3bjdaeTFGMjIy?=
=?utf-8?B?UjJCeHZRSWZmOWpFb3gvZzM4cURGSkRFbmY4YmFwaUJ4ZXZpclFsZFZ2aWth?=
=?utf-8?B?V3RwNlQvcWd6ajRYNEF1TDkyYmJZU3I0Q1kyVXVIYUdUdXZienp3TGJPWGFN?=
=?utf-8?B?OVRVYTltVWJ2RXlsQTJuKysySjJqUGQyRUFXNDFtdUhCTG1GL2FTWkZPM1pT?=
=?utf-8?B?UFpvbisyWHRFNHg5RmFZWHdqcTlNYlRxNnNpaEtyem1aR1NzUDB5a29Xb3lS?=
=?utf-8?B?UnZrTndVQjNKYkp5QzRrS1FSTU05VlZ5SkVReFBMU0R2ci9oL1IvamhTNXd0?=
=?utf-8?B?UU43WHAwakI2R0ZXY1RnaFdMNE9uaU5aaURHWWdtakVtY09qaEtjdEtGWUhr?=
=?utf-8?B?K21EYzBIS29pQ0cvWXhKUHNPcHI5dXJyY21hZkozTy84UmY3dUFCRDhFdTZm?=
=?utf-8?B?S1hqL05iODExS0xCeGsrNGxpcFZHRGhNNURDVjVOeWIrK2JXM2ZlR1RWZ2FN?=
=?utf-8?B?UzU3M1FBcDlOMURUTXFEclBRZFRPVWtjdjhwMW1uU3cwdXBlc0RnMGJhZy93?=
=?utf-8?B?NkpLT2wwOVYyNUwxVklHT2ZlRlEwdWwvd2w2U1E3WjVpbkVlQktwRnR0TE1M?=
=?utf-8?B?Z0tTV1BJUVRwdXJPTTVmZjRVNXQvSWtFeW1JT1NwUk9WYVdRNDJHMW9rSzJq?=
=?utf-8?B?eDg3bEJBWCtybWc1N24wZHdSTzVTbjFoOVRkY1UxL0ZybGs0YjN6MUtkdzkv?=
=?utf-8?B?R0ltRk03YzJHZmdoQW9FU3UvL1dpL3k1OWVBYUprbWViWlVORFJHR0NmRjhz?=
=?utf-8?Q?ZNcArm1aBHQ/ENgfbMaIGklxVM3rD4WC+qa4wVj?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d09f9a85-3fbf-42f1-301c-08d973843897
X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5210.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 11:23:17.5021 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r0V27X70Xww0/RqQjHpBn/DrTqXO+PNVTQP0shrtXZvMC24QSS6s4qkXN2HP13QRA10YKxjl+ddeP5LTTbM6XA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4905
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v3 07/17] dma/idxd: add datapath structures
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> Add data structures required for the data path for IDXD devices.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
<snip>
> +int
> +idxd_dump(const struct rte_dmadev *dev, FILE *f)
> +{
> + struct idxd_dmadev *idxd = dev->dev_private;
> + unsigned int i;
> +
> + fprintf(f, "== Private Data ==\n");
Minor nit could you call out IDXD somewhere here just to make it clear
which driver is being used?
It may be helpful for debugging just to quickly see if the correct
driver was used.
> + fprintf(f, " Portal: %p\n", idxd->portal);
> + fprintf(f, " Config: { ring_size: %u }\n",
> + idxd->qcfg.nb_desc);
> + fprintf(f, " Batch ring (sz = %u, max_batches = %u):\n\t",
> + idxd->max_batches + 1, idxd->max_batches);
> + for (i = 0; i <= idxd->max_batches; i++) {
> + fprintf(f, " %u ", idxd->batch_idx_ring[i]);
> + if (i == idxd->batch_idx_read && i == idxd->batch_idx_write)
> + fprintf(f, "[rd ptr, wr ptr] ");
> + else if (i == idxd->batch_idx_read)
> + fprintf(f, "[rd ptr] ");
> + else if (i == idxd->batch_idx_write)
> + fprintf(f, "[wr ptr] ");
> + if (i == idxd->max_batches)
> + fprintf(f, "\n");
> + }
> +
> + fprintf(f, " Curr batch: start = %u, size = %u\n", idxd->batch_start, idxd->batch_size);
> + fprintf(f, " IDS: avail = %u, returned: %u\n", idxd->ids_avail, idxd->ids_returned);
> + return 0;
> +}
Reviewed-by: Conor Walsh <conor.walsh@intel.com>
<snip>