From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Chaoyong He <chaoyong.he@corigine.com>, dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com,
Long Wu <long.wu@corigine.com>
Subject: Re: [PATCH v2 2/2] app/testpmd: add support for bonding port's LACP negotiation
Date: Thu, 16 Feb 2023 17:05:36 +0000 [thread overview]
Message-ID: <60234089-2b1e-28a6-4f5f-2b72a3fb847d@amd.com> (raw)
In-Reply-To: <20230216083231.4721-3-chaoyong.he@corigine.com>
On 2/16/2023 8:32 AM, Chaoyong He wrote:
> From: Long Wu <long.wu@corigine.com>
>
> If bonding port is mode4 with disabling dedicated queue and there
> are no other packets, forward loop will not call port's TX function
> and bonding port will not send LACP packets.
>
> Add sending LACP packets periodically in forward loop to avoid
> LACP negotiation failed.
>
> Signed-off-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> ---
> app/test-pmd/config.c | 23 ++++++++++++++
> app/test-pmd/parameters.c | 10 +++++++
> app/test-pmd/testpmd.c | 43 ++++++++++++++++++++++++++-
> app/test-pmd/testpmd.h | 9 ++++++
> doc/guides/testpmd_app_ug/run_app.rst | 4 +++
> 5 files changed, 88 insertions(+), 1 deletion(-)
Is it possible to have this support in
'drivers/net/bonding/bonding_testpmd.c', to not add PMD specific ifdefs
to the generic testpmd code. Like having a bonding specific command etc..
btw, I didn't check the details, just a high level question.
next prev parent reply other threads:[~2023-02-16 17:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 7:15 [PATCH 0/2] enhance bonding PMD to support the " Chaoyong He
2023-02-16 7:15 ` [PATCH 1/2] net/bonding: add independent LACP sending function Chaoyong He
2023-02-16 19:47 ` Stephen Hemminger
2023-02-20 9:46 ` Simon Horman
2023-02-20 16:31 ` Stephen Hemminger
2023-02-22 6:47 ` Chaoyong He
2023-02-16 7:15 ` [PATCH 2/2] app/testpmd: add support for bonding port's LACP negotiation Chaoyong He
2023-02-16 8:32 ` [PATCH v2 0/2] enhance bonding PMD to support the " Chaoyong He
2023-02-16 8:32 ` [PATCH v2 1/2] net/bonding: add independent LACP sending function Chaoyong He
2023-02-16 8:32 ` [PATCH v2 2/2] app/testpmd: add support for bonding port's LACP negotiation Chaoyong He
2023-02-16 17:05 ` Ferruh Yigit [this message]
2023-02-22 6:47 ` Chaoyong He
2023-03-01 2:48 ` [PATCH v3 0/2] enhance bonding PMD to support the " Chaoyong He
2023-03-01 2:48 ` [PATCH v3 1/2] net/bonding: add independent LACP sending function Chaoyong He
2023-03-01 2:48 ` [PATCH v3 2/2] app/testpmd: add support for bonding port's LACP negotiation Chaoyong He
2023-03-15 12:03 ` [PATCH v3 0/2] enhance bonding PMD to support the " Niklas Söderlund
2023-05-12 1:50 ` Chaoyong He
2023-06-06 1:23 ` Chaoyong He
2023-06-06 16:48 ` Ferruh Yigit
2023-06-07 3:10 ` Chaoyong He
2023-06-23 13:32 ` Ferruh Yigit
2023-06-25 1:32 ` humin (Q)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60234089-2b1e-28a6-4f5f-2b72a3fb847d@amd.com \
--to=ferruh.yigit@amd.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).