From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 04BF35592 for ; Mon, 10 Jul 2017 16:37:50 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 591A120951; Mon, 10 Jul 2017 10:37:50 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 10 Jul 2017 10:37:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=htWeQox723MOeG8 WXC0dXcAK4Lb8+OTQY9sCoSYfUAg=; b=rF27/KpORn30+D0G2oZHAGIFa/ZJ4lg 82GkVFnpEUclf2+3PZewI1K0w5rApUBiavTAMyfDSN61+wPbgDbOXcoXR5V1jBYY jLZf3rbd5ySDAs0h9F+4yNikuV0fGs9rQT2Fn9NNdu40yiIENvKjSjWbxjv8Lvzl IAy5By58xt9I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=htWeQox723MOeG8WXC0dXcAK4Lb8+OTQY9sCoSYfUAg=; b=Xx+YkQRz s+Q0s1C9SMOX2y2EjSYqbtms+e+riLuWgegvDd6bI70Q7NhvbyEaAgCobREjPzkb /DgUf6ttza8IfPxGukI4w9qijfxoaPUGXtELJW0xlaV+fT2sDr/uztj+2vMS0Qc7 Myiug8MOk+mHD+NyhKEqkLpb1L2t8xaqZsBs1joyg1QhpQnC/xlvoZHwx/qUkfcI B4n/sYt8FzygmGoRKUaglIG7ZatOkFn5XwaeVztgHKnuv6DNJ2qFBCrnTHAtApQA j8zggKal7cIeVXN7z1QnEUFaf1bQ2r83rEUOO9gH/NgJ4elIS/p3sQja7ogWvF9s apnCGgUDv/+ybg== X-ME-Sender: X-Sasl-enc: v7jCAycf8tkCg1U5vUpuGRTryvrdaooliaFWzdA/+l4D 1499697470 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 07FCF7E74F; Mon, 10 Jul 2017 10:37:50 -0400 (EDT) From: Thomas Monjalon To: santosh Cc: Olivier Matz , dev@dpdk.org, bruce.richardson@intel.com, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, shreyansh.jain@nxp.com, gaetan.rivet@6wind.com, sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com, stephen@networkplumber.org, maxime.coquelin@redhat.com Date: Mon, 10 Jul 2017 16:37:49 +0200 Message-ID: <6030915.ZPqjvz0sR7@xps> In-Reply-To: <3b6f7ebf-0b4b-59a7-d913-0097c045b818@caviumnetworks.com> References: <20170608110513.22548-1-santosh.shukla@caviumnetworks.com> <15653957.xZGtGGaVPI@xps> <3b6f7ebf-0b4b-59a7-d913-0097c045b818@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2017 14:37:51 -0000 10/07/2017 16:22, santosh: > On Monday 10 July 2017 07:39 PM, Thomas Monjalon wrote: > > > 10/07/2017 15:56, santosh: > >> On Monday 10 July 2017 07:21 PM, Thomas Monjalon wrote: > >> > >>> 10/07/2017 15:30, santosh: > >>>> Hi Olivier, > >>>> > >>>> On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: > >>>>> I didn't check the patchset in detail, but in my understanding, > >>>>> what we call physaddr in dpdk is actually a bus address. Shouldn't > >>>>> we start to rename some of these fields and functions to avoid > >>>>> confusion? > >>>> Agree. > >>>> While working on iova mode thing and reading these vir2phy api - > >>>> confused me more. Actually it should be iova2va, va2iova or pa2iova,iova2pa.. > >>>> where iova address is nothing but bus address Or we should refer to linux > >>>> semantics. > >>>> > >>>> We thought of addressing semantics after this series, Not a priority in IMO. > >>> I think it is a priority to start with semantics. > >>> The work is too hard with wrong semantic otherwise. > >> Sorry, I don;t agree with you. Semantic shouldn't lower the iova priority. > >> iova framework is blocking SoC's. w/o iova framework : One has to live with > >> hackish solution for their SoC. > >> > >> Semantic change in any-case could be pipelined. It shouldn't be like > >> Semantics change gets priority and therefore it blocks other SoCs. > > I am not saying it is blocking. > > I just say that you have not started your work by the beginning, > > and now it make reviews difficult (from what I understand). > > You must make all the efforts to make your patches easier to > > understand and accept. > > It's just about changing name for virt2phy api's.. But changing those function > names require deprecation notice, Once iova patchset is merged then I'll > take up responsibility for sending deprecation notice and change those api > name in the next release. This series is not going to be integrated in 17.08. Anyway, you should probably send the deprecation notice now, in order to change the semantic in 17.11. Olivier was also talking about physaddr wording in EAL code.