From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 497B01B1DD; Thu, 25 Jan 2018 23:15:39 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EE8C121395; Thu, 25 Jan 2018 17:15:38 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 25 Jan 2018 17:15:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=ohxLhEDB4pmmAQr4OsBIsIFZcf rL+ozjXttC89Vq9EA=; b=dbWX3mClG9sBhuPNdF46qkSsEFqwFSqib3sGmYl/oc o0hROtZnJ7XplcmQYifDyurfmXiov3zG2JY2D0SEexdoImUOv4/9TiVUaaYY84jH tspNn3WV2MO1K/+JYwyJPoR6xoNjXPBylvKMQUW1/Rqy4JSGBRah+hHb7w0znaSJ g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ohxLhE DB4pmmAQr4OsBIsIFZcfrL+ozjXttC89Vq9EA=; b=pkv7wchreQfWdwG0DWRjGO VLNtgdJHpG4q5m6HOmAULdy1Pf673p/+KfA/zgOZsHJFs6io/QtPNmN0/sGLP/kT 09A5HO4ZnSCZ+SA/BQ5Ij6baF7b92w/AcX4ZB3BNM0+MsNVhvqOygYCoXwi820kr jwc2lEhVsmrB2h1n4w4eqj8bg/+YjbHXPuFLycfGEUdyKR+i5gk5h9QQc5oajqzB A7b92+wfN0loRxIrzzztMHMAz5dXmL0sMZjTpZg+nS5+xUUmgS6pWkNNptZW2qd0 TH0zQyG6xhBWj94u2WGK1eydiKxQ3CnCtuOUfNvps8gGcVkZAHUyvnglIsxX6QjQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 95BA2240F8; Thu, 25 Jan 2018 17:15:38 -0500 (EST) From: Thomas Monjalon To: Xueming Li Cc: stable@dpdk.org, Olivier Matz , dev@dpdk.org, Adrien Mazarguil Date: Thu, 25 Jan 2018 23:14:54 +0100 Message-ID: <6036415.8kRf9vpIdb@xps> In-Reply-To: <20180122131335.tivzooo4zxhlucwa@platinum> References: <20171115155402.9967-1-xuemingl@mellanox.com> <20180119181610.107332-1-xuemingl@mellanox.com> <20180122131335.tivzooo4zxhlucwa@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] cmdline: fix dynamic tokens parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 22:15:39 -0000 22/01/2018 14:13, Olivier Matz: > On Sat, Jan 20, 2018 at 02:16:10AM +0800, Xueming Li wrote: > > When using dynamic tokens, the result buffer contains pointers to some > > location inside the result buffer. When the content of the temporary > > buffer is copied in the final one, these pointers still point to the > > temporary buffer. > > > > This works until the temporary buffer is kept intact, but the next > > commit introduces a memset() that breaks this assumption. > > > > This commit keeps the successfully parsed buffers, and ensures that the > > pointers point to the valid location, by using temp buffer for following > > parsing. > > > > Fixes: 9b3fbb051d2e ("cmdline: fix parsing") > > Cc: stable@dpdk.org > > Signed-off-by: Xueming Li > > Acked-by: Olivier Matz Applied, thanks