DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 3/7] net/txgbe: update link setup process of backplane NICs
Date: Thu, 25 Mar 2021 10:19:35 +0000	[thread overview]
Message-ID: <603dc490-6524-aac4-4865-5670d9ecb9ca@intel.com> (raw)
In-Reply-To: <20210325055141.629963-4-jiawenwu@trustnetic.com>

On 3/25/2021 5:51 AM, Jiawen Wu wrote:
> Add device arguments to support runtime options.
> And use these configuration to control the link setup flow, to adapt to
> different NIC's construction. Use firmware version to control the impact
> of firmware update. And fix some left bugs.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

<...>

> +#define TXGBE_DEBUG_BP
> +#ifdef TXGBE_DEBUG_BP
> +#define BP_LOG(fmt, ...) \
> +		RTE_LOG(CRIT, PMD, "[%lu.%lu]%s(%d): " fmt, \
> +			usec_stamp() / 1000000, usec_stamp() % 1000000, \
> +			__func__, __LINE__, ## __VA_ARGS__)
> +#else
> +#define BP_LOG(fmt, ...) do { } while (0)
> +#endif
> +
>   #endif /* _TXGBE_LOGS_H_ */
> 

The 'BP_LOG' looks like used for developer debug prints, if so I suggest 
removing them completely,
but if not can you please convert it dynamic logging, or using existing dynamic 
logs 'txgbe_logtype_init', 'txgbe_logtype_driver'?

Thanks,
ferruh

  reply	other threads:[~2021-03-25 10:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25  5:51 [dpdk-dev] [PATCH v3 0/7] txgbe backplane AN training Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 1/7] net/txgbe: update device ID Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 2/7] net/txgbe: move firmware version get function to base code Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 3/7] net/txgbe: update link setup process of backplane NICs Jiawen Wu
2021-03-25 10:19   ` Ferruh Yigit [this message]
2021-03-25 15:59     ` Ferruh Yigit
2021-03-26  2:02     ` Jiawen Wu
2021-03-26  8:55       ` Ferruh Yigit
2021-03-26  9:19         ` Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 4/7] net/txgbe/base: support to handle backplane AN73 flow Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 5/7] net/txgbe: handle AN interrupt and link update Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 6/7] net/txgbe: add FFE parameters for user debugging Jiawen Wu
2021-03-25  5:51 ` [dpdk-dev] [PATCH v3 7/7] doc: add txgbe backplane update in release notes Jiawen Wu
2021-03-25 16:07   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=603dc490-6524-aac4-4865-5670d9ecb9ca@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiawenwu@trustnetic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).