From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86F2BA0A02; Thu, 25 Mar 2021 11:19:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68A6F4067B; Thu, 25 Mar 2021 11:19:43 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 0E5B840147 for ; Thu, 25 Mar 2021 11:19:40 +0100 (CET) IronPort-SDR: R9dn1HISR0q1/BExqrri42utgw7yiazvYHXqK50uuU05PE4Mgsf7V5KO08bNIvPHxqiplEl8Xe jft0rr7WuE0w== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="190989961" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="190989961" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 03:19:40 -0700 IronPort-SDR: 0Y3i14rlkEEJM7BSiW6HgxcVdERlZlVvE9QjHm51Zxg7dlUmii8onusN+vFVP4jkSTT9bASWNc ABVms7569pPw== X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="391668957" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.15.136]) ([10.252.15.136]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 03:19:39 -0700 To: Jiawen Wu , dev@dpdk.org References: <20210325055141.629963-1-jiawenwu@trustnetic.com> <20210325055141.629963-4-jiawenwu@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <603dc490-6524-aac4-4865-5670d9ecb9ca@intel.com> Date: Thu, 25 Mar 2021 10:19:35 +0000 MIME-Version: 1.0 In-Reply-To: <20210325055141.629963-4-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 3/7] net/txgbe: update link setup process of backplane NICs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/25/2021 5:51 AM, Jiawen Wu wrote: > Add device arguments to support runtime options. > And use these configuration to control the link setup flow, to adapt to > different NIC's construction. Use firmware version to control the impact > of firmware update. And fix some left bugs. > > Signed-off-by: Jiawen Wu <...> > +#define TXGBE_DEBUG_BP > +#ifdef TXGBE_DEBUG_BP > +#define BP_LOG(fmt, ...) \ > + RTE_LOG(CRIT, PMD, "[%lu.%lu]%s(%d): " fmt, \ > + usec_stamp() / 1000000, usec_stamp() % 1000000, \ > + __func__, __LINE__, ## __VA_ARGS__) > +#else > +#define BP_LOG(fmt, ...) do { } while (0) > +#endif > + > #endif /* _TXGBE_LOGS_H_ */ > The 'BP_LOG' looks like used for developer debug prints, if so I suggest removing them completely, but if not can you please convert it dynamic logging, or using existing dynamic logs 'txgbe_logtype_init', 'txgbe_logtype_driver'? Thanks, ferruh