From: Thomas Monjalon <thomas@monjalon.net> To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org, stable@dpdk.org, David Hunt <david.hunt@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>, Alan Carew <alan.carew@intel.com> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] power: make guest channel headers public Date: Mon, 05 Oct 2020 23:44:49 +0200 Message-ID: <6046120.mQ0ExDuKPD@thomas> (raw) In-Reply-To: <20200821171017.50531-2-bruce.richardson@intel.com> \0> The channel commands header file contains definitions that are used by the > example application for power management, and so need to be made public. > Similarly the guest_channel.h header is used by the guest_cli example > utility, so needs to be public also. Without this change, the example > apps, or any end-user apps based on them, can not be compiled outside the > main DPDK build. [...] > rename lib/librte_power/{channel_commands.h => rte_power_channel_commands.h} (100%) > rename lib/librte_power/{guest_channel.h => rte_power_guest_channel.h} (98%) Yes there are dirty includes, but it requires more than just a renaming. At least the namespace of these functions should be checked to start with "rte_". But before adding all these new functions as stable public API, I would like we check whether it is a well designed API or not.
next prev parent reply other threads:[~2020-10-05 21:45 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-14 11:00 [dpdk-dev] [PATCH 0/4] fixes for example app builds Bruce Richardson 2020-08-14 11:00 ` [dpdk-dev] [PATCH 1/4] power: make guest channel headers public Bruce Richardson 2020-08-14 11:05 ` Bruce Richardson 2020-08-14 11:00 ` [dpdk-dev] [PATCH 2/4] examples/vm_power_manager: fix string truncation warning Bruce Richardson 2020-08-14 11:00 ` [dpdk-dev] [PATCH 3/4] examples/mp_server: fix snprintf overflow Bruce Richardson 2020-08-14 15:01 ` Stephen Hemminger 2020-08-14 11:00 ` [dpdk-dev] [PATCH 4/4] examples/mp_server: clear string truncation warning Bruce Richardson 2020-08-21 17:10 ` [dpdk-dev] [PATCH v2 0/4] fixes for example app builds Bruce Richardson 2020-08-21 17:10 ` [dpdk-dev] [PATCH v2 1/4] power: make guest channel headers public Bruce Richardson 2020-08-26 10:08 ` David Hunt 2020-10-05 21:44 ` Thomas Monjalon [this message] 2020-08-21 17:10 ` [dpdk-dev] [PATCH v2 2/4] examples/vm_power_manager: fix string truncation warning Bruce Richardson 2020-08-26 10:09 ` David Hunt 2020-08-21 17:10 ` [dpdk-dev] [PATCH v2 3/4] examples/mp_server: fix snprintf overflow Bruce Richardson 2020-10-09 11:22 ` Nicolau, Radu 2020-08-21 17:10 ` [dpdk-dev] [PATCH v2 4/4] examples/mp_server: clear string truncation warning Bruce Richardson 2020-10-09 11:21 ` Nicolau, Radu 2020-10-28 16:26 ` [dpdk-dev] [PATCH v3 0/3] fixes for example app builds Bruce Richardson 2020-10-28 16:27 ` [dpdk-dev] [PATCH v3 1/3] examples/vm_power_manager: fix string truncation warning Bruce Richardson 2020-10-28 16:27 ` [dpdk-dev] [PATCH v3 2/3] examples/mp_server: fix snprintf overflow Bruce Richardson 2020-10-28 16:27 ` [dpdk-dev] [PATCH v3 3/3] examples/mp_server: clear string truncation warning Bruce Richardson 2020-10-30 13:56 ` [dpdk-dev] [PATCH v3 0/3] fixes for example app builds David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6046120.mQ0ExDuKPD@thomas \ --to=thomas@monjalon.net \ --cc=alan.carew@intel.com \ --cc=bruce.richardson@intel.com \ --cc=david.hunt@intel.com \ --cc=dev@dpdk.org \ --cc=pablo.de.lara.guarch@intel.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git