From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B88B5A0558; Wed, 25 May 2022 16:11:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64DA940146; Wed, 25 May 2022 16:11:53 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 510E5400EF for ; Wed, 25 May 2022 16:11:52 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id BADB88A; Wed, 25 May 2022 17:11:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru BADB88A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1653487911; bh=kJaJnib2u9QaXVUbqA26Mjb3j0FTI7ISSv/rtXWLvzA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Y1P7R84QrWdR5kXZN7TmA0XTNUywouZc2T2bOQsD8DNSmQfYTspYcnsxZOSkgKWmb XHUEqFQTo7MojE0Dogj7hOJw/Aop8SpFm4reV3m51Zzs7f2wgbZ5SY1BmmOnSR1K3V Ee4KWgQzMfveT4H7wdholnz4NHwFCqqrkqN1iHxU= Message-ID: <6046763c-30ff-fd1f-6ff6-e615891c46bc@oktetlabs.ru> Date: Wed, 25 May 2022 17:11:51 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 0/7] introduce per-queue limit watermark and host shaper Content-Language: en-US To: Thomas Monjalon , Spike Du , =?UTF-8?Q?Morten_Br=c3=b8rup?= Cc: matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, dev@dpdk.org, rasland@nvidia.com, stephen@networkplumber.org, ferruh.yigit@amd.com, david.marchand@redhat.com References: <20220522055900.417282-1-spiked@nvidia.com> <6057836.17fYzF0512@thomas> <98CBD80474FA8B44BF855DF32C47DC35D870AA@smartserver.smartshare.dk> <3519312.WbyNdk4fJJ@thomas> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <3519312.WbyNdk4fJJ@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/24/22 22:22, Thomas Monjalon wrote: > 24/05/2022 21:00, Morten Brørup: >> From: Thomas Monjalon [mailto:thomas@monjalon.net] >>> 24/05/2022 17:20, Spike Du: >>>> LWM(limit watermark) is per RX queue attribute, when RX queue >>> fullness reach the LWM limit, HW sends an event to dpdk application. >> >> Please ignore this comment, it is not important, but I had to get it out of my system: I assume that the "LWM" name is from the NIC datasheet; otherwise I would probably prefer something with "threshold"... LWM is easily confused with "low water mark", which is the opposite of what the LWM does. Names are always open for discussion, so I won't object to it. > > Yes it is a threshold, and yes it is often called a watermark. > I think we can get more ideas and votes about the naming. > Please let's conclude on a short name which can be inserted > easily in function names. As I understand it is an Rx queue fill (level) threshold. "fill_thresh" or "flt" if the first one is too long.