From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B7DCA04E6; Thu, 19 Nov 2020 19:42:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8454FF3E; Thu, 19 Nov 2020 19:42:32 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id D5C532AB for <dev@dpdk.org>; Thu, 19 Nov 2020 19:42:30 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 1B2F45C00F0; Thu, 19 Nov 2020 13:42:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 19 Nov 2020 13:42:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= waUJ+eK9ephCPj/r/mALa5gxYpvYEcuhGyRU/KMct6Y=; b=ruUxi8LV2xvFe58P XDKjnljFBcTLRzeZwOYDuFqWEjK38MuA/O75mSQ9dKv+cox32hKRUARicPTzdT5D gLcNSVq+ChM42Frsxmx2GxRKUo1gmrp2WcDWauqYoLmz+Y9sajOxNhseSasIrMoR QvEjgvIY0hc2Jqnq2oc6RWh+COPhACeWVT1Bqjl90V2t47xA4bLM/ZsyzXvcdOr3 YH0r0xhKpAZ18bOwhv+xLdugHGrU6FTpft5oMTw0iCcpKvXa8mSJhY8YJUhM0bhS 5SJDbtYgF7njhiF+t1UrqxNelbAGemPxZxl+nCR+IgLWWwHlV5WIgVL4YvqZYfBO egqQLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=waUJ+eK9ephCPj/r/mALa5gxYpvYEcuhGyRU/KMct 6Y=; b=qOWLQ84O9i7+cKJmvk68h9B9JF62Hypq5o3O4IlF6sjyJsrMtt0aAJALL JuwM7VXw8XNJRgMPigLy9cnId4+Vajx5+V8d82praAjJjFsTZVabK3TCunWlTdI+ vhSmxq/nA150MGAxyj91Z0iB5Hq9xkqjWA/Z9FYY/tSdIx69YOnD299owXibtmkh 2baLpl7PUjqBr3UbiPGvBtNh5FPZhDMQ+HS2ojyoZQYaY/mbF46UIH0j/zyjSf1n hXwvAx/XA7BIvu4Ro4UlML8cN2N3EiMC6WMeprCfQswmHbQ+Jbk2Ew5O/qYfaRT+ fvz/eMZtCgguvj2mdPJkkZba1Y0FA== X-ME-Sender: <xms:lLy2X5bAjm_ga9Cgcet2cU_aULgpdPnUkeSBpoO5LjzPGPuvu5LTQg> <xme:lLy2XwbgDKdAtlu_sVgf-6zIyC_B6HXIuXNMh3pm8uWL_HJqOXe6rncs5pc949vHM V6-8wJjXRNNCipb9Q> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudefjedgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefgeffiefhfeettdfhvdfgteekffffudekvedtvedtvdfgveeu udevgedvgeegtdenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: <xmx:lLy2X78eqWJzHZg940H7IySYLZX8hCEEFCr0g1mOHIpY-IvZn2VE2w> <xmx:lLy2X3odmTJx26yGyC1PqAXxZJH1kKDr-iwWBTvbqeSJ-rq0uj4OmQ> <xmx:lLy2X0rtaFAlKCsA85VZTPZfUd9mIZE1Z3mR2q3mKsPQYTpXWB7DHg> <xmx:lby2X_VMMLcobMU6ncWEpeOriV7UxlffQMMM8RlOEc0WoqPhaktc-Q> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8ECB23064AB8; Thu, 19 Nov 2020 13:42:27 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Raslan Darawsheh <rasland@nvidia.com>, matan@nvidia.com, Ferruh Yigit <ferruh.yigit@intel.com> Cc: viacheslavo@nvidia.com, =?ISO-8859-1?Q?Beno=EEt?= Ganne <bganne@cisco.com>, dev@dpdk.org Date: Thu, 19 Nov 2020 19:42:26 +0100 Message-ID: <6072180.DC7U9P3PlK@thomas> In-Reply-To: <77998079-5ad7-edc4-1153-c318e11c25d0@intel.com> References: <20200327172449.6514-1-bganne@cisco.com> <20201119142018.25277-1-rasland@nvidia.com> <77998079-5ad7-edc4-1153-c318e11c25d0@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 19/11/2020 18:48, Ferruh Yigit: > On 11/19/2020 2:20 PM, Raslan Darawsheh wrote: > > From: Beno=EEt Ganne <bganne@cisco.com> > >=20 > > mlx5 PMD refuses to update link state if link speed is defined but > > status is down or if link speed is undefined but status is up, even if > > the ioctl() succeeded. > > This prevents application to detect link up/down event, especially when > > the link speed is not correctly detected. > > As link speed is nice to have whereas link status is mandatory for > > operations, always update link state regardless of link speed. The > > application can then check link speed if needs be. > >=20 >=20 > Hi Raslan, Matan, >=20 > Can you please provide the Fixes tag? Also should this fix backported? I think it should not be backported because it is a behaviour change relying on API doc change.