From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 1CC842965 for ; Fri, 29 Mar 2019 20:56:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5576821B4F; Fri, 29 Mar 2019 15:56:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 29 Mar 2019 15:56:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=UvRe9//ejPPsQJDAHFn9CyfVAPojsgQ7H/GHU4Cggp8=; b=Ik/KbPAHvL6q 4pxnLh++AuDKx0ymMICmX652LStZDpzyudjLDqEpfwalSNXH97jlCmp0ySFODhos NgPu2gaScVJkiHr2zwHVJwxQtzDV61yidR0vcUKthJctEAqElRnPaR8isKdS1ygM zcXvN/JSI7Ramm17KLLvN0yqKTLwlPI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=UvRe9//ejPPsQJDAHFn9CyfVAPojsgQ7H/GHU4Cgg p8=; b=LfMUmZph2+bpuyEe/5GJaWUfh5Rv+HbW9wepkp3DgGrlwFZe9wKzbsHBF 8+xHD5EE26keL5zA88SYBUp0bcsxWzYWwPu5yMef1rxwYthNf98uCp1X6gO4aaOW YiER6GZC0oNvwduQz5jAm3PuoAWtd6bpU9i6mskLOu9SbpT6S2GSA5Es/isco+pM Iee6AMV2VM32mAq/zxt3n6LhcyZIodHbyVGL24k3mA/uteXcE4L0+sl+OLfPKlz4 4YjM2e5YHf9lpKIWtWlfyua9zErNzneZO0tUiucvWm/T5jz+rpyB+2VN7ViRGyAA 57dXcjMi5wuQyJf9vXFzxMMVyPgdQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeejgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 86AD2E464B; Fri, 29 Mar 2019 15:56:25 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal Cc: Fan Zhang , "dev@dpdk.org" , "arkadiuszx.kusztal@intel.com" , "pablo.de.lara.guarch@intel.com" , "declan.doherty@intel.com" , "fiona.trahe@intel.com" Date: Fri, 29 Mar 2019 20:56:24 +0100 Message-ID: <6074697.YrIqqQDgZf@xps> In-Reply-To: <842316e4-2ea3-2eff-6915-da380c7515e5@nxp.com> References: <20190301104658.7582-1-roy.fan.zhang@intel.com> <842316e4-2ea3-2eff-6915-da380c7515e5@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] doc: add cryptodev xform deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2019 19:56:28 -0000 29/03/2019 16:59, Akhil Goyal: > > On 3/29/2019 9:19 PM, Akhil Goyal wrote: > > > > On 3/29/2019 7:45 PM, Akhil Goyal wrote: > >> On 3/29/2019 7:29 PM, Akhil Goyal wrote: > >>> On 3/22/2019 10:04 PM, Fan Zhang wrote: > >>>> This patch adds the deprecation notice of changing Cryptodev > >>>> symmetric xform structure. The proposed change is to making > >>>> key pointers in the crypto xforms (cipher, auth, aead) to > >>>> indicate neither the library or the drivers will not change > >>>> the content of the key buffer. > >>>> > >>>> Signed-off-by: Fan Zhang > >>>> --- > >>>> v3: > >>>> - Removed target release. > >>>> > >>>> v2: > >>>> - Added description. > >>>> > >>>> doc/guides/rel_notes/deprecation.rst | 4 ++++ > >>>> 1 file changed, 4 insertions(+) > >>>> > >>>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > >>>> index 1b4fcb7e6..f35ac5b96 100644 > >>>> --- a/doc/guides/rel_notes/deprecation.rst > >>>> +++ b/doc/guides/rel_notes/deprecation.rst > >>>> @@ -75,3 +75,7 @@ Deprecation Notices > >>>> > >>>> * crypto/aesni_mb: the minimum supported intel-ipsec-mb library version will be > >>>> changed from 0.49.0 to 0.52.0. > >>>> + > >>>> +* cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms > >>>> + structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and > >>>> + ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``. > >>> Acked-by: Akhil Goyal > >> delegated to master. > >> should be applied along with > >> http://patches.dpdk.org/patch/51395/ > >> > > Applied to dpdk-next-crypto > > Thanks. > > > This patch is proposing that there will be change in the xform > structure(API breakage) and the change is happening in the same release. > I suppose this is not allowed. > > @Thomas: Could you please suggest if the deprecation notice should be > added in this release and the changes in the next release? First of all, we must avoid breaking API. If it is not avoidable, we must announce it and do the change in the next release. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7FE4EA05D3 for ; Fri, 29 Mar 2019 20:56:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49C092BD3; Fri, 29 Mar 2019 20:56:29 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 1CC842965 for ; Fri, 29 Mar 2019 20:56:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5576821B4F; Fri, 29 Mar 2019 15:56:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 29 Mar 2019 15:56:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=UvRe9//ejPPsQJDAHFn9CyfVAPojsgQ7H/GHU4Cggp8=; b=Ik/KbPAHvL6q 4pxnLh++AuDKx0ymMICmX652LStZDpzyudjLDqEpfwalSNXH97jlCmp0ySFODhos NgPu2gaScVJkiHr2zwHVJwxQtzDV61yidR0vcUKthJctEAqElRnPaR8isKdS1ygM zcXvN/JSI7Ramm17KLLvN0yqKTLwlPI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=UvRe9//ejPPsQJDAHFn9CyfVAPojsgQ7H/GHU4Cgg p8=; b=LfMUmZph2+bpuyEe/5GJaWUfh5Rv+HbW9wepkp3DgGrlwFZe9wKzbsHBF 8+xHD5EE26keL5zA88SYBUp0bcsxWzYWwPu5yMef1rxwYthNf98uCp1X6gO4aaOW YiER6GZC0oNvwduQz5jAm3PuoAWtd6bpU9i6mskLOu9SbpT6S2GSA5Es/isco+pM Iee6AMV2VM32mAq/zxt3n6LhcyZIodHbyVGL24k3mA/uteXcE4L0+sl+OLfPKlz4 4YjM2e5YHf9lpKIWtWlfyua9zErNzneZO0tUiucvWm/T5jz+rpyB+2VN7ViRGyAA 57dXcjMi5wuQyJf9vXFzxMMVyPgdQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeejgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 86AD2E464B; Fri, 29 Mar 2019 15:56:25 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal Cc: Fan Zhang , "dev@dpdk.org" , "arkadiuszx.kusztal@intel.com" , "pablo.de.lara.guarch@intel.com" , "declan.doherty@intel.com" , "fiona.trahe@intel.com" Date: Fri, 29 Mar 2019 20:56:24 +0100 Message-ID: <6074697.YrIqqQDgZf@xps> In-Reply-To: <842316e4-2ea3-2eff-6915-da380c7515e5@nxp.com> References: <20190301104658.7582-1-roy.fan.zhang@intel.com> <842316e4-2ea3-2eff-6915-da380c7515e5@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] doc: add cryptodev xform deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190329195624.DgGQcz1t-uyE8jGEO097YY3fO-R6ngyJDV53dZpLT6c@z> 29/03/2019 16:59, Akhil Goyal: > > On 3/29/2019 9:19 PM, Akhil Goyal wrote: > > > > On 3/29/2019 7:45 PM, Akhil Goyal wrote: > >> On 3/29/2019 7:29 PM, Akhil Goyal wrote: > >>> On 3/22/2019 10:04 PM, Fan Zhang wrote: > >>>> This patch adds the deprecation notice of changing Cryptodev > >>>> symmetric xform structure. The proposed change is to making > >>>> key pointers in the crypto xforms (cipher, auth, aead) to > >>>> indicate neither the library or the drivers will not change > >>>> the content of the key buffer. > >>>> > >>>> Signed-off-by: Fan Zhang > >>>> --- > >>>> v3: > >>>> - Removed target release. > >>>> > >>>> v2: > >>>> - Added description. > >>>> > >>>> doc/guides/rel_notes/deprecation.rst | 4 ++++ > >>>> 1 file changed, 4 insertions(+) > >>>> > >>>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > >>>> index 1b4fcb7e6..f35ac5b96 100644 > >>>> --- a/doc/guides/rel_notes/deprecation.rst > >>>> +++ b/doc/guides/rel_notes/deprecation.rst > >>>> @@ -75,3 +75,7 @@ Deprecation Notices > >>>> > >>>> * crypto/aesni_mb: the minimum supported intel-ipsec-mb library version will be > >>>> changed from 0.49.0 to 0.52.0. > >>>> + > >>>> +* cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms > >>>> + structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and > >>>> + ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``. > >>> Acked-by: Akhil Goyal > >> delegated to master. > >> should be applied along with > >> http://patches.dpdk.org/patch/51395/ > >> > > Applied to dpdk-next-crypto > > Thanks. > > > This patch is proposing that there will be change in the xform > structure(API breakage) and the change is happening in the same release. > I suppose this is not allowed. > > @Thomas: Could you please suggest if the deprecation notice should be > added in this release and the changes in the next release? First of all, we must avoid breaking API. If it is not avoidable, we must announce it and do the change in the next release.