From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CB16A0542; Mon, 6 Jun 2022 16:20:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AD264021E; Mon, 6 Jun 2022 16:20:30 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 9175A40150 for ; Mon, 6 Jun 2022 16:20:29 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9C1725C01A1; Mon, 6 Jun 2022 10:20:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 06 Jun 2022 10:20:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1654525226; x= 1654611626; bh=oFJ58Z58MpYvgOtsKwG43KUKJbSjHqhaAbZKYEmSwVs=; b=n +R5JYdoRwQVoLo+FevOoQT7zkfr+aNPE+/FSV6R/IVAilJ7MT2jcofEKONq7XkI0 vIpQtsHrz3qYmCU+ftg20Fr/IyPHj7rdzCmiYssFvyaqy76uQYwoUgrrin8w7QFW 59xWnuIZRRtbqfnqA8AJ5l6lJWbiXkDGXTJvHfwJ/kWpuAKQ5sbOeGe5dSeTsEZl Z3wMgE6dXDYpxSXIn9mgHa3kT9Erky4wdjngjF/M4B9gMkD2yqladGkRvO3G5sEl CQc+nyX+ZMTjiVs6OOG2lxKTB/kFSoXDzsIi69rGg4Pj/WsOBNSRq4k4OWK6w6/F TUJDDcSXa4wIhyR/tNi7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1654525226; x= 1654611626; bh=oFJ58Z58MpYvgOtsKwG43KUKJbSjHqhaAbZKYEmSwVs=; b=R fD9lQk6V0C67d99uMYRITiL8X6jtTOuViQDqJCbIhfRj7FaGFqfdCCysN4tvaAZO XdaT8514lsM8OeaYFEkgcCKnavDFhFFx+q1BzZHXQDPP/j+NLSZCLnzGzv1rrzoq iUC7Yd1ppkKlsFZO8VNoajfNh7nWzQYw+M55ggCxtr4RDcYEnTU6VLtslgnmCgqk Hh1VHT32oHOcdJU0yMkmKbgkQwPxigDXsM6KL/iXydEM/xNSq5r+z9Bn9f6fLQ3/ 3n9BzD5IMGAzgwn0rh+iknGxLbS3o/cCniOsfncmotitaRC3D373Vlz5lshiRAl+ r6my22W0lXFlb9GyCF2fg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddtvddgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Jun 2022 10:20:25 -0400 (EDT) From: Thomas Monjalon To: "Yang, Qiming" , "Zhang, Qi Z" Cc: "dev@dpdk.org" , "Liu, KevinX" , "Mcnamara, John" Subject: Re: [PATCH v2] net/igc: add I226 support Date: Mon, 06 Jun 2022 16:20:20 +0200 Message-ID: <6077154.irdbgypaU6@thomas> In-Reply-To: References: <20220519060443.2585871-1-qiming.yang@intel.com> <8688555.GXAFRqVoOG@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/06/2022 14:06, Zhang, Qi Z: > > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Monday, June 6, 2022 7:46 PM > > To: Yang, Qiming ; Zhang, Qi Z > > > > Cc: dev@dpdk.org; Liu, KevinX ; Mcnamara, John > > > > Subject: Re: [PATCH v2] net/igc: add I226 support > > > > 06/06/2022 12:54, Zhang, Qi Z: > > > > > > > -----Original Message----- > > > > From: Thomas Monjalon > > > > Sent: Monday, June 6, 2022 6:49 PM > > > > To: Yang, Qiming ; Zhang, Qi Z > > > > > > > > Cc: dev@dpdk.org; Liu, KevinX > > > > Subject: Re: [PATCH v2] net/igc: add I226 support > > > > > > > > 06/06/2022 01:12, Zhang, Qi Z: > > > > > > > > > > > -----Original Message----- > > > > > > From: Thomas Monjalon > > > > > > Sent: Monday, June 6, 2022 12:42 AM > > > > > > To: Zhang, Qi Z ; Yang, Qiming > > > > > > > > > > > > Cc: dev@dpdk.org; Liu, KevinX > > > > > > Subject: Re: [PATCH v2] net/igc: add I226 support > > > > > > > > > > > > 25/05/2022 07:57, Qiming Yang: > > > > > > > Added I226 Series device ID in igc driver and updated igc > > > > > > > guide document for new devices. > > > > > > > > > > > > > > Signed-off-by: Qiming Yang > > > > > > > Signed-off-by: Kevin Liu > > > > > > > --- > > > > > > > v2: > > > > > > > * rebased > > > > > > > --- > > > > > > > doc/guides/nics/igc.rst | 14 +++++++------- > > > > > > > doc/guides/rel_notes/release_22_03.rst | 5 +++++ > > > > > > > > > > > > You are sending a patch after 22.03 is closed, so it should be > > > > > > listed in > > > > 22.07! > > > > > > > > > > > > I will fix while pulling the tree prepared by Qi. > > > > > > Please be more careful with the basic checks. > > > > > > > > > > Thanks for capture this, have dropped this patch in dpdk-next-net-intel. > > > > > A new version is required. > > > > > > > > Too late, it is in the main tree with release notes fixed. > > > > Do you need more fix? > > > > > > OK, I guess we need to revert it with a new fix. > > > Sorry for the chaos... > > > > Why revert? If there is a bug, just fix it. > > No a revert patch, I mean a fix patch with revert change on release_22_03.rst There is a misunderstanding, please read again above, I've said that I've fixed the release notes while pulling the tree. So I assume we are fine.