DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Adam Dybkowski <adamx.dybkowski@intel.com>,
	dev@dpdk.org, fiona.trahe@intel.com, akhil.goyal@nxp.com,
	john.mcnamara@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 1/1] doc: document vfio-pci usage with QAT PMD
Date: Wed, 9 Sep 2020 11:51:48 +0100
Message-ID: <6087c0a7-9321-d337-f5fb-57d93b8ac991@intel.com> (raw)
In-Reply-To: <20200908161950.601-2-adamx.dybkowski@intel.com>

On 08-Sep-20 5:19 PM, Adam Dybkowski wrote:
> This patch marks the old igb-uio driver as unsecure when used
> with the QAT PMD and updates all examples to recommend using
> vfio-pci instead.
> It also mentions security issues with the QAT CPM and provides
> information about the new vfio-pci parameter 'disable_denylist'
> available in Linux kernels 5.9 and later.
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> ---

<snip>

>   
>       cd to the top-level DPDK directory
>       modprobe uio

No need to modprobe uio if you're using VFIO.

> -    insmod ./build/kmod/igb_uio.ko
> -    echo "8086 37c9" > /sys/bus/pci/drivers/igb_uio/new_id
> +    modprobe vfio-pci
> +    echo "8086 37c9" > /sys/bus/pci/drivers/vfio-pci/new_id

This seems like very outdated instructions from when we had a PCI ID 
filtering in igb_uio. Devbind way is better in every way, so why keep 
this at all?

>       lspci -vvd:37c9
>   
> +Use ``modprobe vfio-pci disable_denylist=1`` from kernel 5.9 onwards.
> +See note in the section `Binding the available VFs to the vfio-pci driver`_
> +above.
>   
> -Another way to bind the VFs to the DPDK UIO driver is by using the
> +Another way to bind the VFs to the vfio-pci driver is by using the
>   ``dpdk-devbind.py`` script::
>   
>       cd to the top-level DPDK directory
> -    ./usertools/dpdk-devbind.py -b igb_uio 0000:03:01.1
> +    ./usertools/dpdk-devbind.py -b vfio-pci 0000:03:01.1
>   
>   Testing
>   ~~~~~~~
> 


-- 
Thanks,
Anatoly

  reply	other threads:[~2020-09-09 10:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08 14:20 [dpdk-dev] [PATCH] " Adam Dybkowski
2020-09-08 16:00 ` Trahe, Fiona
2020-09-08 16:19 ` [dpdk-dev] [PATCH v2 0/1] " Adam Dybkowski
2020-09-08 16:19   ` [dpdk-dev] [PATCH v2 1/1] " Adam Dybkowski
2020-09-09 10:51     ` Burakov, Anatoly [this message]
2020-09-08 19:22   ` [dpdk-dev] [PATCH v2 0/1] " Mcnamara, John
2020-09-15 11:14   ` [dpdk-dev] [PATCH v3 " Adam Dybkowski
2020-09-15 11:14     ` [dpdk-dev] [PATCH v3 1/1] " Adam Dybkowski
2020-09-16 12:33       ` Burakov, Anatoly
2020-10-08 21:29       ` Akhil Goyal
2020-10-12 10:50         ` Dybkowski, AdamX
2020-10-12 10:43     ` [dpdk-dev] [PATCH v4 0/1] " Adam Dybkowski
2020-10-12 10:43       ` [dpdk-dev] [PATCH v4 1/1] " Adam Dybkowski
2020-10-13 14:10       ` [dpdk-dev] [PATCH v5 0/1] " Adam Dybkowski
2020-10-13 14:10         ` [dpdk-dev] [PATCH v5 1/1] " Adam Dybkowski
2020-10-28 11:05           ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6087c0a7-9321-d337-f5fb-57d93b8ac991@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=adamx.dybkowski@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=john.mcnamara@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git