From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 290B443EA5; Thu, 18 Apr 2024 17:39:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D880F40272; Thu, 18 Apr 2024 17:39:26 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2080.outbound.protection.outlook.com [40.107.244.80]) by mails.dpdk.org (Postfix) with ESMTP id 0A26540042 for ; Thu, 18 Apr 2024 17:39:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F8uZG7n7GFrf3+/ebkiNFF3CwP9LwKBfanVfqmRCWJ6f6sc+IAUPgCSXrTDZEC1wQJjTDezaJM0axlh5xiUN6Ux1+AO+5rS78Aci8e1qrZGIKM295qffGcu3ajvZlh2DJqyIcjfiV5q7Jr3AqUzxcJ6kc9YqKA59ZhDGN7EJLxEGj/tL+2V+n1nfRokjgNhruuaCJrYkPRrc+GzOSI0Jy8bq5ImAVzZ+OxNkL4kJeIytOd/T0kEhdwDDgB9Mm0pJUQAYWFBEnD/cmOVpem+ioKvAip7ETp+7bmPmj0ArlU7UAKspWBRVWVnaTY7nbXqted5Cz4NN9qQiWjPZWlvw6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BksKIMTC/9yX/2i2GwrPnKttVUYuOYCEU2rIddJYNIw=; b=kZR4UnIUJHAfq+Q5zhJ1fGqY94hK+sgpqEYOABKukqoKvBXdFeFkcSh8l4S5eA55oDQcOiqTtjquX+te8ykAbHX0Kk9BN/FKRZ76nTCnug/li2KAVaek335rOx1ZlZuR5pyXRy5iAqdE+Hij8pwuvT4ggzOsxSaeF7e+pQVeT+BvzvqO/SGf87+Aqhc6pPhEekxSDxKjCvfQvzEy+Lb8owUi3ia7ZIdkmoIAm8CWFvalhgJ8VvVV/OxpaaqFxDffDtI+A0gsQOiK6fMg+MjYj1bT+3ELDI2nRCGaFShhSMSZ2GMZbvArKgSFJicgf38FT7+tIdSuqrVAvMH+z1QxdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BksKIMTC/9yX/2i2GwrPnKttVUYuOYCEU2rIddJYNIw=; b=ko5Qlz7kcH7mLLlAwaEFQqNEtARZiELN8zU7XAurz8BsJVgvLcctMF5LVLyejGKkshnGrWYq49/CDt7KjcAlNi75ZXILE04eZf4Yx4CKuoKpy9W0z8n0ocIeNkqPM9vKz9VO+K4Uvt8B1CklUbwkV4vkqlt2dSUVxAumT1lGn3A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ1PR12MB6123.namprd12.prod.outlook.com (2603:10b6:a03:45a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Thu, 18 Apr 2024 15:39:19 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7452.049; Thu, 18 Apr 2024 15:39:19 +0000 Message-ID: <6098192b-96a5-48cd-aad2-a178745a66cd@amd.com> Date: Thu, 18 Apr 2024 16:39:14 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] app/testpmd: enable cli for programmable action From: Ferruh Yigit To: Qi Zhang , aman.deep.singh@intel.com, yuying.zhang@intel.com, orika@nvidia.com, cristian.dumitrescu@intel.com Cc: dev@dpdk.org, "Mcnamara, John" , Bruce Richardson References: <20231005100246.242970-1-qi.z.zhang@intel.com> <20231011120332.626859-1-qi.z.zhang@intel.com> <17c02040-48e2-4a4d-84f4-9431dc5b1c1b@amd.com> Content-Language: en-US Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <17c02040-48e2-4a4d-84f4-9431dc5b1c1b@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0003.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:338::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ1PR12MB6123:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b8a1fd5-598f-47a9-39ba-08dc5fbdb62e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hln/4A8vhmn882sepr9EkPRAwCEPonjfo+U94zrpLbQQ0FzVlL4GVLtPCOa4F9yDrookEMWM5l3dWLScfRNe+btQ7LdOoyiqj0lBmJ7ziLVNbWk90/nV5i8pnkbqvYRxjB7kA+QooZ024Zuq5UBV7zn7WuztuenjSFyxkFnV8OLprHz6oR42gdrryCitCydLHItygPzPyYW1XDMsweQX9Q16/hqlCzRYsbzSF7NObo5v9om/kWtqTEJ4IfMz8mdWyTILk1FB9KEoaehymy48c3pzJP68M6blUGNwnkd7RDCHkXOorIJf1J6WkG5zHCNhlcN6K3l3EcYCQCpmvtM/+WmAr9968dyEJtrhEkLvTtxXlB3/OZd8GZpj1t8IClFU+L/XNQSibZmLQdBqrlTvlOFAdtbLt6WiQO4VUJ1rEDqZrESZIVPqcuuFtdhWQrAXbvlKhNmoN5rmx9MMLAUg9Ta4T/8W4vGEfbuvsw4ZJPZsQiVAcvXbEqOFPdGwKMSw3LWtt/T0mT/l3m6fDCgvII1Q6OABnFee3GFmg/1I6XHcOltcjKmJuzIfc0a0Wb3gLpcovDvzvR99yC6d2vDUtqoWcG5jRSoXSYlL/7mYPDTMLwV2M5sQ28f6wNU1+PvfGR8vG+YFsGgP0vW4hNdEIojsRKuOPgPNWclee4NNylE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3lHd0ZGTFdma1huODlWbkFsTnNrNng5cHhXMkt4Y25kM003bCszbHVwa2E2?= =?utf-8?B?Tk1hb0Nyc0xpTEJsVWxVYm0wZG5ncVRrMlpPMS85eFFOSTRuS05Fc2RvQnQv?= =?utf-8?B?Y3lkMlRDcEo0eDUrZEg4WWZmbDE5NlEyaHVtMnlLZHozcGp1ZVkzdzlyZlpn?= =?utf-8?B?NE03Q0VoVnpVVXBXTDl0eU5aMWJYU2ZVbHpoaDZLQzljZGVod1o1NmM1alZY?= =?utf-8?B?UU1mbjRLdm15WURFT0prNmU0dG8zdVJzQ1o5NFc0N01pc2JUK2d3QnlqK2lY?= =?utf-8?B?Ym8zQm9CaUd5N3RtUmtuMzZrY0FxMGZiekpzVlByaGhGMVVyY0lCZGRORkNY?= =?utf-8?B?TWdEVkVVN0MzeUppZWxPL24ySndUVGk2Uzg5STUvSk1KQUd3UU44OGhHalgr?= =?utf-8?B?Y0hjSTVKUzhQTjVrcGdKQ29mejYrSlVXWEhNNlRaU29iZXYwUFlCY1NqZFRj?= =?utf-8?B?Mk0zUFB6eGJsN3k5TTRwUGZPcGdmeWl2bGdlL2ErbE9aUjFYMnQwc2FOUkc4?= =?utf-8?B?eHZTVzdzVVJoaDVZQ29SdUUzb05BdUpzckZaVjN1Sm1MTE9QNmtZT0dDRXAz?= =?utf-8?B?ZGNyOVZYdUdpWTVTbW1oZDY5WGVzMENiaUZ2L1VIV2pWVmd0V0ZCbUxjdzZS?= =?utf-8?B?ZjU3ZVhKdy9YV3pyMEE5ZUlEN2F2RWFtYmNHL3FDUDdHZkwxc1BaQVN4SjhY?= =?utf-8?B?Q0NGTXBwUHlsbGY3dmN6NGVWSkoyRTRhRkNaZW1JY0t0S3dBelhDQ0JnZTRT?= =?utf-8?B?S1dVVzdOdTFoUVYzcEd5S2NUWlk2aVJ5TEl5RytTVEtXdzM5TnhhalVlODBy?= =?utf-8?B?aXB0UTJkRDU4THRrc3lxdFFoYWNNMm5oeUVjWHRheGR5YXI4NkFJMXdPSFgx?= =?utf-8?B?VDh2RVoyL3VWSko0M1l0VEJNcVNCRXBHOUN3R0lVSnk3KzZ6MHRzRTB4emIx?= =?utf-8?B?QmFmSUU1Z3RtVWlTYllCQ0xFN2dMVmlJNGtQMnVRV3FEQU1HUEVJZHo5NGJZ?= =?utf-8?B?RUJpVjFDQTR3TXRWeEJnMVRXeWRqN3JCWnRBQzd4eXByTVNacGI1ZjAydE1N?= =?utf-8?B?MER6cnJLWHl2WVRocy91UWlpeThQUFpyZ0tsVFA0TVFjNVhaNUoxZ2l3K2NL?= =?utf-8?B?VnFiSW5JR3kzeDMza3prQW5YU1o5d3BSekxlODcydW5IMVFOL0xxek1wckxh?= =?utf-8?B?SHVzZUlwWmx3dUR5RnpXTWNaNE12NWRaM3gvTWJmTjJxV1E4Z0xoN3loUVJt?= =?utf-8?B?OVA1WVVMUkRZZEt0a25NYkFRWnpTRGt2RFd5eXRNWmNUQWNWL0xhWWxaTTlS?= =?utf-8?B?VjRmTGVrd3hHZVcwTWF1TzVzc25LWm1mWGl3alg1WEYzenlONjFrUjhJNm5G?= =?utf-8?B?WFBGNFVvZXZuNkhoelZMVzRRVmpFeFpodjBROW8zdlVHNUN1a25WaFVQdWNT?= =?utf-8?B?Vy84VEltOVJEMy9MbHZSbG1HRXprOHloU01JMkNLakJtOWJUZjVzekROUmo5?= =?utf-8?B?TjlxWW9mbzVNTnhEVHBBMmNGM0c5OWRDMGR6RWlIZzZ1U3puejlhTG5WL1ZP?= =?utf-8?B?ZkkzYk12SU5JcXRPSE9uamN4YVdhcC83aTNabnpMRldzNW1kR05LSDB4SEJx?= =?utf-8?B?QmJlYlNXSmkwdWxOdkRPQXAwcDNwOGpIanVPR01KQlJQeDlUOGY0YThBMGFC?= =?utf-8?B?bUdxc3pnekVGZjdmSjVVUHpQUWlzckRxZEZKVGdBQ2JNN3BuRDNLM2lXQXlY?= =?utf-8?B?V2NxZzJHNEhXc29zSEJ4M2Y0eUNiR2ZmMnJFR3NpZmxwMi8wc0tnZElTTWRi?= =?utf-8?B?ZXViWVVIT3djRVdoVU5pRnY3UHV4VU8vOTZsVm1jRStuN2Nack5mUmlZYWZG?= =?utf-8?B?WmFZWTdxNUF6TElpQ25hVG93WUdrSjlwbVg3ZFNwM0g3NEFHSG5EajJ6eUtL?= =?utf-8?B?M1kxYnI0VXd0dzk4RzJaVXNPNndqanFQSmJWaE4vYURGakh2enVGRS84NVQ3?= =?utf-8?B?MHNCbmJZYitxYllUNzRLTCtmNkh6b1Y3REZxaDVwSmR5bkZLU3psWVVyQ1dR?= =?utf-8?B?QXA0LytUd3I3b3d2NFlIL1k1bHFTeUl1cmJrV0IralI4V1dRRTExV0doUmln?= =?utf-8?Q?XllXDpnv9G3DAxaXMsNVf8EnW?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b8a1fd5-598f-47a9-39ba-08dc5fbdb62e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 15:39:19.2517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9nXejwLeU7dRhqgNtJC9bnvma41+8HPKZgYrBdWBiXzmSW/v7jUKlvfvFKqdkLit X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6123 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/8/2024 1:10 AM, Ferruh Yigit wrote: > On 10/11/2023 1:03 PM, Qi Zhang wrote: >> Parsing command line for rte_flow_action_prog. >> >> Syntax: >> >> "prog name [arguments \ >> ... end]" >> >> Use parse_string0 to parse name string. >> Use parse_hex to parse hex string. >> Use struct action_prog_data to store parsed result. >> >> Example: >> >> Action with 2 arguments: >> >> "prog name action0 arguments field0 03FF field1 55AA end" >> >> Action without argument: >> >> "prog name action1" >> >> Signed-off-by: Qi Zhang >> >> > > Hi Ori, Cristian, can you please help reviewing this patch? > Is this patch still/active valid? Without this patch 'RTE_FLOW_ACTION_TYPE_PROG', programming via P4 language, is not supported via testpmd, so I believe missing this patch makes testing the feature difficult.