From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C2DFB2E8B for ; Tue, 25 Nov 2014 11:45:58 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 25 Nov 2014 02:56:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="421202611" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by FMSMGA003.fm.intel.com with ESMTP; 25 Nov 2014 02:47:01 -0800 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.244]) by IRSMSX107.ger.corp.intel.com ([169.254.10.117]) with mapi id 14.03.0195.001; Tue, 25 Nov 2014 10:56:18 +0000 From: "Jastrzebski, MichalX K" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v8 0/7] link bonding Thread-Index: AQHQCASkCZKHVTt9LUus8IiC2G7/9JxwQZQAgADiP8A= Date: Tue, 25 Nov 2014 10:56:17 +0000 Message-ID: <60ABE07DBB3A454EB7FAD707B4BB1582138BC9F8@IRSMSX109.ger.corp.intel.com> References: <1416832054-24086-1-git-send-email-declan.doherty@intel.com> <1416846822-26897-1-git-send-email-declan.doherty@intel.com> <6086797.0Uzru5Vpmk@xps13> In-Reply-To: <6086797.0Uzru5Vpmk@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v8 0/7] link bonding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2014 10:45:59 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, November 24, 2014 9:54 PM > To: Doherty, Declan > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 0/7] link bonding >=20 > 2014-11-24 16:33, Declan Doherty: > > v8: > > - Missing typo fix > > - Missing whitespace > > > > v7: > > - Fixes for checkpatch issues and typo fixes > > - Removed patch "test app: adding support for generating variable sized= " as > this > > was already committed in commit > aca4360340f169dcc11b1a9be955b44de8b9f6eb > > > > v6: > > - Re-based to dpdk.org addressing associated issues for MBUF_REFCNT > > - Added details to testpmd user guide for new command to set link statu= s > polling interval. > > > > v5: > > - Fix uninitialized variable in broadcast_tx_burst function which cause= d a > > build error in 32-bit build > > - Address unit test issue which is exposed by new test in mode 4/5 patc= h sets > > > > v4: > > - Re-based to account for changes in master. > > - Fix for rte_eth_bond_slaves_get() introduced in v3 patch set > > - Addressed issue around disabling/enabling link status polling around > adding/ > > removing slaves devices. > > > > v3 : > > - Typo fix for the bond free mbufs patch. > > - Re-based to account for changes in the mbuf patches. > > - Add support for slave devices which don't support link status interru= pts > > - Tidy up the link bonding unit test so that all tests use the new test= macros. > > > > v2 : > > Addresses issues with the logic around the handling of fail transmissio= ns. > > In this version all modes behave in a manner similar to a standard PMD, > > returning the number of successfully transmitted mbufs and with the fai= ling > > mbufs at the end of bufs array for freeing / retransmission by the > > application software > > > > v1: > > > > This patch set adds support for link status interrupt in the link bondi= ng > > pmd. It also contains some patches to tidy up the code structure and to > > of the link bonding code and to fix bugs relating to transmission > > failures in the under lying slave pmd which could lead to leaked mbufs. > > > > > > Declan Doherty (7): > > bond: link status interrupt support > > bond: removing switch statement from rx burst method > > bond: fix naming inconsistency in tx_burst_round_robin > > bond: free mbufs if transmission fails in bonding tx_burst functions > > testpmd: adding parameter to reconfig method to set socket_id when > > adding new port to portlist > > bond: lsc polling support > > bond: unit test test macro refactor >=20 > Applied with some minor fixes. >=20 > Thanks > -- > Thomas Hi Thomas, I noticed some problems with applying link bonding mode 4 patches after you= applied Declan's patches.=20 Link bonding mode 4 0001-bond-add-mode-4-support.patch won't apply because = of this error: Checking patch lib/librte_pmd_bond/rte_eth_bond_private.h... error: while searching for: #define RTE_BOND_LOG(lvl, msg, ...) \ RTE_LOG(lvl, PMD, "%s(%d) - " msg "\n", __func__, __LINE__, ##__VA_= ARGS__); extern const char *pmd_bond_init_valid_arguments[]; extern const char *driver_name; error: patch failed: lib/librte_pmd_bond/rte_eth_bond_private.h:60 error: lib/librte_pmd_bond/rte_eth_bond_private.h: patch does not apply This happens because originally in Declan's [PATCH v8 6/7] bond: lsc pollin= g support there is a semicolon at the end of RTE_LOG... line , and my patch is looking for this semicolon = also.=20 So do you want me to send a v6 patch fixing this issue? The second issue is that Link bonding mode 4 0002-testpmd-add-mode-4-suppor= t.patch won't apply also, because of this error; error: while searching for: /* Update number of ports */ nb_ports =3D rte_eth_dev_count(); reconfig(port_id, res->socket); rte_eth_promiscuous_enable(port_id); } error: patch failed: app/test-pmd/cmdline.c:3646 error: app/test-pmd/cmdline.c: patch does not apply This is probably because you didn't apply Declan's patch: [PATCH v8 5/7] testpmd: adding parameter to reconfig This is a part of this patch: diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 4c3fc76..be12c13 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -3642,7 +3642,7 @@ static void cmd_create_bonded_device_parsed(void *par= sed_result, =20 /* Update number of ports */ nb_ports =3D rte_eth_dev_count(); - reconfig(port_id); + reconfig(port_id, res->socket); rte_eth_promiscuous_enable(port_id); }