From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 381F01518 for ; Thu, 27 Nov 2014 19:13:32 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 27 Nov 2014 10:06:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,471,1413270000"; d="scan'208";a="629314845" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga001.fm.intel.com with ESMTP; 27 Nov 2014 10:13:29 -0800 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.244]) by IRSMSX105.ger.corp.intel.com ([163.33.3.28]) with mapi id 14.03.0195.001; Thu, 27 Nov 2014 18:13:28 +0000 From: "Jastrzebski, MichalX K" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v7 1/1] bond: add mode 4 support v7 Thread-Index: AQHQCmxsT5zANMecoku2QX9cpT0TMZx0xa4AgAAAShA= Date: Thu, 27 Nov 2014 18:13:27 +0000 Message-ID: <60ABE07DBB3A454EB7FAD707B4BB1582138BD7D1@IRSMSX109.ger.corp.intel.com> References: <1417111270-12792-1-git-send-email-michalx.k.jastrzebski@intel.com> <1417111270-12792-2-git-send-email-michalx.k.jastrzebski@intel.com> <1503684.yXJvT1DJi7@xps13> In-Reply-To: <1503684.yXJvT1DJi7@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 1/1] bond: add mode 4 support v7 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 18:13:32 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, November 27, 2014 7:09 PM > To: Jastrzebski, MichalX K > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 1/1] bond: add mode 4 support v7 >=20 > 2014-11-27 18:01, Michal Jastrzebski: > > From: Pawel Wodkowski > > > > This patch set add support for dynamic link aggregation (mode 4) to the > > librte_pmd_bond library. This mode provides auto > negotiation/configuration > > of peers and well as link status changes monitoring using out of band > > LACP (link aggregation control protocol) messages. For further details = of > > LACP specification see the IEEE 802.3ad/802.1AX standards. It is also > > described here > > https://www.kernel.org/doc/Documentation/networking/bonding.txt. > > > > In this implementation we have an array of mode 4 settings for each sla= ve. > > There is also assumption that for every port is one aggregator (it migh= t > > be unused if better is found). > > > > Difference in this implementation vs Linux implementation: > > - this implementation it is not directly based on state machines but cu= rrent > > state is calculated from actor and partner states (and other things t= oo). > > > > Some implementation details: > > - during rx burst every packet Is checked if this is LACP or marker pac= ket. > > If it is LACP frame it is passed to mode 4 logic using slaves rx ring= and > > removed from rx buffer before it is returned > > - in tx burst, packets from mode 4 (if any) are injected into each slav= e. > > - there is a timer running in background to process/produce mode 4 > > frames form rx/to tx functions. > > > > Some requirements for this mode: > > - for LACP mode to work rx and tx burst functions must be invoked > > at least in 100ms intervals (testpmd modified to satisfy this require= ment) > > - provided buffer to rx burst should be at least 2x slave count size. T= his is > > not needed but might increase performance especially during initial > > handshake. > > > > Signed-off-by: Pawel Wodkowski >=20 > I guess it is acked by Declan? >=20 > -- > Thomas Hi Thomas, I sent this patch to Declan before, and he had no objections.