From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 5BCC26702 for ; Tue, 27 Jan 2015 16:58:15 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 27 Jan 2015 07:53:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,475,1418112000"; d="scan'208";a="676803071" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga002.jf.intel.com with ESMTP; 27 Jan 2015 07:58:13 -0800 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.11]) by IRSMSX151.ger.corp.intel.com ([169.254.4.141]) with mapi id 14.03.0195.001; Tue, 27 Jan 2015 15:58:11 +0000 From: "Jastrzebski, MichalX K" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] testpmd: check return value of rte_eth_dev_vlan_filter() Thread-Index: AQHQOhzCRy/upVQ+yEW7C7U5jSufyJzUGxWw Date: Tue, 27 Jan 2015 15:58:11 +0000 Message-ID: <60ABE07DBB3A454EB7FAD707B4BB1582138D57F7@IRSMSX109.ger.corp.intel.com> References: <1422009831-11092-1-git-send-email-michalx.k.jastrzebski@intel.com> <3441479.cVrRmaIGdi@xps13> In-Reply-To: <3441479.cVrRmaIGdi@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] testpmd: check return value of rte_eth_dev_vlan_filter() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 15:58:16 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, January 27, 2015 11:33 AM > To: Jastrzebski, MichalX K > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] testpmd: check return value of > rte_eth_dev_vlan_filter() >=20 > Hi Michal, >=20 > 2015-01-23 11:43, Michal Jastrzebski: > > This patch modifies testpmd behavior when setting: > > rx_vlan add all vf_port (enabling all vlanids > > to be passed thru rx filter on VF). > > Rx_vlan_all_filter_set() function, > > checks if the next vlanid can be enabled by the driver. > > Number of vlanids is limited by the NIC and thus the NIC > > do not allow to enable more vlanids than it can allocate > > in VFTA table. > > > > Signed-off by: Michal Jastrzebski >=20 > checkpatch is not happy because you forgot an hyphen. >=20 > > @@ -1667,8 +1668,9 @@ rx_vlan_all_filter_set(portid_t port_id, int on) > > > > if (port_id_is_invalid(port_id)) > > return; > > - for (vlan_id =3D 0; vlan_id < 4096; vlan_id++) > > - rx_vft_set(port_id, vlan_id, on); > > + for (vlan_id =3D 0; vlan_id < 4096; vlan_id++) { > > + if ( rx_vft_set(port_id, vlan_id, on) ) break; >=20 > Again, checkpatch does not like this line. >=20 Hi Thomas, Thanks for pointed it out. I have already fixed all checkpatch.pl errors. I will send v2 patch for this, > And more importantly, you make it clear that sometimes we cannot enable > all > vlans and return no error. Should I return this error somewhere? Isn't just printing the error best op= tion here? > So I wonder how is it documented in the testpmd help? I can add a note in testpmd_funcs.rst file or I can place some info in .hel= p_str? What do you mean "testpmd help"? >=20 > Thanks > -- > Thomas