From: "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB)
Date: Thu, 19 Feb 2015 09:18:26 +0000 [thread overview]
Message-ID: <60ABE07DBB3A454EB7FAD707B4BB1582138EA984@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1774392.VK6szrItcK@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, February 18, 2015 8:10 PM
> To: Doherty, Declan; Jastrzebski, MichalX K
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB)
>
> Hi,
>
> 2015-02-13 16:12, Declan Doherty:
> > On 13/02/15 15:16, Michal Jastrzebski wrote:
> > > Michal Jastrzebski (6):
> > > net: changed arp_hdr struct declaration
> > > bond: add link bonding mode 6 implementation
> > > bond: add debug info for mode 6 link bonding
> > > bond: add example application for link bonding mode 6
> > > bond: modify TLB unit tests
> > > bond: add unit tests for link bonding mode 6.
>
Hi Thomas,
> You didn't sign some of these patches. So I suspect that you should
> fix some authorship.
That's because I am not an author of all of these patches - 1/6, 5/6 and 6/6
>
> Some of the patches make some changes without explaining why.
I noticed 5/6 has got incomplete description. Probably it disappeared during edition.
>
> > Series Acked-by: Declan Doherty <declan.doherty@intel.com>
>
> Please, use checkpatch before submitting and/or when reviewing.
I was using checkptach.pl, and have no errors, but I will check again.
Maybe I overlooked something.
>
> A v3 is needed.
Best regards
Michal
next prev parent reply other threads:[~2015-02-19 9:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 15:16 Michal Jastrzebski
2015-02-13 15:16 ` [dpdk-dev] [PATCH v2 1/6] net: changed arp_hdr struct declaration Michal Jastrzebski
2015-02-13 15:16 ` [dpdk-dev] [PATCH v2 2/6] bond: add link bonding mode 6 implementation Michal Jastrzebski
2015-02-13 15:16 ` [dpdk-dev] [PATCH v2 3/6] bond: add debug info for mode 6 link bonding Michal Jastrzebski
2015-02-13 15:16 ` [dpdk-dev] [PATCH v2 4/6] bond: add example application for link bonding mode 6 Michal Jastrzebski
2015-02-13 15:16 ` [dpdk-dev] [PATCH v2 5/6] bond: modify TLB unit tests Michal Jastrzebski
2015-02-13 15:16 ` [dpdk-dev] [PATCH v2 6/6] bond: add unit tests for link bonding mode 6 Michal Jastrzebski
2015-02-13 16:12 ` [dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB) Declan Doherty
2015-02-18 19:10 ` Thomas Monjalon
2015-02-19 9:18 ` Jastrzebski, MichalX K [this message]
2015-02-19 9:39 ` Thomas Monjalon
2015-02-19 10:14 ` Jastrzebski, MichalX K
2015-02-19 10:27 ` Thomas Monjalon
2015-02-19 17:26 ` [dpdk-dev] [PATCH v3 " Michal Jastrzebski
2015-02-19 17:26 ` [dpdk-dev] [PATCH v3 1/6] net: changed arp_hdr struct declaration Michal Jastrzebski
2015-02-20 14:30 ` Thomas Monjalon
2015-02-20 14:54 ` Gajdzica, MaciejX T
2015-02-20 15:22 ` Thomas Monjalon
2015-02-19 17:26 ` [dpdk-dev] [PATCH v3 2/6] bond: add link bonding mode 6 implementation Michal Jastrzebski
2015-02-19 17:26 ` [dpdk-dev] [PATCH v3 3/6] bond: add debug info for mode 6 link bonding Michal Jastrzebski
2015-02-19 17:26 ` [dpdk-dev] [PATCH v3 4/6] bond: add example application for link bonding mode 6 Michal Jastrzebski
2015-02-20 14:42 ` Thomas Monjalon
2015-02-20 16:12 ` Jastrzebski, MichalX K
2015-02-19 17:26 ` [dpdk-dev] [PATCH v3 5/6] bond: modify TLB unit tests Michal Jastrzebski
2015-02-19 17:26 ` [dpdk-dev] [PATCH v3 6/6] bond: add unit tests for link bonding mode 6 Michal Jastrzebski
2015-02-20 16:09 ` [dpdk-dev] [PATCH v4 0/6] Link Bonding mode 6 support (ALB) Michal Jastrzebski
2015-02-20 16:09 ` [dpdk-dev] [PATCH v4 1/6] net: changed arp_hdr struct declaration Michal Jastrzebski
2015-02-20 16:09 ` [dpdk-dev] [PATCH v4 2/6] bond: add link bonding mode 6 implementation Michal Jastrzebski
2015-02-20 16:09 ` [dpdk-dev] [PATCH v4 3/6] bond: add debug info for mode 6 link bonding Michal Jastrzebski
2015-02-20 16:09 ` [dpdk-dev] [PATCH v4 4/6] bond: add example application for link bonding mode 6 Michal Jastrzebski
2015-02-20 16:09 ` [dpdk-dev] [PATCH v4 5/6] bond: modify TLB unit tests Michal Jastrzebski
2015-02-20 16:09 ` [dpdk-dev] [PATCH v4 6/6] bond: add unit tests for link bonding mode 6 Michal Jastrzebski
2015-02-20 17:44 ` [dpdk-dev] [PATCH v4 0/6] Link Bonding mode 6 support (ALB) Declan Doherty
2015-02-20 21:58 ` Thomas Monjalon
2015-03-04 3:53 ` Jiajia, SunX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ABE07DBB3A454EB7FAD707B4BB1582138EA984@IRSMSX109.ger.corp.intel.com \
--to=michalx.k.jastrzebski@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).