Re: [dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB)

["Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, February 19, 2015 10:40 AM
> To: Jastrzebski, MichalX K
> Cc: Doherty, Declan; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB)
> 
> 2015-02-19 09:18, Jastrzebski, MichalX K:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > 2015-02-13 16:12, Declan Doherty:
> > > > On 13/02/15 15:16, Michal Jastrzebski wrote:
> > > > > Michal Jastrzebski (6):
> > > > >    net: changed arp_hdr struct declaration
> > > > >    bond: add link bonding mode 6 implementation
> > > > >    bond: add debug info for mode 6 link bonding
> > > > >    bond: add example application for link bonding mode 6
> > > > >    bond: modify TLB unit tests
> > > > >    bond: add unit tests for link bonding mode 6.
> > >
> > Hi Thomas,
> > > You didn't sign some of these patches. So I suspect that you should
> > > fix some authorship.
> > That's because I am not an author of all of these patches - 1/6, 5/6 and 6/6
> 
> You probably broke it by importing patches with "patch" command instead of
> "git am".
> Then you must fix the authorship in your git tree before sending.
The authorship in v2 is proper as I think I shouldn't signoff patch that is not mine
-  that I was never working on the code it provides, should I? 
I edited the patches manually before I submitted it to match the proper authority,
In git tree I have all patches signed-off by myself by default.
> 
> > > Some of the patches make some changes without explaining why.
> > I noticed 5/6 has got incomplete description. Probably it disappeared
> during edition.
> 
> Yes please ask yourself why each patch is done, and check it's explained in
> commit log.
> 
> > > > Series Acked-by: Declan Doherty <declan.doherty@intel.com>
> > >
> > > Please, use checkpatch before submitting and/or when reviewing.
> > I was using checkptach.pl, and have no errors, but I will check again.
> > Maybe I overlooked something.
> > >
> > > A v3 is needed.
> >
> > Best regards
> > Michal