From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A9AFCB509 for ; Thu, 19 Feb 2015 11:16:07 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 19 Feb 2015 02:16:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,512,1418112000"; d="scan'208";a="680264088" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga002.fm.intel.com with ESMTP; 19 Feb 2015 02:16:04 -0800 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.103]) by irsmsx110.ger.corp.intel.com ([169.254.15.236]) with mapi id 14.03.0195.001; Thu, 19 Feb 2015 10:14:40 +0000 From: "Jastrzebski, MichalX K" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB) Thread-Index: AQHQR6eMoBNCoU8Kw0eeYtchWXan9pz2zcyAgADqYhCAAAiEgIAAB0xQ Date: Thu, 19 Feb 2015 10:14:40 +0000 Message-ID: <60ABE07DBB3A454EB7FAD707B4BB1582138EAA30@IRSMSX109.ger.corp.intel.com> References: <1423840570-6452-1-git-send-email-michalx.k.jastrzebski@intel.com> <1774392.VK6szrItcK@xps13> <60ABE07DBB3A454EB7FAD707B4BB1582138EA984@IRSMSX109.ger.corp.intel.com> <1533160.F3kMOSWkDY@xps13> In-Reply-To: <1533160.F3kMOSWkDY@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 10:16:08 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, February 19, 2015 10:40 AM > To: Jastrzebski, MichalX K > Cc: Doherty, Declan; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 0/6] Link Bonding mode 6 support (ALB) >=20 > 2015-02-19 09:18, Jastrzebski, MichalX K: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2015-02-13 16:12, Declan Doherty: > > > > On 13/02/15 15:16, Michal Jastrzebski wrote: > > > > > Michal Jastrzebski (6): > > > > > net: changed arp_hdr struct declaration > > > > > bond: add link bonding mode 6 implementation > > > > > bond: add debug info for mode 6 link bonding > > > > > bond: add example application for link bonding mode 6 > > > > > bond: modify TLB unit tests > > > > > bond: add unit tests for link bonding mode 6. > > > > > Hi Thomas, > > > You didn't sign some of these patches. So I suspect that you should > > > fix some authorship. > > That's because I am not an author of all of these patches - 1/6, 5/6 an= d 6/6 >=20 > You probably broke it by importing patches with "patch" command instead o= f > "git am". > Then you must fix the authorship in your git tree before sending. The authorship in v2 is proper as I think I shouldn't signoff patch that is= not mine - that I was never working on the code it provides, should I?=20 I edited the patches manually before I submitted it to match the proper aut= hority, In git tree I have all patches signed-off by myself by default. >=20 > > > Some of the patches make some changes without explaining why. > > I noticed 5/6 has got incomplete description. Probably it disappeared > during edition. >=20 > Yes please ask yourself why each patch is done, and check it's explained = in > commit log. >=20 > > > > Series Acked-by: Declan Doherty > > > > > > Please, use checkpatch before submitting and/or when reviewing. > > I was using checkptach.pl, and have no errors, but I will check again. > > Maybe I overlooked something. > > > > > > A v3 is needed. > > > > Best regards > > Michal