From: "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create
Date: Thu, 15 Oct 2015 10:35:28 +0000 [thread overview]
Message-ID: <60ABE07DBB3A454EB7FAD707B4BB1582139C5FFB@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <561F60E4.609@igel.co.jp>
> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]
> Sent: Thursday, October 15, 2015 10:17 AM
> To: Jastrzebski, MichalX K
> Cc: Glynn, Michael J; Kulasek, TomaszX; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create
>
> On 2015/10/14 21:42, Jastrzebski, MichalX K wrote:
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tetsuya Mukawa
> >> Sent: Wednesday, October 14, 2015 3:35 AM
> >> To: Kulasek, TomaszX; dev@dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create
> >>
> >> On 2015/09/30 23:05, Tomasz Kulasek wrote:
> >>> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> >>> ---
> >>> drivers/net/null/Makefile | 2 +-
> >>> drivers/net/null/rte_eth_null.c | 2 +-
> >>> drivers/net/null/rte_eth_null.h | 40
> >> +++++++++++++++++++++++++++++
> >>> drivers/net/null/rte_pmd_null_version.map | 7 +++++
> >>> 4 files changed, 49 insertions(+), 2 deletions(-)
> >>> create mode 100644 drivers/net/null/rte_eth_null.h
> >> Acked-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> > Hi Tetsuya,
> > Thank You for a review and acking patches.
> > There are 5 remaining patches in a patch-set:
> >
> > [dpdk-dev] [PATCH v5 1/9] bonding: rss dynamic configuration
> > [dpdk-dev] [PATCH v5 6/9] test: dynamic rss configuration
> > [dpdk-dev] [PATCH v5 7/9] bonding: per queue stats
> > [dpdk-dev] [PATCH v5 8/9] doc: fixed spellings and typos
> > [dpdk-dev] [PATCH v5 9/9] doc: dynamic rss configuration for bonding
> >
> > Could You also review them and ack if You agree with that implementation,
> please?
>
> Hi MichalX,
>
> I've checked above patches. But I am sorry that I am not a correct
> person to ack your patches.
> To review it correctly, at least knowledge about RSS and bonding PMD are
> needed, but honestly I am not familiar with RSS.
> Is it possible to find a correct person who can ack it?
>
> BTW, I've checked the patch from the following point of view. It may
> help other reviewers.
> (I've checked after fixing null PMD issues I've found today, please
> check an email I've sent to Tomasz)
> - No fatal errors are reported by checkpatch.pl.
> - Some style warnings are reported, but I guess we can ignore it.
> - No compile error with gcc-4.6/4.7/4.8/4.9/5, clang and icc.
> - No missing symbol.
> - No compile error for docs.
> - No compile error for examples.
>
> Thanks,
> Tetsuya
Hi Tetsuya,
Thank You very much for verifications and Your comments.
I will ask maintainers in term of reviewing remaining patches.
Regarding an issue with rte_eth_null.h I think that reordering of patches
4 and 5 may be sufficient.
Best regards
Michal
next prev parent reply other threads:[~2015-10-15 10:36 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 10:58 [dpdk-dev] [PATCH 0/8] Dynamic RSS Configuration for Bonding Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 1/8] bond: dynamic rss configuration Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 2/8] ring: " Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 3/8] test: " Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 4/8] bond: queue stats mapping Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 5/8] ring: queue stats mapping set dummy implementation Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 6/8] examples: dynamic rss configuration for bonding Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 7/8] doc: fixed spellings and typos Tomasz Kulasek
2015-06-03 10:59 ` [dpdk-dev] [PATCH 8/8] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-06-12 5:36 ` [dpdk-dev] [PATCH 0/8] Dynamic RSS Configuration for Bonding Xu, HuilongX
2015-06-25 9:20 ` Kulasek, TomaszX
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 " Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 1/8] bond: rss dynamic configuration Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 2/8] ring: dynamic rss configuration Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 3/8] test: " Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 4/8] bond: queue stats mapping Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 5/8] ring: queue stats mapping set dummy implementation Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 6/8] examples: dynamic rss configuration for bonding Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 7/8] doc: fixed spellings and typos Tomasz Kulasek
2015-06-19 14:13 ` [dpdk-dev] [PATCH v2 8/8] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-06-26 7:33 ` [dpdk-dev] [PATCH v2 0/8] Dynamic RSS Configuration for Bonding Doherty, Declan
2015-06-28 21:54 ` Thomas Monjalon
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 " Tomasz Kulasek
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 1/8] bonding: rss dynamic configuration Tomasz Kulasek
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 2/8] ring: dynamic rss configuration Tomasz Kulasek
2015-07-13 12:36 ` Thomas Monjalon
2015-07-13 14:43 ` Kulasek, TomaszX
2015-07-13 15:11 ` Thomas Monjalon
2015-07-16 13:02 ` Kulasek, TomaszX
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 3/8] test: " Tomasz Kulasek
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 4/8] bonding: queue stats mapping Tomasz Kulasek
2015-07-13 11:18 ` Thomas Monjalon
2015-07-13 12:00 ` Kulasek, TomaszX
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 5/8] ring: queue stats mapping set dummy implementation Tomasz Kulasek
2015-07-09 1:58 ` Thomas Monjalon
2015-07-09 9:55 ` Kulasek, TomaszX
2015-07-09 10:13 ` Thomas Monjalon
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 6/8] examples: dynamic rss configuration for bonding Tomasz Kulasek
2015-07-13 11:20 ` Thomas Monjalon
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 7/8] doc: fixed spellings and typos Tomasz Kulasek
2015-06-29 14:50 ` [dpdk-dev] [PATCH v3 8/8] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-07-01 10:05 ` [dpdk-dev] [PATCH v3 0/8] Dynamic RSS Configuration for Bonding Declan Doherty
2015-07-13 11:03 ` Thomas Monjalon
2015-07-13 11:18 ` Thomas Monjalon
2015-07-13 12:14 ` Kulasek, TomaszX
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 0/9] " Tomasz Kulasek
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 1/9] bonding: rss dynamic configuration Tomasz Kulasek
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd added to bonding Tomasz Kulasek
2015-09-29 2:24 ` Tetsuya Mukawa
2015-09-29 9:39 ` Kulasek, TomaszX
2015-09-29 10:32 ` Tetsuya Mukawa
2015-09-29 11:29 ` Kulasek, TomaszX
2015-09-29 15:10 ` Kulasek, TomaszX
2015-09-30 1:24 ` Tetsuya Mukawa
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 3/9] null: extend number of virtual queues Tomasz Kulasek
2015-09-29 2:24 ` Tetsuya Mukawa
2015-09-29 9:46 ` Kulasek, TomaszX
2015-09-29 10:34 ` Tetsuya Mukawa
2015-09-29 11:56 ` Kulasek, TomaszX
2015-09-29 15:06 ` Kulasek, TomaszX
2015-09-30 1:24 ` Tetsuya Mukawa
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 4/9] null: virtual dynamic rss configuration Tomasz Kulasek
2015-09-29 2:24 ` Tetsuya Mukawa
2015-09-29 10:04 ` Kulasek, TomaszX
2015-10-12 9:05 ` Jastrzebski, MichalX K
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 5/9] null: export eth_dev_null_create Tomasz Kulasek
2015-09-25 10:11 ` Thomas Monjalon
2015-09-25 13:24 ` Kulasek, TomaszX
2015-09-25 13:43 ` Thomas Monjalon
2015-09-29 2:28 ` Tetsuya Mukawa
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 6/9] test: dynamic rss configuration Tomasz Kulasek
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 7/9] bonding: queue stats mapping Tomasz Kulasek
2015-09-25 10:14 ` Thomas Monjalon
2015-09-25 13:26 ` Kulasek, TomaszX
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 8/9] doc: fixed spellings and typos Tomasz Kulasek
2015-07-15 17:26 ` [dpdk-dev] [PATCHv4 9/9] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-09-25 10:16 ` [dpdk-dev] [PATCHv4 0/9] Dynamic RSS Configuration for Bonding Thomas Monjalon
2015-09-25 13:28 ` Kulasek, TomaszX
2015-09-25 13:44 ` Thomas Monjalon
2015-09-30 14:04 ` [dpdk-dev] [PATCH v5 " Tomasz Kulasek
2015-09-30 14:04 ` [dpdk-dev] [PATCH v5 1/9] bonding: rss dynamic configuration Tomasz Kulasek
2015-09-30 14:04 ` [dpdk-dev] [PATCH v5 2/9] null: fix segfault when null_pmd added to bonding Tomasz Kulasek
2015-09-30 14:04 ` [dpdk-dev] [PATCH v5 3/9] null: extend number of virtual queues Tomasz Kulasek
2015-10-14 1:34 ` Tetsuya Mukawa
2015-09-30 14:05 ` [dpdk-dev] [PATCH v5 4/9] null: virtual dynamic rss configuration Tomasz Kulasek
2015-10-14 1:34 ` Tetsuya Mukawa
2015-10-15 7:46 ` Tetsuya Mukawa
2015-10-15 8:42 ` Kulasek, TomaszX
2015-10-15 9:21 ` Tetsuya Mukawa
2015-09-30 14:05 ` [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create Tomasz Kulasek
2015-10-14 1:35 ` Tetsuya Mukawa
2015-10-14 12:42 ` Jastrzebski, MichalX K
2015-10-15 8:16 ` Tetsuya Mukawa
2015-10-15 10:35 ` Jastrzebski, MichalX K [this message]
2015-09-30 14:05 ` [dpdk-dev] [PATCH v5 6/9] test: dynamic rss configuration Tomasz Kulasek
2015-09-30 14:05 ` [dpdk-dev] [PATCH v5 7/9] bonding: per queue stats Tomasz Kulasek
2015-09-30 14:05 ` [dpdk-dev] [PATCH v5 8/9] doc: fixed spellings and typos Tomasz Kulasek
2015-09-30 14:05 ` [dpdk-dev] [PATCH v5 9/9] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 0/9] Dynamic RSS Configuration for Bonding Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 1/9] bonding: rss dynamic configuration Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd added to bonding Tomasz Kulasek
2015-10-27 16:58 ` Thomas Monjalon
2015-10-28 13:43 ` Kulasek, TomaszX
2015-10-29 7:19 ` Tetsuya Mukawa
2015-10-30 13:50 ` Kulasek, TomaszX
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 3/9] null: extend number of virtual queues Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 4/9] null: export eth_dev_null_create Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 5/9] null: virtual dynamic rss configuration Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 6/9] test: " Tomasz Kulasek
2015-10-27 17:34 ` Thomas Monjalon
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 7/9] bonding: per queue stats Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 8/9] doc: fixed spellings and typos Tomasz Kulasek
2015-10-16 10:00 ` [dpdk-dev] [PATCH v6 9/9] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-10-19 13:22 ` [dpdk-dev] [PATCH v6 0/9] Dynamic RSS Configuration for Bonding Declan Doherty
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 " Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 1/9] bonding: rss dynamic configuration Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 2/9] null: fix segfault when null_pmd added to bonding Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 3/9] null: extend number of virtual queues Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 4/9] null: export eth_dev_null_create Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 5/9] null: virtual dynamic rss configuration Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 6/9] test: " Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 7/9] bonding: per queue stats Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 8/9] doc: fixed spellings and typos Tomasz Kulasek
2015-10-30 14:25 ` [dpdk-dev] [PATCH v7 9/9] doc: dynamic rss configuration for bonding Tomasz Kulasek
2015-11-01 17:29 ` [dpdk-dev] [PATCH v7 0/9] Dynamic RSS Configuration for Bonding Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ABE07DBB3A454EB7FAD707B4BB1582139C5FFB@IRSMSX109.ger.corp.intel.com \
--to=michalx.k.jastrzebski@intel.com \
--cc=dev@dpdk.org \
--cc=mukawa@igel.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).