From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 50F0B8E93 for ; Thu, 15 Oct 2015 12:36:00 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 15 Oct 2015 03:35:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,684,1437462000"; d="scan'208";a="664848005" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga003.jf.intel.com with ESMTP; 15 Oct 2015 03:35:30 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 15 Oct 2015 11:35:29 +0100 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.139]) by irsmsx112.ger.corp.intel.com ([169.254.1.218]) with mapi id 14.03.0248.002; Thu, 15 Oct 2015 11:35:29 +0100 From: "Jastrzebski, MichalX K" To: Tetsuya Mukawa Thread-Topic: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create Thread-Index: AQHQ+4phHyvuUZ/gG0+8alwdsSPUFp5qOUKAgACnjYCAAVr2AIAAI4LA Date: Thu, 15 Oct 2015 10:35:28 +0000 Message-ID: <60ABE07DBB3A454EB7FAD707B4BB1582139C5FFB@IRSMSX109.ger.corp.intel.com> References: <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com> <1443621905-7872-1-git-send-email-tomaszx.kulasek@intel.com> <1443621905-7872-6-git-send-email-tomaszx.kulasek@intel.com> <561DB149.80604@igel.co.jp> <60ABE07DBB3A454EB7FAD707B4BB1582139C57E4@IRSMSX109.ger.corp.intel.com> <561F60E4.609@igel.co.jp> In-Reply-To: <561F60E4.609@igel.co.jp> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2015 10:36:01 -0000 > -----Original Message----- > From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] > Sent: Thursday, October 15, 2015 10:17 AM > To: Jastrzebski, MichalX K > Cc: Glynn, Michael J; Kulasek, TomaszX; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create >=20 > On 2015/10/14 21:42, Jastrzebski, MichalX K wrote: > >> -----Original Message----- > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tetsuya Mukawa > >> Sent: Wednesday, October 14, 2015 3:35 AM > >> To: Kulasek, TomaszX; dev@dpdk.org > >> Subject: Re: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_creat= e > >> > >> On 2015/09/30 23:05, Tomasz Kulasek wrote: > >>> Signed-off-by: Tomasz Kulasek > >>> --- > >>> drivers/net/null/Makefile | 2 +- > >>> drivers/net/null/rte_eth_null.c | 2 +- > >>> drivers/net/null/rte_eth_null.h | 40 > >> +++++++++++++++++++++++++++++ > >>> drivers/net/null/rte_pmd_null_version.map | 7 +++++ > >>> 4 files changed, 49 insertions(+), 2 deletions(-) > >>> create mode 100644 drivers/net/null/rte_eth_null.h > >> Acked-by: Tetsuya Mukawa > > Hi Tetsuya, > > Thank You for a review and acking patches. > > There are 5 remaining patches in a patch-set: > > > > [dpdk-dev] [PATCH v5 1/9] bonding: rss dynamic configuration > > [dpdk-dev] [PATCH v5 6/9] test: dynamic rss configuration > > [dpdk-dev] [PATCH v5 7/9] bonding: per queue stats > > [dpdk-dev] [PATCH v5 8/9] doc: fixed spellings and typos > > [dpdk-dev] [PATCH v5 9/9] doc: dynamic rss configuration for bonding > > > > Could You also review them and ack if You agree with that implementatio= n, > please? >=20 > Hi MichalX, >=20 > I've checked above patches. But I am sorry that I am not a correct > person to ack your patches. > To review it correctly, at least knowledge about RSS and bonding PMD are > needed, but honestly I am not familiar with RSS. > Is it possible to find a correct person who can ack it? >=20 > BTW, I've checked the patch from the following point of view. It may > help other reviewers. > (I've checked after fixing null PMD issues I've found today, please > check an email I've sent to Tomasz) > - No fatal errors are reported by checkpatch.pl. > - Some style warnings are reported, but I guess we can ignore it. > - No compile error with gcc-4.6/4.7/4.8/4.9/5, clang and icc. > - No missing symbol. > - No compile error for docs. > - No compile error for examples. >=20 > Thanks, > Tetsuya Hi Tetsuya, Thank You very much for verifications and Your comments.=20 I will ask maintainers in term of reviewing remaining patches. Regarding an issue with rte_eth_null.h I think that reordering of patches 4 and 5 may be sufficient.=20 Best regards Michal