From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 143DB3772 for ; Fri, 23 Oct 2015 16:59:35 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 23 Oct 2015 07:59:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,186,1444719600"; d="scan'208";a="670345338" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga003.jf.intel.com with ESMTP; 23 Oct 2015 07:59:34 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 23 Oct 2015 15:59:33 +0100 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.139]) by irsmsx112.ger.corp.intel.com ([169.254.1.218]) with mapi id 14.03.0248.002; Fri, 23 Oct 2015 15:59:33 +0100 From: "Jastrzebski, MichalX K" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v1 1/3] lpm: increase number of next hops for lpm (ipv4) Thread-Index: AQHRDaCbaDhpRLfaRUGcxBxcg7VZTJ55KdoA Date: Fri, 23 Oct 2015 14:59:32 +0000 Message-ID: <60ABE07DBB3A454EB7FAD707B4BB1582139CA712@IRSMSX109.ger.corp.intel.com> References: <1445608311-8092-1-git-send-email-michalx.k.jastrzebski@intel.com> <1445608311-8092-2-git-send-email-michalx.k.jastrzebski@intel.com> <20151023143854.GB26964@bricha3-MOBL3> In-Reply-To: <20151023143854.GB26964@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v1 1/3] lpm: increase number of next hops for lpm (ipv4) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 14:59:36 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, October 23, 2015 4:39 PM > To: Jastrzebski, MichalX K > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 1/3] lpm: increase number of next hops > for lpm (ipv4) >=20 > On Fri, Oct 23, 2015 at 03:51:49PM +0200, Michal Jastrzebski wrote: > > From: Michal Kobylinski > > > > Main implementation - changes to lpm library regarding new data types. > > Additionally this patch implements changes required by test application= . > > ABI versioning requirements are met only for lpm library, > > for table library it will be sent in v2 of this patch-set. > > > > Signed-off-by: Michal Kobylinski > > --- > > app/test/test_func_reentrancy.c | 4 +- > > app/test/test_lpm.c | 227 +++++----- > > lib/librte_lpm/rte_lpm.c | 887 > ++++++++++++++++++++++++++++++++++++- > > lib/librte_lpm/rte_lpm.h | 295 +++++++++++- > > lib/librte_lpm/rte_lpm_version.map | 59 ++- > > lib/librte_table/rte_table_lpm.c | 10 +- > > 6 files changed, 1322 insertions(+), 160 deletions(-) > > > > diff --git a/app/test/test_func_reentrancy.c > b/app/test/test_func_reentrancy.c > > index dbecc52..331ab29 100644 > > --- a/app/test/test_func_reentrancy.c > > +++ b/app/test/test_func_reentrancy.c > > @@ -343,7 +343,7 @@ static void > > lpm_clean(unsigned lcore_id) > > { > > char lpm_name[MAX_STRING_SIZE]; > > - struct rte_lpm *lpm; > > + struct rte_lpm_extend *lpm; >=20 > I thought this patchset was just to increase the size of the lpm entries,= not > to create a whole new entry type? The structure names etc. should all sta= y > the > same, and let the ABI versionning take care of handling code using the ol= der > structures. >=20 > /Bruce Hi Bruce,=20 I see Your point. I think we should use here RTE_NEXT_ABI macro. The code will have to be duplicated but it will allow to use old names in a= new version. Michal