From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9ED7495DB for ; Wed, 8 Jun 2016 16:27:22 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 08 Jun 2016 07:27:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,439,1459839600"; d="scan'208";a="983421477" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga001.fm.intel.com with ESMTP; 08 Jun 2016 07:27:20 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 8 Jun 2016 15:27:19 +0100 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.193]) by IRSMSX156.ger.corp.intel.com ([10.108.20.68]) with mapi id 14.03.0248.002; Wed, 8 Jun 2016 15:27:19 +0100 From: "Jastrzebski, MichalX K" To: Thomas Monjalon CC: "Iremonger, Bernard" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] app/test: fix bond device name too long Thread-Index: AQHRuCttyFervgcAmUSd4i+Vi+l2mp/M62QAgBJ3zoCAACJIQIAADW+AgAAVySA= Date: Wed, 8 Jun 2016 14:27:18 +0000 Message-ID: <60ABE07DBB3A454EB7FAD707B4BB158213AA787F@IRSMSX109.ger.corp.intel.com> References: <1464362453-5732-1-git-send-email-michalx.k.jastrzebski@intel.com> <1811926.blbdy7xKmg@xps13> <60ABE07DBB3A454EB7FAD707B4BB158213AA771C@IRSMSX109.ger.corp.intel.com> <3883347.3dLukHgfgL@xps13> In-Reply-To: <3883347.3dLukHgfgL@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test: fix bond device name too long X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2016 14:27:23 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, June 08, 2016 3:31 PM > To: Jastrzebski, MichalX K > Cc: Iremonger, Bernard ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] app/test: fix bond device name too long >=20 > 2016-06-08 11:50, Jastrzebski, MichalX K: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2016-05-27 18:38, Thomas Monjalon: > > > > 2016-05-27 17:20, Michal Jastrzebski: > > > > > Bond device name was too long (grather than 32 signs) that > > > > > cause mempool allocation to fail. > > > > > > > > Maybe that this kind of failure would be avoided if the test > > > > was added to autotests (app/test/autotest_data.py). > > > > > > > > Generally speaking, it would be a good idea to make an audit > > > > on which tests are missing in "make fast_test" and "make test". > > > > > > Any comment please? > > > > Hi Thomas, > > > > There is a small timeout in test_tlb_tx_burst - big burst has to be > generated to > > detect balancing and small timeout has to be included between each > burst, > > thus I am not sure if link_bonding_autotest can be classified to fast t= ests > > (test takes about 3-4 seconds). > > We can add this test to autotests script for which time is not so criti= cal. >=20 > The bug we see here could be detected by just initializing bonding. > Maybe we can consider having some basic/fast tests and others longer. Actually this particular bug does not happen during bonding initialization,= but only after user will configure bond device in mode 6 (ALB). As only in mode= 6 we need=20 mempool allocation and we do rte_pktmbuf_pool_create giving as a mempool na= me - bond device name BONDED_DEV_NAME. Best regards Michal