From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0AEBAFFA for ; Thu, 13 Oct 2016 10:47:56 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 13 Oct 2016 01:47:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,339,1473145200"; d="scan'208";a="889563340" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 13 Oct 2016 01:47:55 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 13 Oct 2016 09:47:54 +0100 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.6]) by IRSMSX156.ger.corp.intel.com ([169.254.3.80]) with mapi id 14.03.0248.002; Thu, 13 Oct 2016 09:47:54 +0100 From: "Jastrzebski, MichalX K" To: "Azarewicz, PiotrX T" , "Trahe, Fiona" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] app/test: fix crypto mbuf pool size Thread-Index: AQHSI6fMionusonoukKM6eeUoXCvhKCmFSWA Date: Thu, 13 Oct 2016 08:47:53 +0000 Message-ID: <60ABE07DBB3A454EB7FAD707B4BB158213B046E6@IRSMSX109.ger.corp.intel.com> References: <1475840080-180796-1-git-send-email-piotrx.t.azarewicz@intel.com> <1476180413-241502-1-git-send-email-piotrx.t.azarewicz@intel.com> In-Reply-To: <1476180413-241502-1-git-send-email-piotrx.t.azarewicz@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/test: fix crypto mbuf pool size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 08:47:57 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Piotr Azarewicz > Sent: Tuesday, October 11, 2016 12:07 PM > To: Trahe, Fiona > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] app/test: fix crypto mbuf pool size >=20 > This patch fix that created pool for crypto mbufs may be too big in some > environments. > To avoid the issue, mbuf pool is reverted to its previous size. > Moreover, here is added additional small pool with one large mbuf, what > is needed in large data test scenarios. >=20 > Fixes: ffbe3be0d4b5 ("app/test: add libcrypto") >=20 > Signed-off-by: Piotr Azarewicz > --- >=20 > v2 change: > - changed check if aad.len > MBUF_SIZE > - added assertion check for rte_pktmbuf_alloc >=20 > app/test/test_cryptodev.c | 32 +++++++++++++++++++++++++++++--- > 1 file changed, 29 insertions(+), 3 deletions(-) >=20 > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > index 2917454..7d03899 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -60,6 +60,7 @@ static enum rte_cryptodev_type gbl_cryptodev_type; >=20 > struct crypto_testsuite_params { > struct rte_mempool *mbuf_pool; > + struct rte_mempool *large_mbuf_pool; > struct rte_mempool *op_mpool; > struct rte_cryptodev_config conf; > struct rte_cryptodev_qp_conf qp_conf; > @@ -169,7 +170,7 @@ testsuite_setup(void) > /* Not already created so create */ > ts_params->mbuf_pool =3D rte_pktmbuf_pool_create( > "CRYPTO_MBUFPOOL", > - NUM_MBUFS, MBUF_CACHE_SIZE, 0, > UINT16_MAX, > + NUM_MBUFS, MBUF_CACHE_SIZE, 0, > MBUF_SIZE, > rte_socket_id()); > if (ts_params->mbuf_pool =3D=3D NULL) { > RTE_LOG(ERR, USER1, "Can't create > CRYPTO_MBUFPOOL\n"); > @@ -177,6 +178,21 @@ testsuite_setup(void) > } > } >=20 > + ts_params->large_mbuf_pool =3D rte_mempool_lookup( > + "CRYPTO_LARGE_MBUFPOOL"); > + if (ts_params->large_mbuf_pool =3D=3D NULL) { > + /* Not already created so create */ > + ts_params->large_mbuf_pool =3D rte_pktmbuf_pool_create( > + "CRYPTO_LARGE_MBUFPOOL", > + 1, 0, 0, UINT16_MAX, > + rte_socket_id()); > + if (ts_params->large_mbuf_pool =3D=3D NULL) { > + RTE_LOG(ERR, USER1, > + "Can't create > CRYPTO_LARGE_MBUFPOOL\n"); > + return TEST_FAILED; > + } > + } > + > ts_params->op_mpool =3D rte_crypto_op_pool_create( > "MBUF_CRYPTO_SYM_OP_POOL", > RTE_CRYPTO_OP_TYPE_SYMMETRIC, > @@ -5149,7 +5165,12 @@ test_AES_GMAC_authentication(const struct > gmac_test_data *tdata) > if (retval < 0) > return retval; >=20 > - ut_params->ibuf =3D rte_pktmbuf_alloc(ts_params->mbuf_pool); > + if (tdata->aad.len > MBUF_SIZE) > + ut_params->ibuf =3D rte_pktmbuf_alloc(ts_params- > >large_mbuf_pool); > + else > + ut_params->ibuf =3D rte_pktmbuf_alloc(ts_params- > >mbuf_pool); > + TEST_ASSERT_NOT_NULL(ut_params->ibuf, > + "Failed to allocate input buffer in mempool"); >=20 > memset(rte_pktmbuf_mtod(ut_params->ibuf, uint8_t *), 0, > rte_pktmbuf_tailroom(ut_params->ibuf)); > @@ -5233,7 +5254,12 @@ test_AES_GMAC_authentication_verify(const > struct gmac_test_data *tdata) > if (retval < 0) > return retval; >=20 > - ut_params->ibuf =3D rte_pktmbuf_alloc(ts_params->mbuf_pool); > + if (tdata->aad.len > MBUF_SIZE) > + ut_params->ibuf =3D rte_pktmbuf_alloc(ts_params- > >large_mbuf_pool); > + else > + ut_params->ibuf =3D rte_pktmbuf_alloc(ts_params- > >mbuf_pool); > + TEST_ASSERT_NOT_NULL(ut_params->ibuf, > + "Failed to allocate input buffer in mempool"); >=20 > memset(rte_pktmbuf_mtod(ut_params->ibuf, uint8_t *), 0, > rte_pktmbuf_tailroom(ut_params->ibuf)); > -- > 1.7.9.5 Acked-by: Michal Jastrzebski