From: "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>
To: "Mrozowicz, SlawomirX" <slawomirx.mrozowicz@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Mrozowicz, SlawomirX" <slawomirx.mrozowicz@intel.com>,
"ian.betts@intel.com" <ian.betts@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/performance-thread: fix out-of-bounds read
Date: Wed, 11 Oct 2017 13:56:06 +0000 [thread overview]
Message-ID: <60ABE07DBB3A454EB7FAD707B4BB158213C457FA@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1505895624-25734-1-git-send-email-slawomirx.mrozowicz@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Slawomir
> Mrozowicz
> Sent: Wednesday, September 20, 2017 10:20 AM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Mrozowicz, SlawomirX
> <slawomirx.mrozowicz@intel.com>; ian.betts@intel.com; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] examples/performance-thread: fix out-of-
> bounds read
>
> Overrunning array per_lcore_this_sched->current_lthread->tls->data of
> 1024 8-byte elements at element index 1024 using index k.
> Fixed by correct check k condition.
>
> Coverity issue: 143462
> Fixes: 116819b9ed0d ("examples/performance-thread: add lthread
> subsystem")
> Cc: ian.betts@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
> ---
> examples/performance-thread/common/lthread_tls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/performance-thread/common/lthread_tls.c
> b/examples/performance-thread/common/lthread_tls.c
> index 47505f2d4..58a9a8878 100644
> --- a/examples/performance-thread/common/lthread_tls.c
> +++ b/examples/performance-thread/common/lthread_tls.c
> @@ -212,7 +212,7 @@ void
> */
> int lthread_setspecific(unsigned int k, const void *data)
> {
> - if (k > LTHREAD_MAX_KEYS)
> + if (k >= LTHREAD_MAX_KEYS)
> return POSIX_ERRNO(EINVAL);
>
> int n = THIS_LTHREAD->tls->nb_keys_inuse;
> --
> 2.11.0
Acked-by: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
next prev parent reply other threads:[~2017-10-11 13:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 8:20 Slawomir Mrozowicz
2017-10-11 13:56 ` Jastrzebski, MichalX K [this message]
2017-10-13 23:23 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2017-09-20 8:21 [dpdk-dev] " Slawomir Mrozowicz
2017-10-11 13:56 ` Jastrzebski, MichalX K
2017-10-13 23:23 ` Thomas Monjalon
2017-09-20 8:05 Slawomir Mrozowicz
2017-10-11 13:55 ` Jastrzebski, MichalX K
2017-10-13 23:19 ` Thomas Monjalon
2017-09-20 7:47 Slawomir Mrozowicz
2017-10-02 14:07 ` Jastrzebski, MichalX K
2017-10-11 13:55 ` Jastrzebski, MichalX K
2017-10-13 23:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ABE07DBB3A454EB7FAD707B4BB158213C457FA@IRSMSX109.ger.corp.intel.com \
--to=michalx.k.jastrzebski@intel.com \
--cc=dev@dpdk.org \
--cc=ian.betts@intel.com \
--cc=john.mcnamara@intel.com \
--cc=slawomirx.mrozowicz@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).