From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9280AA00E6 for ; Thu, 11 Jul 2019 23:30:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 745974C8E; Thu, 11 Jul 2019 23:30:00 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 33BBB23D for ; Thu, 11 Jul 2019 23:29:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2019 14:29:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,480,1557212400"; d="scan'208";a="365403443" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 11 Jul 2019 14:29:58 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jul 2019 14:29:57 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.206]) by fmsmsx121.amr.corp.intel.com ([169.254.6.243]) with mapi id 14.03.0439.000; Thu, 11 Jul 2019 14:29:57 -0700 From: "Wiles, Keith" To: Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/9] net/tap: remove redundant declarations Thread-Index: AQHVOCO/igwuxNgqRU+ExyrYfAp01qbGZKIA Date: Thu, 11 Jul 2019 21:29:56 +0000 Message-ID: <60BCF770-6C7E-44AD-83D6-D9544D8DF8A6@intel.com> References: <20190711200309.6134-1-stephen@networkplumber.org> <20190711200309.6134-2-stephen@networkplumber.org> In-Reply-To: <20190711200309.6134-2-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.251.155.216] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/9] net/tap: remove redundant declarations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Jul 11, 2019, at 3:03 PM, Stephen Hemminger wrote: >=20 > The rte_vdev_drivers are declared twice. > The first one is not necessary. >=20 > Signed-off-by: Stephen Hemminger > --- > drivers/net/tap/rte_eth_tap.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.= c > index 3841842f01f8..64bd049110e1 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -71,8 +71,6 @@ > #define TAP_IOV_DEFAULT_MAX 1024 >=20 > static int tap_devices_count; > -static struct rte_vdev_driver pmd_tap_drv; > -static struct rte_vdev_driver pmd_tun_drv; >=20 > static const char *valid_arguments[] =3D { > ETH_TAP_IFACE_ARG, > --=20 > 2.20.1 >=20 Acked-by: Keith Wiles Regards, Keith