From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Michael Baum <michaelba@nvidia.com>, dev@dpdk.org
Cc: Ori Kam <orika@nvidia.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 1/1] ethdev: add IPv6 FL and TC field identifiers
Date: Thu, 8 Feb 2024 22:37:36 +0000 [thread overview]
Message-ID: <60a42c30-2528-4fc0-887c-98fe0406eeb5@amd.com> (raw)
In-Reply-To: <20240207155128.1581670-2-michaelba@nvidia.com>
On 2/7/2024 3:51 PM, Michael Baum wrote:
> Add new "rte_flow_field_id" enumeration values to describe both IPv6
> traffic class and IPv6 flow label fields.
>
> The TC value is "RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS" in flow API and
> "ipv6_traffic_class" in testpmd command.
> The FL value is "RTE_FLOW_FIELD_IPV6_FLOW_LABEL" in flow API and
> "ipv6_flow_label" in testpmd command.
>
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> ---
> app/test-pmd/cmdline_flow.c | 1 +
> doc/guides/rel_notes/release_24_03.rst | 2 ++
> lib/ethdev/rte_flow.h | 4 +++-
> 3 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 102b4d67c9..ab8bece28e 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -992,6 +992,7 @@ static const char *const flow_field_ids[] = {
> "random",
> "ipv4_proto",
> "esp_spi", "esp_seq_num", "esp_proto",
> + "ipv6_flow_label", "ipv6_traffic_class",
> NULL
> };
>
> diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst
> index 0909a2245d..f548eacc5e 100644
> --- a/doc/guides/rel_notes/release_24_03.rst
> +++ b/doc/guides/rel_notes/release_24_03.rst
> @@ -68,6 +68,8 @@ New Features
> * Added ``RTE_FLOW_FIELD_ESP_SPI`` to represent it in field ID struct.
> * Added ``RTE_FLOW_FIELD_ESP_SEQ_NUM`` to represent it in field ID struct.
> * Added ``RTE_FLOW_FIELD_ESP_PROTO`` to represent it in field ID struct.
> + * Added ``RTE_FLOW_FIELD_IPV6_FLOW_LABEL`` to represent it in field ID struct.
> + * Added ``RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS`` to represent it in field ID struct.
>
On which tree is this patch based on, I don't see above notes.
Can you please rebase on latest next-net?
> * ** Support for getting the number of used descriptors of a Tx queue. **
>
> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index b8fc16b819..8b32a69d8d 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -2425,7 +2425,9 @@ enum rte_flow_field_id {
> RTE_FLOW_FIELD_IPV4_PROTO, /**< IPv4 next protocol. */
> RTE_FLOW_FIELD_ESP_SPI, /**< ESP SPI. */
> RTE_FLOW_FIELD_ESP_SEQ_NUM, /**< ESP Sequence Number. */
> - RTE_FLOW_FIELD_ESP_PROTO /**< ESP next protocol value. */
> + RTE_FLOW_FIELD_ESP_PROTO, /**< ESP next protocol value. */
> + RTE_FLOW_FIELD_IPV6_FLOW_LABEL, /**< IPv6 flow label. */
> + RTE_FLOW_FIELD_IPV6_TRAFFIC_CLASS/**< IPv6 traffic class. */
> };
>
> /**
next prev parent reply other threads:[~2024-02-08 22:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 14:26 [PATCH 0/1] ethdev: add IPv6 " Michael Baum
2024-02-06 14:26 ` [PATCH 1/1] ethdev: add IPv6 FL and TC " Michael Baum
2024-02-07 13:47 ` Dariusz Sosnowski
2024-02-07 15:51 ` [PATCH v2 0/1] ethdev: add IPv6 " Michael Baum
2024-02-07 15:51 ` [PATCH v2 1/1] ethdev: add IPv6 FL and TC " Michael Baum
2024-02-08 22:37 ` Ferruh Yigit [this message]
2024-02-11 8:05 ` Michael Baum
2024-02-12 17:22 ` Ferruh Yigit
2024-02-12 17:23 ` Ferruh Yigit
2024-02-14 4:08 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60a42c30-2528-4fc0-887c-98fe0406eeb5@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).