From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DA084A0C4D;
	Thu, 17 Jun 2021 13:24:56 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9B49D4067A;
	Thu, 17 Jun 2021 13:24:56 +0200 (CEST)
Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com
 [209.85.221.54]) by mails.dpdk.org (Postfix) with ESMTP id 2498040150
 for <dev@dpdk.org>; Thu, 17 Jun 2021 13:24:55 +0200 (CEST)
Received: by mail-wr1-f54.google.com with SMTP id i94so6349582wri.4
 for <dev@dpdk.org>; Thu, 17 Jun 2021 04:24:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;
 h=subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=Pb7af6UmGBrolFEYOlyOI+00eWef3CW3d5j1DMMbI5Y=;
 b=OH8My1+TFvPfwdve/EDZn1ZU21xUQBtYXTADvAoyCqL9RO3HevKPMntQj6yhuX9sH/
 6J29Dxt8CK2ZKKg8gfyPvC6mC8rr0ZMas4JiaKbmDUA8E3GG5mw9HmOBq4lBx6f47HBw
 M9ghAIlLka106h9HYBxvtEl7dp9bQceKQqkV7IC1p9ce3UvquxrVwHSeP/cF7wbWNx6B
 dL/uOts0wZQOUJsEnPPCqpQrmZvkdf9trQXu//M577EOn5AZ3dH84HOTZTRXp25YUJKU
 iQJy/9GyeyM43a3jh99qJiM+73SljzbYOyDG0so8AagYBkXV6VoZorMh+p3JSM3rLIMj
 FqNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=Pb7af6UmGBrolFEYOlyOI+00eWef3CW3d5j1DMMbI5Y=;
 b=RHPsyfdflY34U3Uzo1piTcel1lGkdLuYzgaT+12WTR50qFY4qKRlsuIOx2kOEPHa1G
 fMrHLtOedTvAYsVFs133wjb13AqbenJBANKaRM3umpwq03zMR2mtk0qzbtfeAuEjXl93
 yoN9TliGTo8iMMQ/r04pSaRIIbYspPvedke6uFTWl0p0EwyV9OczI9+phIfli8VVRKo0
 aR3iHf3LuhmyQoHVdprww8nBf+MQqSAKgalbNtbcFXhUBK0DYj7d78LXRMCipjRG/XVw
 lxUuQGsS6SLo9iHdFgeUoWHU1XBgW23srM96h3hHlo/6Lf5c2B1gCkQ22uulqS/hX/zJ
 gVcA==
X-Gm-Message-State: AOAM533acE2OseId7HX0aX6Nld5d7P4UC6BMiqtPWQTJR0adjbkFUrgA
 g3S2F/qF9SYPRmqMEjskRPoe
X-Google-Smtp-Source: ABdhPJxA49eNcsnoEMTJccGIwbTeSxe1LhphGK/vT5LmOjNt1P5CFUCh3rV26Z3N15It6t8uMcMWLw==
X-Received: by 2002:a5d:414e:: with SMTP id c14mr4956751wrq.81.1623929094861; 
 Thu, 17 Jun 2021 04:24:54 -0700 (PDT)
Received: from [10.16.0.39] (host.78.145.23.62.rev.coltfrance.com.
 [62.23.145.78])
 by smtp.gmail.com with ESMTPSA id i2sm4243555wmo.40.2021.06.17.04.24.54
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 17 Jun 2021 04:24:54 -0700 (PDT)
To: Ruifeng Wang <Ruifeng.Wang@arm.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
 "jerinj@marvell.com" <jerinj@marvell.com>,
 Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
 =?UTF-8?Q?Juraj_Linke=c5=a1?= <juraj.linkes@pantheon.tech>, nd <nd@arm.com>
References: <20210525082402.8051-1-thierry.herbelot@6wind.com>
 <876d348bb6ab493f404c2c1f288262ff3112cada.1623917721.git.thierry.herbelot@6wind.com>
 <AM5PR0802MB2465D72ED4838AB96320055D9E0E9@AM5PR0802MB2465.eurprd08.prod.outlook.com>
From: Thierry Herbelot <thierry.herbelot@6wind.com>
Message-ID: <60bf1e0d-5b39-1f7f-c75b-c2d4b0b45107@6wind.com>
Date: Thu, 17 Jun 2021 13:24:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <AM5PR0802MB2465D72ED4838AB96320055D9E0E9@AM5PR0802MB2465.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH V3] config/arm: add Qualcomm Centriq 2400
 part number
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/17/21 12:03 PM, Ruifeng Wang wrote:
>> -----Original Message-----
>> From: Thierry Herbelot <thierry.herbelot@6wind.com>
>> Sent: Thursday, June 17, 2021 4:16 PM
>> To: dev@dpdk.org
>> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; thomas@monjalon.net;
>> jerinj@marvell.com; Ruifeng Wang <Ruifeng.Wang@arm.com>; Honnappa
>> Nagarahalli <Honnappa.Nagarahalli@arm.com>; Juraj Linkeš
>> <juraj.linkes@pantheon.tech>
>> Subject: [PATCH V3] config/arm: add Qualcomm Centriq 2400 part number
>>
>> 0xc00 is for "SoC 2.0" Qualcomm Centriq servers.
>> 0x800 is for "SoC 1.1".
>>
>> Cc: Jerin Jacob <jerinj@marvell.com>
>> Cc: Ruifeng Wang <ruifeng.wang@arm.com>
>> Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
>>
>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>> --
>> V2: add maintainers as Cc
>> V3: fix meson syntax for the SoC v1.1 machine description
>> ---
>>   config/arm/meson.build | 12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/config/arm/meson.build b/config/arm/meson.build index
>> e83a56e0d589..b33303d09023 100644
>> --- a/config/arm/meson.build
>> +++ b/config/arm/meson.build
>> @@ -179,7 +179,8 @@ implementer_qualcomm = {
>>           ['RTE_MAX_NUMA_NODES', 1]
>>       ],
>>       'part_number_config': {
>> -        '0xc00': {'machine_args':  ['-march=armv8-a+crc']}
>> +        '0x800': {'machine_args':  ['-march=armv8-a+crc']},
>> +        '0xc00': {'machine_args':  ['-march=armv8-a+crc']},
>>       }
>>   }
>>
>> @@ -223,8 +224,15 @@ soc_bluefield = {
>>       'numa': false
>>   }
>>
>> +soc_centriq2400_v1_1 = {
>> +    'description': 'Qualcomm Centriq 2400 (SoC v1.1)',
>> +    'implementer': '0x51',
>> +    'part_number': '0x800',
>> +    'numa': false
>> +}
>> +
> What is the difference between SoC v1.1 and SoC v2.0. Do they have different instruction levels or extensions?
> They have the same machine_args. I think the two part numbers can share the same soc_xx. Because cross built binary can run on both SoCs.
> What do you think?

Hello,

There is no visible differences between the two versions.

How do we merge the soc_centriq2400 configurations ?
It would seem it is only possible to have one part_number per soc 
configuration.

	Thierry

> 
> Thanks.
>>   soc_centriq2400 = {
>> -    'description': 'Qualcomm Centriq 2400',
>> +    'description': 'Qualcomm Centriq 2400 (SoC v2.0)',
>>       'implementer': '0x51',
>>       'part_number': '0xc00',
>>       'numa': false
>> --
>> 2.29.2
> 

-- 
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/

Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware