From: Claudio Fontana <cfontana@suse.de>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 0/2] vhost fixes for OVS SIGSEGV in PMD
Date: Tue, 9 Aug 2022 14:39:06 +0200 [thread overview]
Message-ID: <60f90693-bfd4-7210-47f0-d5a2099e4621@suse.de> (raw)
In-Reply-To: <20220802004938.23670-1-cfontana@suse.de>
A weekly ping on this one,
any chance to get this fix for a guest-triggered host crash included?
Thanks,
Claudio
On 8/2/22 02:49, Claudio Fontana wrote:
> This is an alternative, more general fix compared with PATCH v1,
> and fixes style issues in v2.
>
> The series fixes a segmentation fault in the OVS PMD thread when
> resynchronizing with QEMU after the guest application has been killed
> with SIGKILL (patch 1/2),
>
> The segmentation fault can be caused by the guest DPDK application,
> which is able this way to crash the OVS process on the host,
> see the backtrace in patch 1/2.
>
> Patch 2/2 is an additional improvement in the current error handling.
>
> ---
> Changes from v2: fix warnings from checkpatch.
> ---
>
> Changes from v1:
>
> * patch 1/2: instead of only fixing virtio_dev_tx_split, put the check
> for nr_vec == 0 inside desc_to_mbuf and mbuf_to_desc, so that in no
> case they attempt to read and dereference addresses from the buf_vec[]
> array when it does not contain any valid elements.
>
> ---
>
> For your review and comments,
>
> Claudio
>
> Claudio Fontana (2):
> vhost: check for nr_vec == 0 in desc_to_mbuf, mbuf_to_desc
> vhost: improve error handling in desc_to_mbuf
>
> lib/vhost/virtio_net.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
prev parent reply other threads:[~2022-08-09 12:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 0:49 Claudio Fontana
2022-08-02 0:49 ` [PATCH v3 1/2] vhost: check for nr_vec == 0 in desc_to_mbuf, mbuf_to_desc Claudio Fontana
2022-08-02 1:34 ` Stephen Hemminger
2022-09-28 14:37 ` Maxime Coquelin
2022-09-28 15:21 ` Claudio Fontana
2022-09-28 16:03 ` Thomas Monjalon
2022-09-30 10:22 ` Maxime Coquelin
2022-10-05 15:06 ` Maxime Coquelin
2022-11-02 10:34 ` Claudio Fontana
2022-12-20 12:23 ` Claudio Fontana
2022-08-02 0:49 ` [PATCH v3 2/2] vhost: improve error handling in desc_to_mbuf Claudio Fontana
2022-10-05 12:57 ` Maxime Coquelin
2022-08-02 1:40 ` [PATCH v3 0/2] vhost fixes for OVS SIGSEGV in PMD Stephen Hemminger
2022-08-02 17:20 ` Claudio Fontana
2022-08-04 10:32 ` Claudio Fontana
2022-08-09 12:39 ` Claudio Fontana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60f90693-bfd4-7210-47f0-d5a2099e4621@suse.de \
--to=cfontana@suse.de \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).