From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3688A00C2; Tue, 9 Aug 2022 14:39:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4730B4069C; Tue, 9 Aug 2022 14:39:08 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by mails.dpdk.org (Postfix) with ESMTP id 4501240143 for ; Tue, 9 Aug 2022 14:39:07 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 140FC20B64; Tue, 9 Aug 2022 12:39:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1660048747; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hl4jO998eU3m61DroRAOj29i+UpanphR0xw7RRWA9qQ=; b=YBMzc687TIaWNJyuxgsjtBhTKH3MvwyOAeHlCPtm4zEB86gEMpEiqsp1jnBZlI8AhGWUvm h7LfdGUrD+pVvSco8+8lpn9ktjOLTIA0KqvBt0qe2/+ofe+TxEebGKYFz7mO8di0clRxOw IxCmVSB5FBVmGnN4w00qOvYggKWdoBU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1660048747; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hl4jO998eU3m61DroRAOj29i+UpanphR0xw7RRWA9qQ=; b=C/GyyDg0OhWPDvNTjuLI4JjBS70evAMyxq07kr2UgzEUuxEVXvglSuvynLvelLlUST/8QS 5mRHoaq4OR9S+mDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E367413AA1; Tue, 9 Aug 2022 12:39:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1nW4NWpV8mLgFgAAMHmgww (envelope-from ); Tue, 09 Aug 2022 12:39:06 +0000 Message-ID: <60f90693-bfd4-7210-47f0-d5a2099e4621@suse.de> Date: Tue, 9 Aug 2022 14:39:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 0/2] vhost fixes for OVS SIGSEGV in PMD Content-Language: en-US To: Maxime Coquelin , Chenbo Xia Cc: dev@dpdk.org References: <20220802004938.23670-1-cfontana@suse.de> From: Claudio Fontana In-Reply-To: <20220802004938.23670-1-cfontana@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org A weekly ping on this one, any chance to get this fix for a guest-triggered host crash included? Thanks, Claudio On 8/2/22 02:49, Claudio Fontana wrote: > This is an alternative, more general fix compared with PATCH v1, > and fixes style issues in v2. > > The series fixes a segmentation fault in the OVS PMD thread when > resynchronizing with QEMU after the guest application has been killed > with SIGKILL (patch 1/2), > > The segmentation fault can be caused by the guest DPDK application, > which is able this way to crash the OVS process on the host, > see the backtrace in patch 1/2. > > Patch 2/2 is an additional improvement in the current error handling. > > --- > Changes from v2: fix warnings from checkpatch. > --- > > Changes from v1: > > * patch 1/2: instead of only fixing virtio_dev_tx_split, put the check > for nr_vec == 0 inside desc_to_mbuf and mbuf_to_desc, so that in no > case they attempt to read and dereference addresses from the buf_vec[] > array when it does not contain any valid elements. > > --- > > For your review and comments, > > Claudio > > Claudio Fontana (2): > vhost: check for nr_vec == 0 in desc_to_mbuf, mbuf_to_desc > vhost: improve error handling in desc_to_mbuf > > lib/vhost/virtio_net.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) >