From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E71BA0542; Wed, 5 Oct 2022 14:59:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3849D40694; Wed, 5 Oct 2022 14:59:51 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id A7EDD40143; Wed, 5 Oct 2022 14:59:50 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 82A2A3200893; Wed, 5 Oct 2022 08:59:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 05 Oct 2022 08:59:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664974787; x= 1665061187; bh=eLPzw2UExkG6kRbJjMJcAsiKXkxzd+JpT3MuOB6FrMs=; b=3 v3oWkbRZmzQX3hon/iT62VDfVqpSz1MolUMPP0ogmyXMFflJz0g9QcPjdY0Ils+n xFkWUDkLaRHMW8E8VaQN+kn9BQwjNKbGcKzvrykC1vg6LnR7bKGlaqeB1mr4KT/j RXHOwQShqzHKfcjj+DC8a6TNYy0F+gwRq94kYh2yvQ5AYsy1dWHSLq1SiGvNzX6T gsp7TJfC0ude7aR/RckhKeeZQAU//Sc5IWkSS8+pUp5RXsDKQH9swsL9eOTdnhGs e9cvy/AAt9L+zqjc76/xZK7Op2yXXfKESAcBMPIvMJ6PdrTqPE0w19LUKfII4qQg x2U2YYmkHPSVCd/nU3lHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664974787; x= 1665061187; bh=eLPzw2UExkG6kRbJjMJcAsiKXkxzd+JpT3MuOB6FrMs=; b=L pdMv6ei2KUhmVp0lrXY8ap91Uc4OpHfyHhr8b+KQIi9Udm83L+i5tZPDbWbwzDqF 1nVgBD1bcA+1oHxnIo0wKovCjFhCFQ65wYEKi/H2x+ZD44zuGLvTWp8atZpHaaHz wAL0RSlVF81CyBy1y4BQe8CDQNzYOpm5zBjPrPo2NHRzqVdHdNYKFzsoQZqDbSo7 md0uNmdEST1yfPUROODdki6H612zU+hT/FG9G2Gl73n2Q9Q6EJFuGKOfdd3sKT39 BAW9uBCGbV/vVXL8m0M0XN++U8YfI+Q3cbtI493yBZ+WBKdaKPjZ5wSZ+taY/kzM g6YcEQS0WvKZQmu+kDmPQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeifedgheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Oct 2022 08:59:46 -0400 (EDT) From: Thomas Monjalon To: "Naga Harish K, S V" Cc: Jerin Jacob , stable@dpdk.org, "jerinj@marvell.com" , "dev@dpdk.org" , "Carrillo, Erik G" , "pbhagavatula@marvell.com" , "sthotton@marvell.com" Subject: Re: [PATCH v7 2/3] timer: fix function to stop all timers Date: Wed, 05 Oct 2022 14:59:44 +0200 Message-ID: <6100135.17fYzF0512@thomas> In-Reply-To: References: <20220914135147.1846550-1-s.v.naga.harish.k@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > On Wed, Sep 14, 2022 at 9:03 PM Naga Harish K S V > > wrote: > > > > > > There is a possibility of deadlock in this API, as same spinlock is > > > tried to be acquired in nested manner. > > > > > > If the lcore that is stopping the timer is different from the lcore > > > that owns the timer, the timer list lock is acquired in timer_del(), > > > even if local_is_locked is true. Because the same lock was already > > > acquired in rte_timer_stop_all(), the thread will hang. > > > > > > This patch removes the acquisition of nested lock. > > > > > > Fixes: 821c51267bcd63a ("timer: add function to stop all timers in a > > > list") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Naga Harish K S V > Acked-by: Erik Gabriel Carrillo > > Added missing ack Applied, thanks.