From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id D9B582B87
 for <dev@dpdk.org>; Fri,  1 Mar 2019 14:40:28 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 34E912016D;
 Fri,  1 Mar 2019 08:40:28 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Fri, 01 Mar 2019 08:40:28 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=5kEKmgdaBXp7LY0TeZG4jvayRNdp1pBJAL0NtiSlX2A=; b=MFc2/sjcPGCK
 0LyELDQoQQaTUqhs7i76eSkJkBevd83FMf7sKbrUGP6PrPg7rdM3emR6JnD7PKZu
 OqNl4FnSc1i7LhZUuLVuUVWh745k1/wLruxd6Yf6Qf6bXIam7tLy3iF++rg2jGWc
 +FXFqIx8d8tioAlwwvFuWfAwazuw18c=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=5kEKmgdaBXp7LY0TeZG4jvayRNdp1pBJAL0NtiSlX
 2A=; b=0ORchhDkcX6TFPA00uniydrAVHV4kdfH50RNXbDW4TORTG3BBovI3qsDA
 fvuNNdEHTNkY6GnEMX3unFOOIKCqcuqAHFDCI+PCk0i7W4HEGptUN9tg8mPFu3W9
 Ck4IR2ueoNYLmrPKdTyrkhsvyeVCo94SfXzqQluONpg7XZPXXFNYaWmKeuA2eQBQ
 TsemBldsAjKAhkRP/dv3Eb3XkG84bwH2GVSnEWMA0VGTjPS9mlVQle+L5BYdoaPb
 UnKGfhgE/UYqr6tAR1end/o9ds7qHs6xo8D36ILeaVU55S4SdSGgg34HKuyUb5DP
 UthZj++vhusvpw+mwtTjAuy5Cizjg==
X-ME-Sender: <xms:SzZ5XBR5iZ1ardmhXudiVikReK7G_5rI2imL6uTA3XeEfv5AMOURUw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvdehgdehfecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
 epleefrdeirddugeelrdduudegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgr
 shesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:SzZ5XCYIiy4hOYjwnrnaRaRTO47ogbpCGjyRe5p7osesVuIX-u_cDQ>
 <xmx:SzZ5XCDoKG7MdM1e0kxzdgSdt4d-aPVJYE532R4te7Z5VLsl7XEV7Q>
 <xmx:SzZ5XDX7lwmv0XkiItGaB1fjOPju4pkXrbqI2NVXoJ60ww7_BWOheA>
 <xmx:TDZ5XPsp5EWkCG9dTxT2r_wG4KaltRuagT5rZfU9CA3J6NxN7W8VjQ>
Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114])
 by mail.messagingengine.com (Postfix) with ESMTPA id 77384E427E;
 Fri,  1 Mar 2019 08:40:26 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Qiming Yang <qiming.yang@intel.com>
Cc: dev@dpdk.org
Date: Fri, 01 Mar 2019 14:40:24 +0100
Message-ID: <6104831.5nKYbsrVhy@xps>
In-Reply-To: <20190301124613.66527-1-qiming.yang@intel.com>
References: <20190301124613.66527-1-qiming.yang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: suppport package download
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Mar 2019 13:40:29 -0000

01/03/2019 13:46, Qiming Yang:
> Columbiaville requires a package to be downloaded if need advanced
> features. This patch add package download support in two ways.
> If it configured package path in devargs, will use this path,
> if not, will load the package at /lib/firmware/intel/ice/ddp/ice.pkg.
> 
> When package download failed, will initialize in safe mode, some
> advanced features will not be supported.
> 
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 134 +++++++++++++++++++++++++++++++++++++++++++
>  drivers/net/ice/ice_ethdev.h |   2 +
>  2 files changed, 136 insertions(+)

I think you should update the doc in this patch.
Users may want to know about this new option,
and where to download the packages.