From: huangdengdui <huangdengdui@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>,
<liuyonglong@huawei.com>
Subject: Re: [PATCH 3/3] net/hns3: fix can't use vector for Rx when set VLAN filter
Date: Tue, 10 Jun 2025 09:19:24 +0800 [thread overview]
Message-ID: <6107161a-119f-4e13-8839-63a82b2c86e9@huawei.com> (raw)
In-Reply-To: <20250609101233.73a05aef@hermes.local>
On 2025/6/10 1:12, Stephen Hemminger wrote:
> On Mon, 9 Jun 2025 21:06:51 +0800
> Dengdui Huang <huangdengdui@huawei.com> wrote:
>
>> Currently, When RTE_ETH_RX_OFFLOAD_VLAN_FILTER offload is set,
>> driver wouldn't select Rx vector algorithm. Actually, this
>> algorithm support it, so open it.
>>
>> Fixes: a3d4f4d291d7 ("net/hns3: support NEON Rx")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
>
> Mind if I reword commit message slightly.
> Use past tense for case before the patch was applied (old)
> and present for case when patch is applied.
>
> When the RTE_ETH_RX_OFFLOAD_VLAN_FILTER offload flag was set,
> the driver would not select the Rx vector algorithm.
> But this flag is OK when using vector algorithm so remove
> it from the mask.
>
>
Okay, I don't mind. This new description is easier to understand.
prev parent reply other threads:[~2025-06-10 1:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 13:06 [PATCH 0/3] net/hns3: bugfix for hns3 Dengdui Huang
2025-06-09 13:06 ` [PATCH 1/3] net/hns3: fix the hardware GRO function is abnormal Dengdui Huang
2025-06-09 17:13 ` Stephen Hemminger
2025-06-10 1:27 ` huangdengdui
2025-06-09 13:06 ` [PATCH 2/3] net/hns3: fix can't use vector for Tx when not set fast free Dengdui Huang
2025-06-09 13:06 ` [PATCH 3/3] net/hns3: fix can't use vector for Rx when set VLAN filter Dengdui Huang
2025-06-09 17:12 ` Stephen Hemminger
2025-06-10 1:19 ` huangdengdui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6107161a-119f-4e13-8839-63a82b2c86e9@huawei.com \
--to=huangdengdui@huawei.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).