From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id B68C57E7B for ; Tue, 21 Oct 2014 23:03:35 +0200 (CEST) Received: by mail-wi0-f169.google.com with SMTP id r20so2927901wiv.0 for ; Tue, 21 Oct 2014 14:11:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=E+AhuSeDlClJyq6ty/sltms0zR/2+vygwH1qJzX7j0U=; b=gu04qFn+/avY5KIeYREWF2rGtX8t4WxYSRn3XZudVfRipePLWBHzcQG7xN1bp2yadr XRlFbeLEyjoYPOecGs/MlrkqtWRjUK3hoymioJYwyFYQduefx0N93EvRPEwr7fCS67B2 yHPdxd5T19V8Tiqjc9j7AXuvBo9THwp7p71qm5/9zz/AN8tvrhmZbldK4CON5MJ9IYtR 3iV7YWYRKBjseFa9hlyOlVUiC7X2OqXcrlL+gwzBwt+Bf2pIwGls7o+2O1XmwbMK2v18 axyZVpdoQAf/7ay2a/8k2WTsy8Pv54AKMmNeUZMxhXOEZStKQKGwfLVSl6kBVxNlRuGZ o5Tw== X-Gm-Message-State: ALoCoQl7VWAB/YtS3kD+2uEfV6jmlnDM8xLd+Uxe9vRJofv/8O90EoBs3PPo9BxYBTh1bxjjoLQc X-Received: by 10.194.90.15 with SMTP id bs15mr45283986wjb.47.1413925913177; Tue, 21 Oct 2014 14:11:53 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ma8sm16585670wjb.46.2014.10.21.14.11.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Oct 2014 14:11:52 -0700 (PDT) From: Thomas Monjalon To: Pablo de Lara Date: Tue, 21 Oct 2014 23:11:35 +0200 Message-ID: <6121476.at0lcZkNCO@xps13> Organization: 6WIND User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; ) In-Reply-To: <1413900943-27711-1-git-send-email-pablo.de.lara.guarch@intel.com> References: <1413900943-27711-1-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] librte_ip_frag: Disable ipv4/v6 fragmentation if RTE_MBUF_REFCNT=n X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Oct 2014 21:03:35 -0000 2014-10-21 15:15, Pablo de Lara: > Ipv4/v6 fragmentation libraries depends on refcnt. > There was a compilation error if RTE_MBUF_REFCNT was disabled, > so those libraries have been disabled in that situation. Please Pablo, could you add a short justification that it's not possible to implement fragmentation without refcnt (at least with the current design)? What do you think of adding a warning as below? > +ifeq ($(CONFIG_RTE_MBUF_REFCNT),y) > SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv4_fragmentation.c > -SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv4_reassembly.c > SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv6_fragmentation.c +else +$(info WARNING: Fragmentation feature is disabled because it needs MBUF_REFCNT.) > +endif > +SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv4_reassembly.c -- Thomas