From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Doherty, Declan" <declan.doherty@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] bond: fix for mac assignment to slaves device
Date: Thu, 11 Dec 2014 02:01:55 +0100 [thread overview]
Message-ID: <6126891.ZxNGlZ50TB@xps13> (raw)
In-Reply-To: <F6F2A6264E145F47A18AB6DF8E87425D12B676F5@IRSMSX102.ger.corp.intel.com>
> > -V2:
> > Tidies up the slave_remove function as per Pawel's comments.
> >
> > Adding call to mac_address_slaves_update from the lsc handler when the
> > first slave become active to propagate any mac changes made while
> > devices are inactive
> >
> > Changed removing slave logic to use memmove instead of memcpy to move
> > data within the same array, as this was corrupting the slave array.
> >
> > Adding unit test to cover failing assignment scenarios
> >
> > Signed-off-by: Declan Doherty <declan.doherty@intel.com>
>
> Acked-by: Wodkowski, Pawel <pawelx.wodkowski@intel.com>
Applied
Thanks
--
Thomas
next prev parent reply other threads:[~2014-12-11 1:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 17:34 [dpdk-dev] [PATCH] " Declan Doherty
2014-12-08 7:10 ` Jiajia, SunX
2014-12-08 9:21 ` Wodkowski, PawelX
2014-12-08 9:31 ` Wodkowski, PawelX
2014-12-08 11:19 ` [dpdk-dev] [PATCH v2] " Declan Doherty
2014-12-08 14:54 ` Wodkowski, PawelX
2014-12-11 1:01 ` Thomas Monjalon [this message]
2014-12-09 5:43 ` Jiajia, SunX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6126891.ZxNGlZ50TB@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).