From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 99B527E23 for ; Thu, 11 Dec 2014 02:02:22 +0100 (CET) Received: by mail-wg0-f41.google.com with SMTP id y19so5106022wgg.14 for ; Wed, 10 Dec 2014 17:02:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=21ZvewB4kI0bTHpp/2YkVdjQ+P1rzHUlPNyO+5xivPo=; b=m27RHC9VSTr4ZoXKpmyb27RdtrQeiRuoZ1+ZMXxB2u+Bp094ktzX7HWUM1g0Z5Rs/z P7dJQn75eEQz7y+nngCGaa0DxTQZ/y1FEwhoVEZy5dW8pZSN5+rTfH1jLir8kw/bZFNh z0ph8S83vMorT6QvCOqdmq6EKrfVonjy5TFesTgr9+7+NLoKX3yWnc+sVdv5807l7YDx Ec66T6Xfhgxn/kNq7bQuDj9SoH1vQ2xtfoUxiEDyElFmJNbvPlVqQPz86YdSwtQpUg/k QFpMP0MjO4XW1S1rHz1YFsTdf6nauqi03QTL7Xtrc3SaPeBd233eDZWg+g7Dnv2MSk7D Ycaw== X-Gm-Message-State: ALoCoQnmjD+UUt73iHGWNweU6g/C43rRtyk/8P0Qe9VbmNfamjjrfzL15tseBXY1YrJ3esj8L90P X-Received: by 10.180.91.201 with SMTP id cg9mr18076909wib.63.1418259742468; Wed, 10 Dec 2014 17:02:22 -0800 (PST) Received: from xps13.localnet ([88.249.222.12]) by mx.google.com with ESMTPSA id ep9sm178181wid.3.2014.12.10.17.02.21 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 10 Dec 2014 17:02:21 -0800 (PST) From: Thomas Monjalon To: "Doherty, Declan" Date: Thu, 11 Dec 2014 02:01:55 +0100 Message-ID: <6126891.ZxNGlZ50TB@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <1417800885-18643-1-git-send-email-declan.doherty@intel.com> <1418037572-6546-1-git-send-email-declan.doherty@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] bond: fix for mac assignment to slaves device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Dec 2014 01:02:22 -0000 > > -V2: > > Tidies up the slave_remove function as per Pawel's comments. > > > > Adding call to mac_address_slaves_update from the lsc handler when the > > first slave become active to propagate any mac changes made while > > devices are inactive > > > > Changed removing slave logic to use memmove instead of memcpy to move > > data within the same array, as this was corrupting the slave array. > > > > Adding unit test to cover failing assignment scenarios > > > > Signed-off-by: Declan Doherty > > Acked-by: Wodkowski, Pawel Applied Thanks -- Thomas