From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13CBCA04B5; Fri, 6 Nov 2020 17:57:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EF997DED; Fri, 6 Nov 2020 17:57:35 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id EE2342AB for ; Fri, 6 Nov 2020 17:57:32 +0100 (CET) IronPort-SDR: 9stb3a2P0PRVpgRmlrjMN2befLA+3jKDgl1vFGXW8g+Z7RYneQlsIvYquEyU0cDZx13o9sVlPc m98D4gYNtMRg== X-IronPort-AV: E=McAfee;i="6000,8403,9797"; a="231196785" X-IronPort-AV: E=Sophos;i="5.77,457,1596524400"; d="scan'208";a="231196785" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 08:57:31 -0800 IronPort-SDR: 7mkzyMt2zrINCJljP+oxlOwOcbu901CqzDC6iJa22fCM8Ys7wD+AOm7W/QZDWjMfcrKJndiVZL rI0c140sfwgw== X-IronPort-AV: E=Sophos;i="5.77,457,1596524400"; d="scan'208";a="539906778" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.228.45]) ([10.213.228.45]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 08:57:30 -0800 To: Lijun Ou Cc: dev@dpdk.org, linuxarm@huawei.com References: <1604586194-29523-1-git-send-email-oulijun@huawei.com> <1604634716-43484-1-git-send-email-oulijun@huawei.com> <1604634716-43484-6-git-send-email-oulijun@huawei.com> From: Ferruh Yigit Message-ID: <612a397c-47e8-257c-4019-fc101da89472@intel.com> Date: Fri, 6 Nov 2020 16:57:26 +0000 MIME-Version: 1.0 In-Reply-To: <1604634716-43484-6-git-send-email-oulijun@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 5/5] net/hns3: fix queue enabling status not store after FLR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/6/2020 3:51 AM, Lijun Ou wrote: > From: Chengchang Tang > > The FLR will resets the queue enabling status. In the > current code, the queue enabling status is not restored > after the reset. Therefore, if upper layer users have > called queue start/stop function before the reset, the > behavior after the reset is not as expected. > > This patch fix it by add a queue enabling status restore > function to the reset handler. > Can you please re-work above description, it looks like it can be improved. > Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop") > Cc: stable@dpdk.org > > Signed-off-by: Chengchang Tang > Signed-off-by: Lijun Ou > --- > drivers/net/hns3/hns3_ethdev.c | 5 +++++ > drivers/net/hns3/hns3_ethdev_vf.c | 5 +++++ > drivers/net/hns3/hns3_rxtx.c | 20 ++++++++++++++++++++ > drivers/net/hns3/hns3_rxtx.h | 1 + > 4 files changed, 31 insertions(+) > > diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c > index b27cf67..e177549 100644 > --- a/drivers/net/hns3/hns3_ethdev.c > +++ b/drivers/net/hns3/hns3_ethdev.c > @@ -5567,6 +5567,11 @@ hns3_start_service(struct hns3_adapter *hns) > /* Enable interrupt of all rx queues before enabling queues */ > hns3_dev_all_rx_queue_intr_enable(hw, true); > /* > + * Enable state of each rxq and txq will be recovered after > + * reset, so we need restore them before enable all tqps; > + */ Same with the comments (this + below one) please. Also instead of "enable state" or "enabling status", does it make sense to just say 'state'?