From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6268942417; Thu, 19 Jan 2023 13:41:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5042340223; Thu, 19 Jan 2023 13:41:14 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 28337400D5 for ; Thu, 19 Jan 2023 13:41:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RKUrPwLDwVwKR7ne5TkPSbZC6shsuEnBeiIQD8bntnjrg+dRrlNkt9K+udldHwxfT0oujBIBO7OLTZyqjgHCN8FM8Jqsjh13qP0VGL/MPI9BsCOSSODFArHMAGl5nj5gYRsk1hVs5Avivwombv9kwGPILE0Y6ICQE0eg38kPlteeRSd/VMYzMm5kfr3/3Yir0y+RnGIhjZrDNZYqrx3yQSIDLLG1bvSi1uvvLE6iu6lci9NsbUJQJukjfsKQcPz2Ic//0pwiQntJ0uG44sIz84aNswtByP6C1F7V8uGslmCWAM6njQIAaUQid8E4HeyIHCAHmdqZ/xbf+77m52x1DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hsW5xohH8aqSEwmHjlu6PaFIiFL/Qqk6aV6D0xpZ/jA=; b=dZMo8ivkGr4nHGCMPKGFWR9Urnwu0SrGNm0uRVPxoNdBuyPlnGvBJ4vFPKQduFO6OFe9J//lBfPdE8rbWl77J69s4pddzzHA+Iu++9Jd2xq/kJq2DOdJR14/nBK4cQhFJxzM77zlDBnBpQfm39jrCRZs2QLV6Vs08JKC6MAIa/cEfrnmiDt50Gn6Un+lfkPyZryJBNzAUPKJzaQLiVkAzvmKYKXMQPD8mOtbvh2IDpxKsbFXRGu0r9xAXuOgxNwScymGgQ0kfyO47y50Z8b8BqRf6nk8bItOXvMnetLxCq29aZ/oVscmjtjjc9i9/5ZtX3KwMNr6MFUEibNDRxc3oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hsW5xohH8aqSEwmHjlu6PaFIiFL/Qqk6aV6D0xpZ/jA=; b=bsv5uLi9Qp89p1cXCZrcKfEjEh+YQZAR2mctoC84OE/5Dt+TWV0/kxArN1jY12oTJpQY+5NJ42kCzlz8dGRrsABdvm8AfgsvlqZnCT5e9DZTAAMZvtHvN50oP6lOW804ZsomUBpabvDz2xPaGQl/s5XzdFcePme2szBJWzvKbeM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB6065.namprd12.prod.outlook.com (2603:10b6:208:3ef::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.26; Thu, 19 Jan 2023 12:41:11 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%8]) with mapi id 15.20.6002.024; Thu, 19 Jan 2023 12:41:11 +0000 Message-ID: <61409bc0-9254-95c6-e1fe-877cb029e34e@amd.com> Date: Thu, 19 Jan 2023 12:41:06 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] net/nfp: update descriptors logic Content-Language: en-US To: =?UTF-8?Q?Niklas_S=c3=b6derlund?= , dev@dpdk.org Cc: oss-drivers@corigine.com, Jin Liu , Chaoyong He References: <20221122130948.4100369-1-niklas.soderlund@corigine.com> From: Ferruh Yigit In-Reply-To: <20221122130948.4100369-1-niklas.soderlund@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0198.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB6065:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f411c58-1417-4bc2-9022-08dafa1a71be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gSFgPwkHr3UACrcNoUnrcXMDWtlpsHsVIPmwZLmoUEKe7YJKWduFVh1CZwoZr+tgGo4l1KyxEOe5G5nGCTEM1FIRVcAvVSuFzehlig9zTRZMD5jh1rVzlMGeIFzM6mVHI4u3YRudMdmJ3idhLhjKdh4zre/HWrLITIxU78wIRDH8avStLMEU6AX/q9U7Nmnq/4zZZJRHgD5hDHFrVBWUmZCy2TS9G9JIGaaziHnCQlowU6awE33SDixMD2TtIU8Ebamm5DI5Cr8UDt80dsg7YbrnI+LTPpHv6RpKL1f9i2mGt972zxA3kGLKZlTRs6W/PUF6qF2HAKOnLYInx1d6otz+IZQEi69oGfy6qyw/59BYl/CTFNptXnD0cHmrlvrorc3MQ4WMRDKDk2tdh+UcYk4w3YSc67+VPCMAw4SN4De/BxbjgNix6xpS6Defi3k+cVBERAUfX8RnBDUYgXoh8Gl5lezAEj1M7d0CJO2a3ppiSD22HJGCflD/ssfMYnVqyPHjH+rQP/BFGAkghJDFyx49+ob5ZX198Ey8+mPTzh0XijY6Juy13hcEGiZ2wyvVNUh8ZPiQzRoI/SA/dk/WQWNjxcet3bzQAzhuMJG+2T4m+pJ7iq9o3NbvtKC4lu1nTUl0k3ul9Q+tqQWnhTPGg3YqUfKdLHugkeLb+TMUr2dBdadFRBfaVMGmAZJcAyv3fgteEYDE+hBvzJ1XWCfCjsv4qplLkddic+vqD+QIjdU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(39860400002)(396003)(366004)(136003)(346002)(451199015)(186003)(26005)(478600001)(6486002)(6512007)(5660300002)(8936002)(83380400001)(6506007)(6666004)(53546011)(31686004)(2616005)(316002)(54906003)(66946007)(36756003)(66556008)(66476007)(38100700002)(41300700001)(66574015)(8676002)(4326008)(4744005)(44832011)(2906002)(86362001)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmtsTkNobjBYeExCZHB1clc2ZG1KcU9CaTNSRWFEdXpHb1ZaeVEzRVJQNWs0?= =?utf-8?B?eEs3ZnNOcW8xN01ZRlNGdGFod292bjNNbmNwNTlSenVYSFpUUmtRaXFHQXh0?= =?utf-8?B?blJiUUJQYkN1eXVzNFVwdFJLcTdhV3J0ekJPVThzWGxLQWhZdkY0Q1ZsV1VL?= =?utf-8?B?eVdtQkIzWllvenUvQVZDdEtDMHJsOE9ueklURkMwdk1maDkvSXY0YTZwTkR3?= =?utf-8?B?bTQzZDcyNDE2Qy91bDNsV2NqYzJDTFdodGlBcHFoWDlhajE0MktjOGlIRFZy?= =?utf-8?B?cmVLNVlKVEtlSnY4NC8zckZsNFljYnQvdWYwSTRCVlgrb0RYZzFPL1hqQXRM?= =?utf-8?B?a0Q4TUl1OWxDTm9STU83cjNRb0NsVy95cUo0dS80aGczdUQzdU56NDNSMlFa?= =?utf-8?B?c1NZL3k5TndHZ2s4azdpRGlmbUJSdllESkpJdHV0d1ZINDJMM01QNDM4RHU3?= =?utf-8?B?YjFMTlZRRTZmVDNDZjFYM3dTb05Ya3ZnVkJYTVlsWm9XYm5lTElScUI4Q240?= =?utf-8?B?Rmc2OXhYLzFycm9Td3N5UjhqUTgrNkxEUzNuTW5zOU9OQjN4cFpQZktBMFVI?= =?utf-8?B?ZTJIb2JkRm0wb1d1MFB3dmRNNCtXSng2V2RWOFVMN2ZMeVZJSHFIdlBua1Ew?= =?utf-8?B?WjQ2LytlaWdBSkFwam5XT2JCQ3FoZTJobUp1USt2UDJTQi9Ec3R4UW9yN2pr?= =?utf-8?B?YUw1Q09RMGRURTNzUHZBVjBuTmNjSGM2ZDk2VVp0cDc5WlVGV0tkN3JjeXFa?= =?utf-8?B?eVpNaGhIdkN1VjN4ZnBManpZSXVwZVduK0hweEpoU2xEcXEvMWVXeUdmVUZ0?= =?utf-8?B?YVBoZlYyczNnRjVrWDk1MHJLbnNNcmIyb1ZBaTl1bVFYNjFqZ2pWRWdvdVdR?= =?utf-8?B?aFdXSkFmL1dtZkFNcU56ai9kUDNvWWdvenlUUXdNaEhMVm1SKzliU0VnS3d4?= =?utf-8?B?cUgyeUM2RHd1bkprQ0lwN1dJMWlRc3VER3RGOG1FenhLWG1ZZkxsRDBja0dU?= =?utf-8?B?TWNzTzJzVEQ4d3R1Q2lXL0dBeWtBRVBSSnVsOElyRjUrTzVXU1N2blQ2QTdV?= =?utf-8?B?UEdyTzVvVzhQTWJoYkt4SXZiWVpWSVBBZjFJUWJPUzJyTGlKQXljWWE5ZW53?= =?utf-8?B?NDE2WFBPSXZUU3A5emdESTdWZHBodWhlWkFCaEZXdnR3akkzQ0dENXRoQzQv?= =?utf-8?B?SkpaNFdKUGV2TTVRbTcwUTh3REx6QVR0SUlZQVlqc25JVXJvQ3V3enRnYmho?= =?utf-8?B?aDBndzhFMXN4WGNVWlZGSExMb3IycE5Dc0J4UmNjVS9HZkErSW5XME1iR2pv?= =?utf-8?B?K2c3dTZ1Zmx2R2ZVWGxBdFFHRkNTVjBKcFZvd2g0NUV1dEF5RFpFQ2l4WU1C?= =?utf-8?B?bUxlMEtLcWJkS1ZsUDNBVHlxVTVBQmJJZUNyMFh3bEJSYnVXY0dZUE03MEJ2?= =?utf-8?B?YnZjbW5vVmRFSnBwUnc3aDFhU3lxa1NTcnZGamMzQjAzWG94U1hSUWpVWWgy?= =?utf-8?B?azlaanYzSFFQTHd4VHgzWUMreHZYcWd4ZTIyZ3h1WDI2dlAyM29QTmk5WU1j?= =?utf-8?B?ckc2Q3RhMWI3VTJDY0pRNmQ3d2RwQzQ4blpjSmx5T0daMDEwVWhXb0U2RWlH?= =?utf-8?B?dGlxTFdiZFdVc0pVanFVc1Z5ZTBJQkwxeDdsY1N1TkdHQjVMclNEUHYxZlRo?= =?utf-8?B?SXpWNUtMTnJKZ0ltS2t2R2FmTERnd01HUHJ5WEFwZzlsMWc4aXo5WGM2UkhH?= =?utf-8?B?TFNjdzBQakVHZFVRMnVTTGFveFF0YVREU3NML25IOXl6VmxWZ0duZlM0TFNE?= =?utf-8?B?Nk55T2pBK2pSL0d3THFqQXZHbnY1VVJ2N0hnUzF0NjhzYW15MzVRcTIwS2NQ?= =?utf-8?B?c0s1YWFOQ01FQWVDcW4xM3pmZnZiUkV4RmxuaEtSN0hiVVdNN2dLdHlWY1JB?= =?utf-8?B?KzdwWGJNUWxjdFh5bUh5eklpcXVXaXhVZkVmNE9ZYUlUdXBWcTcySHN3Q21k?= =?utf-8?B?eGtUSk9EbUY0T3dLMmFodm9nWi90NlhqSFgzREIrcFB0alFMaDVpdDZQOXBl?= =?utf-8?B?YUpGc1VnZ2VSWmNLZ1NsM0w3RVNTT1FKNWJmODRXc1JYbHZCbEhnZWdjc2xF?= =?utf-8?Q?bFxa7Zy/Tl6sxfkCIC4TSFuCl?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f411c58-1417-4bc2-9022-08dafa1a71be X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2023 12:41:11.3566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NNABt8cCimW6+THHsBXxdyhRkCcGD+q1tpNmPB4z+38g0ThzyEuVmVPAIfDFAS5f X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6065 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/22/2022 1:09 PM, Niklas Söderlund wrote: > From: Jin Liu > > The minimum value of TX/RX descriptors for NFP3800 card is not same > with NFP4000 card, the minimum value of NFP4000 card is 256 while > NFP3800 card is 512, add the minimum descriptor macro for NFP3800 > card. > > Modify the logic of get descriptor value, assign the value of descriptor > for the corresponding network card according to its type. > > In TX stage, firmware with NFD3 use one descriptor per packet while > firmware with NFDk use two descriptors. In order to be consistent > with the kernel driver, the number of descriptor of firmware with > NFDk should be divided by 2. > > Signed-off-by: Jin Liu > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund > Signed-off-by: Niklas Söderlund Applied to dpdk-next-net/main, thanks.