From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B28F31B858 for ; Wed, 31 Jan 2018 23:34:54 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4B92A20C7C; Wed, 31 Jan 2018 17:34:54 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 31 Jan 2018 17:34:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=3afEqCGvwiIef+FuExwceL4WGJ vBf7vQaluZNxPysJI=; b=kOAdeFS7jYCKZYL1zQxgaUF8bMHa4x8Q0vq4foWEu2 KTB35FMVcs82A/4LA2/Okz36bf/8NdTLLfHI8uikXL+dcOMXYbYuHmx0SfuNQKU2 Ie1LbA1bSXUpe2340RCZQFbZ65aPbl+idEswFSqd279z/JQg4w0tSRixwhMC3NHU E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=3afEqC GvwiIef+FuExwceL4WGJvBf7vQaluZNxPysJI=; b=Lh3I4SFwrai9OvcpKjvfkg ykd+3oBUPVpB1QSCpMjdtSh/V2l8LQvLM0qf6Nod8yebk1i8x33QnEOKT+ybdJey HHXNCFem22oMHqpUeOibyIgubxplOJxXJGhw1vvE19treePwZEpEZuI4A48WlWq3 +TnXvbdXp7NVkL9vtGDcTMG4ZU8TYheX+enGM0OmWR6ZqWRIRCN1znOuiuBWfjW4 Mr53BE1gifMlKw1ph8ItFZXBSTzsX8o8RZ8B6mA2VNmBIK6q4mCZyyyRa7OJdTap sX05M7GuqD4pJ0CsjenfLhs5UuwlGEzMD9PpAz0ifMUlTQUfmm5TtnGC60GMnGYg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E5AE57E3D5; Wed, 31 Jan 2018 17:34:53 -0500 (EST) From: Thomas Monjalon To: Jiayu Hu Cc: dev@dpdk.org, Shahaf Shuler , "wenzhuo.lu@intel.com" , "lei.a.yao@intel.com" Date: Wed, 31 Jan 2018 23:34:06 +0100 Message-ID: <6151298.L9tu3aqMsX@xps> In-Reply-To: References: <1516846424-19929-1-git-send-email-jiayu.hu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 22:34:54 -0000 25/01/2018 07:54, Shahaf Shuler: > Hi Jiayu Hu, > > Good fix, thanks. > > Thursday, January 25, 2018 4:14 AM, Jiayu Hu: > > In current design, we can't enable SW checksum calculation for the devices > > which don't have checksum offloading abilities via the command "csum set > > ip|tcp|udp|sctp|outer-ip sw ". > > But SW checksum calculation shouldn't depend on HW offloading abilities. > > This patch is to fix this issue. > > > > Fixes: 3926dd2b6668 ("app/testpmd: enforce offload capabilities check") > > Signed-off-by: Jiayu Hu > > Reviewed-by: Shahaf Shuler Applied, thanks