DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v3] eal/ppc64: improve rte_rdtsc() with __ppc_get_timebase()
@ 2020-03-25  0:13 Thinh Tran
  2020-04-16 22:35 ` Thomas Monjalon
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Thinh Tran @ 2020-03-25  0:13 UTC (permalink / raw)
  To: dev, stable; +Cc: david.marchand, drc, Thinh Tran

  __ppc_get_timebase() reads and returns the current value of the Time 
  Base Register. It's more efficient as it uses the processor’s time  
  base facility directly 

  the DPDK on FreeBSD currently is not supported on Powerpc64, it should
  be safe to include the sys/platform/ppc.h


Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
---
 .../common/include/arch/ppc_64/rte_cycles.h   | 28 ++-----------------
 1 file changed, 2 insertions(+), 26 deletions(-)

diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h b/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
index 8f2e98642..871f9b6e4 100644
--- a/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
+++ b/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
@@ -14,6 +14,7 @@ extern "C" {
 
 #include <rte_byteorder.h>
 #include <rte_common.h>
+#include <sys/platform/ppc.h>
 
 /**
  * Read the time base register.
@@ -24,32 +25,7 @@ extern "C" {
 static inline uint64_t
 rte_rdtsc(void)
 {
-	union {
-		uint64_t tsc_64;
-		RTE_STD_C11
-		struct {
-#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
-			uint32_t hi_32;
-			uint32_t lo_32;
-#else
-			uint32_t lo_32;
-			uint32_t hi_32;
-#endif
-		};
-	} tsc;
-	uint32_t tmp;
-
-	asm volatile(
-			"0:\n"
-			"mftbu   %[hi32]\n"
-			"mftb    %[lo32]\n"
-			"mftbu   %[tmp]\n"
-			"cmpw    %[tmp],%[hi32]\n"
-			"bne     0b\n"
-			: [hi32] "=r"(tsc.hi_32), [lo32] "=r"(tsc.lo_32),
-			[tmp] "=r"(tmp)
-		    );
-	return tsc.tsc_64;
+	return __ppc_get_timebase();
 }
 
 static inline uint64_t
-- 
2.17.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v3] eal/ppc64: improve rte_rdtsc() with __ppc_get_timebase()
  2020-03-25  0:13 [dpdk-dev] [PATCH v3] eal/ppc64: improve rte_rdtsc() with __ppc_get_timebase() Thinh Tran
@ 2020-04-16 22:35 ` Thomas Monjalon
  2020-04-20 16:42 ` David Christensen
  2020-04-21 16:17 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2020-04-16 22:35 UTC (permalink / raw)
  To: drc; +Cc: dev, stable, david.marchand, Thinh Tran

Any review please?

25/03/2020 01:13, Thinh Tran:
>   __ppc_get_timebase() reads and returns the current value of the Time 
>   Base Register. It's more efficient as it uses the processor’s time  
>   base facility directly 
> 
>   the DPDK on FreeBSD currently is not supported on Powerpc64, it should
>   be safe to include the sys/platform/ppc.h
> 
> 
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
>  .../common/include/arch/ppc_64/rte_cycles.h   | 28 ++-----------------
>  1 file changed, 2 insertions(+), 26 deletions(-)
> 
> diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h b/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
> index 8f2e98642..871f9b6e4 100644
> --- a/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
> +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
> @@ -14,6 +14,7 @@ extern "C" {
>  
>  #include <rte_byteorder.h>
>  #include <rte_common.h>
> +#include <sys/platform/ppc.h>
>  
>  /**
>   * Read the time base register.
> @@ -24,32 +25,7 @@ extern "C" {
>  static inline uint64_t
>  rte_rdtsc(void)
>  {
> -	union {
> -		uint64_t tsc_64;
> -		RTE_STD_C11
> -		struct {
> -#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
> -			uint32_t hi_32;
> -			uint32_t lo_32;
> -#else
> -			uint32_t lo_32;
> -			uint32_t hi_32;
> -#endif
> -		};
> -	} tsc;
> -	uint32_t tmp;
> -
> -	asm volatile(
> -			"0:\n"
> -			"mftbu   %[hi32]\n"
> -			"mftb    %[lo32]\n"
> -			"mftbu   %[tmp]\n"
> -			"cmpw    %[tmp],%[hi32]\n"
> -			"bne     0b\n"
> -			: [hi32] "=r"(tsc.hi_32), [lo32] "=r"(tsc.lo_32),
> -			[tmp] "=r"(tmp)
> -		    );
> -	return tsc.tsc_64;
> +	return __ppc_get_timebase();
>  }
>  
>  static inline uint64_t





^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v3] eal/ppc64: improve rte_rdtsc() with __ppc_get_timebase()
  2020-03-25  0:13 [dpdk-dev] [PATCH v3] eal/ppc64: improve rte_rdtsc() with __ppc_get_timebase() Thinh Tran
  2020-04-16 22:35 ` Thomas Monjalon
@ 2020-04-20 16:42 ` David Christensen
  2020-04-21 16:17 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: David Christensen @ 2020-04-20 16:42 UTC (permalink / raw)
  To: Thinh Tran, dev, stable; +Cc: david.marchand



On 3/24/20 5:13 PM, Thinh Tran wrote:
>    __ppc_get_timebase() reads and returns the current value of the Time
>    Base Register. It's more efficient as it uses the processor’s time
>    base facility directly
> 
>    the DPDK on FreeBSD currently is not supported on Powerpc64, it should
>    be safe to include the sys/platform/ppc.h
> 
> 
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
>   .../common/include/arch/ppc_64/rte_cycles.h   | 28 ++-----------------
>   1 file changed, 2 insertions(+), 26 deletions(-)
> 
> diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h b/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
> index 8f2e98642..871f9b6e4 100644
> --- a/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
> +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h

Patched file location has moved, now lib/librte_eal/ppc/include/* as a 
result of commit a1b6cda16a07, otherwise it's good to go.

Reviewed-by: David Christensen (drc@linux.vnet.ibm.com)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v3] eal/ppc64: improve rte_rdtsc() with __ppc_get_timebase()
  2020-03-25  0:13 [dpdk-dev] [PATCH v3] eal/ppc64: improve rte_rdtsc() with __ppc_get_timebase() Thinh Tran
  2020-04-16 22:35 ` Thomas Monjalon
  2020-04-20 16:42 ` David Christensen
@ 2020-04-21 16:17 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2020-04-21 16:17 UTC (permalink / raw)
  To: Thinh Tran; +Cc: dev, dpdk stable, David Christensen

On Wed, Mar 25, 2020 at 1:17 AM Thinh Tran <thinhtr@linux.vnet.ibm.com> wrote:
>
>   __ppc_get_timebase() reads and returns the current value of the Time
>   Base Register. It's more efficient as it uses the processor’s time
>   base facility directly
>
>   the DPDK on FreeBSD currently is not supported on Powerpc64, it should
>   be safe to include the sys/platform/ppc.h
>
>
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>

Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>

Applied, thanks.

-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-21 16:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25  0:13 [dpdk-dev] [PATCH v3] eal/ppc64: improve rte_rdtsc() with __ppc_get_timebase() Thinh Tran
2020-04-16 22:35 ` Thomas Monjalon
2020-04-20 16:42 ` David Christensen
2020-04-21 16:17 ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).