Re: [dpdk-dev] [PATCH v4 2/5] net/fm10k: add epl serdes and port control functions

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/9/2020 7:26 AM, Xiaojun Liu wrote:
> Add epl serdes include loading spico,
> controlling pcsl, dma, dfe, ical. Add spico code.
> Add state machine for epl lane and port, it creates
> a pthread to handle the state changing event.
> Add external port management, which will use
> state machine to handle the event from lane and port.
> The lane state will change between DOWN, WAIT_PLL_LOCK,
> WAIT_SIGNAL_OK, WAIT_DFE_ICAL, WAIT_DFE_PCAL, UP.
> The port state will change between DOWN, WAIT_LANE_UP, UP.
> 
> Signed-off-by: Xiaojun Liu <xiaojun.liu@silicom.co.il>

<...>

> --- a/drivers/net/fm10k/Makefile
> +++ b/drivers/net/fm10k/Makefile
> @@ -49,6 +49,9 @@ endif
>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash
>  LDLIBS += -lrte_bus_pci
> +ifeq ($(CONFIG_RTE_FM10K_SWITCH_MANAGEMENT),y)
> +LDLIBS += -lpthread
> +endif
>  
>  #
>  # Add extra flags for base driver source files to disable warnings in them
> @@ -58,6 +61,10 @@ $(foreach obj, $(BASE_DRIVER_OBJS), $(eval CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER))
>  
>  VPATH += $(SRCDIR)/base
>  
> +ifeq ($(CONFIG_RTE_FM10K_SWITCH_MANAGEMENT),y)
> +VPATH += $(SRCDIR)/switch
> +endif
> +
>  #
>  # all source are stored in SRCS-y
>  # base driver is based on the package of cid-fm10k.2017.01.24.tar.gz
> @@ -71,6 +78,14 @@ SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_common.c
>  SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_mbx.c
>  SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_vf.c
>  SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_api.c
> +ifeq ($(CONFIG_RTE_FM10K_SWITCH_MANAGEMENT),y)
> +SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_i2c.c
> +SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_sbus.c
> +SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_ext_port.c
> +SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_serdes.c
> +SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_sm.c
> +SRCS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k_spico_code.c
> +endif

Can you please add meson build support too? Make build system will go away in
20.11, meson support should exist for new code.