From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 19AD71B4CF for <dev@dpdk.org>; Fri, 15 Feb 2019 20:39:07 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 42D2721FE1; Fri, 15 Feb 2019 14:39:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 15 Feb 2019 14:39:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=zBnkylqCRgVLsmCe7no3fGh2BQcBQYqsj8kwFpYabbw=; b=h/iJJmH5qlMH 9WIQrIWE1tMg4pySSqRbrBQmgnIPIzmETibEhuUKBk8stL6hQvZBb1qIRwjbzWkJ +7ZrKGcO7RuEF4Y3X3x95PeyQUib21lfFY9RlSrRkvIRcLaY8ajTBCd/nKKP++py HR7vjGrrVT2xa+xOiw2f33UrIAzf/ac= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=zBnkylqCRgVLsmCe7no3fGh2BQcBQYqsj8kwFpYab bw=; b=Ji91KWAdXwbwk/OHiL7IyXTBm1/BV92zOaMIx6FGwaT1OY2WSr2PG/+4I vbXPiGVPchw1rVWQ3lm8oPQPllfTZuGFNd6yDG7Y2JqbtxnRypbBCvsb5K1uYKo0 MYb2s9BepBX7SlyI5cEyPdXtu7yPVicrdYXR9RExxZQSrB9X7dVawHV6m9HGexBD 99titWB8mgdMQ/BFfHcniXcqsQiA+lmasVnZCF7Yc5+2UL5GumCI9d4aRhe4Qz+2 W1POJNAQHZWYsYUOUkxFTlX1p/yg9i1GRSZwr3ec0BqDuRMxV2Fs0IR6U0GIKLPW kyY//tCZqBTVnrdG91FC7fAHXp3rg== X-ME-Sender: <xms:WRVnXEYU5U-iSHdQvwdCpw8AV2F-Z9vfFTOfqIUZSPJ1gX01rO2swQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtjedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkf gjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhn uceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvd dtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: <xmx:WRVnXNk4d7PzHmcBJUsY6P-Eb4oguKFWjF3YX0iReiN2K0qXzGnvSQ> <xmx:WRVnXFQPUE9sHxzWsDMWddWTT-LhWX1J_i6XGuFqzgobgCLdxD4SmA> <xmx:WRVnXCjErI-K6kXl9aW9hObsLIIM3FLdyXTQKAy38ifJouet2Om0wg> <xmx:WhVnXJn3uH_8RYERNt8iGJjSBiJmPoKOZL1b1dUv5ZpHUNH3vLmRvA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DDB8BE409D; Fri, 15 Feb 2019 14:39:03 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> Cc: David Marchand <david.marchand@redhat.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Iremonger, Bernard" <bernard.iremonger@intel.com>, Maxime Coquelin <mcoqueli@redhat.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, "Wiles, Keith" <keith.wiles@intel.com> Date: Fri, 15 Feb 2019 20:38:59 +0100 Message-ID: <6177115.1iB7W0vHcD@xps> In-Reply-To: <2601191342CEEE43887BDE71AB977258012413A4D8@irsmsx105.ger.corp.intel.com> References: <1550158972-21895-1-git-send-email-david.marchand@redhat.com> <CAJFAV8wzk+DmkK7AoRJ47GZbrtsYK9uXOWC4_4riYmV3c9MSew@mail.gmail.com> <2601191342CEEE43887BDE71AB977258012413A4D8@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 15 Feb 2019 19:39:07 -0000 15/02/2019 19:42, Ananyev, Konstantin: > >>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand > >>> I am also for option 2 especially because of this. > >>> A driver that refuses a packet for reason X (which is a limitation, or an > >>> incorrect config or whatever that is not a transient condition) but gives > >>> it back to the application is a bad driver. > > >>Why? What.s wrong to leave it to the upper layer to decide what to > >>do with the packets that can't be sent (by one reason or another)? > > >How does the upper layer know if this is a transient state or something that can't be resolved? > > Via rte_errno, for example. rte_errno is not a result per packet. I think it is better to "eat" the packet as it is done for those transmitted to the HW.