From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id D243D1B2D0 for ; Tue, 3 Oct 2017 09:25:06 +0200 (CEST) Received: from pure.maildistiller.com (unknown [10.110.50.29]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id 1193A2005A; Tue, 3 Oct 2017 07:25:06 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx2-us1.ppe-hosted.com (unknown [10.110.49.251]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 81DA580049; Tue, 3 Oct 2017 07:25:05 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 3DCA780089; Tue, 3 Oct 2017 07:25:05 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 3 Oct 2017 08:24:58 +0100 To: Yongseok Koh CC: Raslan Darawsheh , "dev@dpdk.org" , Shahaf Shuler , "ferruh.yigit@intel.com" References: <1506617303-32509-1-git-send-email-rasland@mellanox.com> <1507012430-8421-1-git-send-email-rasland@mellanox.com> <18261cc6-ada3-59de-c200-91ea80dcf7fd@solarflare.com> <2260C792-E8AD-4CDE-81E5-7B607ECA9FE5@mellanox.com> From: Andrew Rybchenko Message-ID: <61862f56-212c-4e7d-e38f-c3ecfcc1644a@solarflare.com> Date: Tue, 3 Oct 2017 10:24:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <2260C792-E8AD-4CDE-81E5-7B607ECA9FE5@mellanox.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23368.003 X-TM-AS-Result: No--11.303600-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1507015506-8o6j-53o7zYi Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: add Rx HW timestamp capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Oct 2017 07:25:07 -0000 On 10/03/2017 09:53 AM, Yongseok Koh wrote: >> On Oct 2, 2017, at 11:40 PM, Andrew Rybchenko wrote: >> >> On 10/03/2017 09:33 AM, Raslan Darawsheh wrote: >>> Add a new offload capability flag for Rx HW >>> timestamp and enabling/disabling this via rte_eth_rxmode. >>> >>> Signed-off-by: Raslan Darawsheh >>> >>> >>> --- >>> This patch should be applied after after this series: >>> >>> http://dpdk.org/dev/patchwork/patch/29368/ >>> >>> --- >>> doc/guides/nics/features.rst | 11 +++++++++++ >>> lib/librte_ether/rte_ethdev.c | 6 ++++++ >>> lib/librte_ether/rte_ethdev.h | 5 ++++- >>> 3 files changed, 21 insertions(+), 1 deletion(-) >>> >> <...> >> >>> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h >>> index ffd2ee5..bd63730 100644 >>> --- a/lib/librte_ether/rte_ethdev.h >>> +++ b/lib/librte_ether/rte_ethdev.h >>> @@ -368,7 +368,8 @@ struct rte_eth_rxmode { >>> jumbo_frame : 1, /**< Jumbo Frame Receipt enable. */ >>> hw_strip_crc : 1, /**< Enable CRC stripping by hardware. */ >>> enable_scatter : 1, /**< Enable scatter packets rx handler */ >>> - enable_lro : 1; /**< Enable LRO */ >>> + enable_lro : 1, /**< Enable LRO */ >>> + hw_timestamp : 1; /**< Enable HW timestamp */ >>> >> The code is definitely not rebased on top of a new Rx offload API patch which adds >> ignore_offload_bitfield : 1; >> exactly in this place. > Hi Andrew, > Did you check Shahaf's email regarding this? Looks like Shahaf suggests keeping it as is for now. Yes. But it simply fails to apply on top a new Rx offload API patch. Above you say that it should be applied after that series. >> On Sep 30, 2017, at 11:44 PM, Shahaf Shuler wrote: >>> [1] http://dpdk.org/ml/archives/dev/2017-September/076872.html >> >> I agree it should be on top of [1]. >> Unfortunately since the PMDs will move to the new API only on 18.02, and in the current state Rx offloads are disabled by default, there will be no way to enable this feature without a dedicated bit. >> >> So my suggestion is to keep the timestamp bit on rxmode, and to update the convert function introduced on [1]. This bit will be removed along with the entire bit-field array once the old offloads API will be deprecated. > > Thanks, > Yongseok >