From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 1B0E8A055E;
Sun, 26 Jun 2022 17:15:11 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id B7EAB41144;
Sun, 26 Jun 2022 17:15:10 +0200 (CEST)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
[64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 70DBA41141
for <dev@dpdk.org>; Sun, 26 Jun 2022 17:15:08 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
by mailout.west.internal (Postfix) with ESMTP id 563FB3200893;
Sun, 26 Jun 2022 11:15:06 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Sun, 26 Jun 2022 11:15:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:date:date:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to; s=fm2; t=1656256505; x=
1656342905; bh=GbNNrF0lHlcawZ2tdoCw6IJ7xwRsme2DZygb05P3mEY=; b=B
/45CIZIyH2yefLOizWzb//WO+KxgaZ26kzmaoWuV8lPVGrREvEnicJs5YTNg80Py
2T76F6Q0NNpp8TFuD7tvDYo2fpqQY0uSyuzjGZ6w3quIjm9lpe7fRdt2wQp2Zgsd
lgOT7+LLe1cU5uzc29YVDPvO59pU5aCWuduRpLP3/xUjw6XNst4r6mzUa73QGrCF
T0kFm2sAoDgxPw7UuAA5IrpC30BmCnQ/uQy/zZeu/+hv2IBAnYBjRgbBCo+kwyvo
dlqqHomSLiPx7dM5LosILk6GeYjsMThSgUsp3+q6qsMTcXL7jva4GCy1yD7kjzT/
7TC+/hz0rhYEcFkIT6T1w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:date:date:feedback-id:feedback-id:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656256505; x=
1656342905; bh=GbNNrF0lHlcawZ2tdoCw6IJ7xwRsme2DZygb05P3mEY=; b=W
dQwBZlpzq2nUl5YJ4lT/NyhbHdbNnN+2cvDp+q3jtQfQcZEYvjVA4M2CuYTsLcIw
aUmyRE6yQqQcj6UWt14HUGoSllkdFx6KIBThg83vCgIN1ia+NA/iBNGHb2anUoaw
QflbqHQqaEKv1U9iaycOXaFXsXjXSGeIhAyUPpei4DsDH8YLGhU4FDuGMO+a225u
4njADRZAhzyd8YvM9APzlrRi+2VpYSPRPZAaLZTDipqjLqVRNCYAcaCbkISCmmox
7uVAMYOTk3k/70616FBKmduIarGrUaC9Q4TPX2aIDmeAWigLBwXKOpTiowW/55+i
wo8/2nEhY/ILa/OeAG6QQ==
X-ME-Sender: <xms:-Xe4Yv5cCx0d1t-6LbafO3ca-MvORuzukqUp7-_HBbFTdIvq-xys2w>
<xme:-Xe4Yk7ogNkq2lxOlEAA6vRd6bVj432MeBgtumaHHeQYP6g5uhEfeD2dlYedKShDr
MZNOVUQ0qJeJPKIBA>
X-ME-Received: <xmr:-Xe4YmdV4S85dW0fHl6oHJXgVUcoSKs3kOFA29H7kbah8NhSRbWoYxzbguQH8-DbjZgVU1OynrEghfSY1lBxPNwnOg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudegfedgkeekucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei
kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:-Xe4YgJTgyeACtH8dOwL5633JmyBRl-9ezq0T7UKTOrEHh3g0UyD0w>
<xmx:-Xe4YjLomU2hlYEHj6yIojtaKVCgpOqE-RlDoLiAJUGJ2MbnH67vXg>
<xmx:-Xe4YpxlIzwDpsbpcuArEsDMTpa1nLyAaiP1uWoUS6v6GvCqSAdIjg>
<xmx:-Xe4YlwXDlUgiLc9Ei9ungQfEt9JN48EJpt2z051M6LZaItc3j3-dA>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
26 Jun 2022 11:15:03 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: David Marchand <david.marchand@redhat.com>, dev@dpdk.org,
Chenbo Xia <chenbo.xia@intel.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>,
Rosen Xu <rosen.xu@intel.com>, Stephen Hemminger <stephen@networkplumber.org>,
Joyce Kong <joyce.kong@arm.com>, Jie Zhou <jizh@linux.microsoft.com>,
dev@dpdk.org, konstantin.v.ananyev@yandex.ru, ferruh.yigit@amd.com,
andrew.rybchenko@oktetlabs.ru
Subject: Re: [PATCH 1/1] test/pmd_perf: handling of unknown connection speed
Date: Sun, 26 Jun 2022 17:15:02 +0200
Message-ID: <6192851.a9HWlOh95j@thomas>
In-Reply-To: <20220511163310.50892-1-heinrich.schuchardt@canonical.com>
References: <20220511163310.50892-1-heinrich.schuchardt@canonical.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
11/05/2022 18:33, Heinrich Schuchardt:
> When running DPDK in QEMU it cannot determine the connection speed.
> pmd_perf_autotest treats this as if the connection speed where
> UNIT32_MAX Mbps:
>
> RTE>>pmd_perf_autotest
> Start PMD RXTX cycles cost test.
> Allocated mbuf pool on socket 0
> CONFIG RXD=1024 TXD=1024
> Performance test runs on lcore 1 socket 0
> Port 0 Address:52:54:00:12:34:57
> Port 1 Address:52:54:00:12:34:58
> Checking link statuses...
> Port 0 Link up at Unknown FDX Autoneg
> Port 1 Link up at Unknown FDX Autoneg
> IPv4 pktlen 46
> UDP pktlen 26
> Generate 4096 packets @socket 0
> inject 2048 packet to port 0
> inject 2048 packet to port 1
> Total packets inject to prime ports = 4096
> Each port will do 6391320379464 packets per second
> Test will stop after at least 25565281517856 packets received
>
> This will not allow the test to terminate in a reasonable timespan.
> Just assume 10 Gbps in this case instead:
>
> ...
> Test will stop after at least 59523808 packets received
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> app/test/test_pmd_perf.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c
> index 25611bfe9b..ee08c8aade 100644
> --- a/app/test/test_pmd_perf.c
> +++ b/app/test/test_pmd_perf.c
> @@ -486,10 +486,17 @@ main_loop(__rte_unused void *args)
> }
> printf("Total packets inject to prime ports = %u\n", idx);
>
> - packets_per_second = (link_mbps * 1000 * 1000) /
> - ((PACKET_SIZE + FRAME_GAP + MAC_PREAMBLE) * CHAR_BIT);
> - printf("Each port will do %"PRIu64" packets per second\n",
> - packets_per_second);
> + if (link_mbps != RTE_ETH_SPEED_NUM_UNKNOWN) {
> + packets_per_second = (link_mbps * 1000 * 1000) /
> + ((PACKET_SIZE + FRAME_GAP + MAC_PREAMBLE) * CHAR_BIT);
> + printf("Each port will do %"PRIu64" packets per second\n",
> + packets_per_second);
> + total_packets = RTE_TEST_DURATION * conf->nb_ports * packets_per_second;
This is redundant with below.
> + } else {
> + /* We don't know the speed. Pretend it is 10G */
> + packets_per_second = ((uint64_t)RTE_ETH_SPEED_NUM_10G * 1000 * 1000) /
> + ((PACKET_SIZE + FRAME_GAP + MAC_PREAMBLE) * CHAR_BIT);
> + }
>
> total_packets = RTE_TEST_DURATION * conf->nb_ports * packets_per_second;
Why not just inserting this:
if (link_mbps == RTE_ETH_SPEED_NUM_UNKNOWN)
link_mbps = RTE_ETH_SPEED_NUM_10G;