From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Zhou Danny <danny.zhou@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal: enable uio_pci_generic support
Date: Fri, 20 Feb 2015 10:01:10 +0100 [thread overview]
Message-ID: <61932075.MLJK3iMSUs@xps13> (raw)
In-Reply-To: <1424365731-32228-2-git-send-email-danny.zhou@intel.com>
Hi Danny,
2015-02-20 01:08, Zhou Danny:
> @@ -148,6 +151,7 @@ struct rte_pci_device {
> struct rte_pci_id id; /**< PCI ID. */
> struct rte_pci_resource mem_resource[PCI_MAX_RESOURCE]; /**< PCI Memory Resource */
> struct rte_intr_handle intr_handle; /**< Interrupt handle */
> + char kernel_driver_name[BUFSIZ]; /**< Kernel driver name */
The comment is not very helpful.
What about something like "Kernel driver to map ressources in userspace"?
You are introducing a new field without filling it for UIO and VFIO.
Testuya and Michael are working on the same thing in hotplug patchset:
http://dpdk.org/dev/patchwork/patch/3520/
Please help to choose the best approach.
> const struct rte_pci_driver *driver; /**< Associated driver */
next prev parent reply other threads:[~2015-02-20 9:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 17:08 [dpdk-dev] [PATCH v2 0/3] Enable " Zhou Danny
2015-02-19 17:08 ` [dpdk-dev] [PATCH v2 1/3] eal: enable " Zhou Danny
2015-02-20 9:01 ` Thomas Monjalon [this message]
2015-02-20 10:15 ` Bruce Richardson
2015-02-19 17:08 ` [dpdk-dev] [PATCH v2 2/3] eal: add interrupt enable/disable routines for uio_pci_generic Zhou Danny
2015-02-19 17:08 ` [dpdk-dev] [PATCH v2 3/3] tools: enable binding NIC device to uio_pci_generic Zhou Danny
2015-02-20 16:59 ` [dpdk-dev] [PATCH v3 0/3] enable uio_pci_generic support Bruce Richardson
2015-02-20 16:59 ` [dpdk-dev] [PATCH v3 1/3] eal: " Bruce Richardson
2015-02-23 15:24 ` David Marchand
2015-02-20 16:59 ` [dpdk-dev] [PATCH v3 2/3] eal: add interrupt enable/disable routines for uio_pci_generic Bruce Richardson
2015-02-20 16:59 ` [dpdk-dev] [PATCH v3 3/3] tools: enable binding NIC device to uio_pci_generic Bruce Richardson
2015-02-20 17:44 ` [dpdk-dev] [PATCH v3 0/3] enable uio_pci_generic support Declan Doherty
2015-02-20 22:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61932075.MLJK3iMSUs@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=danny.zhou@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).