From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f179.google.com (mail-we0-f179.google.com [74.125.82.179]) by dpdk.org (Postfix) with ESMTP id 44C42B52B for ; Fri, 20 Feb 2015 10:01:41 +0100 (CET) Received: by wesu56 with SMTP id u56so4331403wes.10 for ; Fri, 20 Feb 2015 01:01:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Fu03EvBYzPFswaVVJGVcG00zcAhvHPa4Oc58ZTLDrWc=; b=Xj43CHuI7iMrhvZrMYwSejW3UbG7pkYPkm92WOUuf20/9Uu9qMnulNprAGPiqrp0rU jpRWeDgf1tG2xqSaH+83HSFhVyWXxGTWM9jEFAyoQWmDeBRDVookNkW4x7/UhUTOE2zg Dbt31eQmHEyx7IkrhJzAXgE7dl4GlAv8Ta27yUY/SA+KCyKwu1xN6vc6+0E81tyPoJqz Z0eIwjIfbJjIZ0pAJnTsDO0Rb6evo/QJteGR6L8i4hvDjrLon/WM+l599n8ik5Mw3cMu +dISH4a835+1p9O6ZGkYz1tCfCUGe8s7SPKUgWMKj0jR48morRqa5FPcG4c1GklEZvnT qyyQ== X-Gm-Message-State: ALoCoQnyQeU4WcPzZlWQb7WCfmRi7xGaptcuX+lwQQhOqT5VBDqFQYsRJMEhdXt+jiRHBobwdm06 X-Received: by 10.194.237.34 with SMTP id uz2mr16245483wjc.157.1424422901102; Fri, 20 Feb 2015 01:01:41 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id kj8sm41081776wjc.29.2015.02.20.01.01.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Feb 2015 01:01:40 -0800 (PST) From: Thomas Monjalon To: Zhou Danny Date: Fri, 20 Feb 2015 10:01:10 +0100 Message-ID: <61932075.MLJK3iMSUs@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1424365731-32228-2-git-send-email-danny.zhou@intel.com> References: <1424365731-32228-1-git-send-email-danny.zhou@intel.com> <1424365731-32228-2-git-send-email-danny.zhou@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal: enable uio_pci_generic support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 09:01:41 -0000 Hi Danny, 2015-02-20 01:08, Zhou Danny: > @@ -148,6 +151,7 @@ struct rte_pci_device { > struct rte_pci_id id; /**< PCI ID. */ > struct rte_pci_resource mem_resource[PCI_MAX_RESOURCE]; /**< PCI Memory Resource */ > struct rte_intr_handle intr_handle; /**< Interrupt handle */ > + char kernel_driver_name[BUFSIZ]; /**< Kernel driver name */ The comment is not very helpful. What about something like "Kernel driver to map ressources in userspace"? You are introducing a new field without filling it for UIO and VFIO. Testuya and Michael are working on the same thing in hotplug patchset: http://dpdk.org/dev/patchwork/patch/3520/ Please help to choose the best approach. > const struct rte_pci_driver *driver; /**< Associated driver */