From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id B697B2E83 for ; Wed, 10 Feb 2016 11:01:39 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id g62so19241008wme.0 for ; Wed, 10 Feb 2016 02:01:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=/7ExC+RCao+1TcfzfFvy+6qAiFxdItZqICq92UXqhkw=; b=BPk0JbW3Qvj8VuKjsqRaAw4v/pGhd4EgVrXvtKuVJ+gxbqmWjSHyg7B7TJpTwl1TTl YakVNV0zQHPJ//qoUM8f3PwILirvPCoow2MkWm8yYJOLAq/A9x4KYhIzFgAYOQBpNiEo cAffMOy8m/VT2k/tltmF49KWK2f0R77Z+scsiz31HbKkmqWO8LSczUQKV+LjNfoo+cIJ G+RkRt0xwJMbuxpj8biJOyrdtpjil2mTNeUz/JCkzEW6DaXiio3tkgCXRTin1Oa+Ygcn O7v40bUuS9tUSnpUYiNnLo+MNSZTdvWR5epOb7s9CAWNsZrY/kxBTnFwMhjnOdCvwa9S 4GXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=/7ExC+RCao+1TcfzfFvy+6qAiFxdItZqICq92UXqhkw=; b=lk20J4bVKi8GdvknNTrAi5BQK97IyOerVhJOe1JqpIxy2Kb5vZ8rhgg5QW+eHUoNCf P/SlZlx5PUJxWNSCLFVXz5AQTGFkiSs2OMIEKR2AcANOj9nOyXY7/stcsqc3SwccKaqI 6svKG2BdSWV2Jk0BYvS80xcOedXC9sSWop7zK5llnf19HNQUKCobVcGCzU+hBwcF7H67 6HzYeGPbMqRPXDqjI4fN1hnPSLGh/ImD1AEzTqlNkur+pnRRdOLgeXM2nQMxjxQrBLqd DSFkziR5vlgJxgpfvxjqMw6XW8ju2ZbmzD5yYtzw8LYq1A5I1XnlvZsdPN3AuhsKd6Be hqAA== X-Gm-Message-State: AG10YORCV3NS/fTIbxg8LCvI3jdUfbYot1OcVYcVvHov/aSpYcMsbhjxMDuiuFVFRJKN5BP4 X-Received: by 10.194.79.37 with SMTP id g5mr40783251wjx.89.1455098499590; Wed, 10 Feb 2016 02:01:39 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id r10sm2169233wjz.24.2016.02.10.02.01.38 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 10 Feb 2016 02:01:38 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson Date: Wed, 10 Feb 2016 11:00:13 +0100 Message-ID: <6194137.BU55KgHhRV@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160210094955.GA4084@bricha3-MOBL3> References: <1450193851-9100-4-git-send-email-lsun@ezchip.com> <1576967.tgJNBhtfpx@xps13> <20160210094955.GA4084@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2016 10:01:39 -0000 2016-02-10 09:49, Bruce Richardson: > On Tue, Feb 09, 2016 at 11:47:55PM +0100, Thomas Monjalon wrote: > > 2016-02-09 21:15, Liming Sun: > > > Looks like this patch serie has been merged into dpdk-next-net/rel_16_04. > > > What would be the usual way to submit changes for new comments? Would it be incremental changes (new commit) based on previous one? Thanks. > > > > Good question. > > I think it's better if Bruce drops or reverts the commits from dpdk-next-net > > to let you re-submit a better new version. > > Bruce, do you agree? > > Unless there is something actually broken - that was previously working - by > this patchset I'd rather not revert it. This patch was sitting acked for a month > which is a reasonable time for comments before applying it. Allowing people to > step up post-apply and look for patches being reverted is not something we want > to encourage IMHO. There are already too many reviews being done at the last > minute, and allowing reverts may make that situation worse, while applying acked > patches within a reasonable time - irrespective of whether people subsequently > find issues with them - should encourage earlier reviews, and makes it easier on > contributors. Yes you are right. > Therefore I'd rather see any additional enhancements or changes > done as incremental patches on top of this set. > > Regards, > /Bruce >