From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E646A00C5; Tue, 15 Feb 2022 13:30:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6332410F3; Tue, 15 Feb 2022 13:30:22 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 9DA7E40E78 for ; Tue, 15 Feb 2022 13:30:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644928221; x=1676464221; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=R/sGy+TJGMdepZ2xAxnjyAtfp19Sf8x5Sb1smoDFKGI=; b=HFItR6v2aP0+ARSFfoQ4l0FbPsEerl4kCX61fTEAK8XgIw9iq0my9/OB cmUyW58XlAGP948EH3ffv7+Ei1tZpaxPVl4RfT9/WZRcGh2B9j028K4zT qAYNcS0VOJ7a4bwfq/r22NJTVzthsVEg587uRPmG9+l+jPOxulgXtdMoa mfk9HJBVf7i8pq5ePUN51eW4deaHljKljZ7MO7IM/Mn6pUOubsXkpknBl gcC2HaPRXjMeYqLs81T2Qiv5619bY04PtruKXWgpNIkZljPAe4pCUuWnJ GpM9PYx4Foh/X/UeTr98j+a/8zRWDmmQ4zRcWT7WJCRiej+kI7Ea21OUW g==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="274914242" X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="274914242" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 04:30:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="486149607" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 15 Feb 2022 04:30:20 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 04:30:19 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 04:30:19 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 04:30:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NVppPVaesWge1m5VGv7aDAhOK8h07J7PzoQ3dZuBc8bV5oVZi9tb4ZivTEy/16czgZaXeH+CCJRIK434SjSihimNIOP2KxJKF5iE5fgRS+qvn4r0FtS2mR4rCMGMAbimMj3UgJ+mTtD0fNIA4dG6ZRWeJhA/S83i4snNYrWwe3dT1DbZpCcJAT+hIR0cC+VrXIRiXko1AoUPQlDLxLtoD542qWk3sByj1goQ1HJPn4ro+Mi35jk9UZ7DRLJY+68f64mqu/YyUkdA6KbyXigCUgPACmaShKxhfRxt8Haz+6JKS/uwY7Gg5nSJwgZHzKXSdnb776Ihfo6pI5Rloqq0Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NE3ZUWtZAdTQHFbTOoui2uTE9PZcc7kxxXyqgZFlzrY=; b=G7+w2LUZqQKDNeB0/s6zO1XEO7LCzue4SYhhxoCarfAgRk2hIQ/2hK4UT0AIVAnaJBw/pSzLX9m2hmyKX92Wkiow8u2goB/2z4WZaP/XGsShCdL9unJjz7RdsvzFsfXU9QIjP2luTdA0cVWAJ8Wx5eDilIbn9zZwmWe6CiL3/N7bp+lYtWoteRlWebDMGVFWmoaizhe0/PegofZaSic6xLC6LRi8JF+jwtKbK15tw/8jwVaOYUNszgWVrNY5EsuJoHM08JogXw0jjBpm2vyHNTKMUYsiuWyjA6eMRZ/+6kDkUb5Ht/F1U73YLYW7uTfrxHiQLRkRrvUWjsHV2rW9Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) by MN2PR11MB4413.namprd11.prod.outlook.com (2603:10b6:208:191::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Tue, 15 Feb 2022 12:30:17 +0000 Received: from CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::dc1a:fca9:c3dd:3657]) by CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::dc1a:fca9:c3dd:3657%3]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022 12:30:17 +0000 Message-ID: <61a3edb7-3d5c-1df8-52bd-26f4a951ad5b@intel.com> Date: Tue, 15 Feb 2022 12:30:10 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.6.0 Subject: Re: [PATCH] net/iavf: fix segmentation offload buffer size Content-Language: en-GB To: Ferruh Yigit , Jingjing Wu , Beilei Xing CC: , , Kevin Traynor , Luca Boccassi References: <20220210130923.1442905-1-radu.nicolau@intel.com> <05a27976-6664-190c-38b7-9b63c7294973@intel.com> <23e5a111-9402-d6ce-a076-5dbcb24f5937@intel.com> <0e492107-2325-8f79-7a7f-ad652c40c741@intel.com> From: "Nicolau, Radu" In-Reply-To: <0e492107-2325-8f79-7a7f-ad652c40c741@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0076.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::9) To CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 65ed2b37-0a61-4918-0964-08d9f07eec03 X-MS-TrafficTypeDiagnostic: MN2PR11MB4413:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:655; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w0RdZMqIUUuUHFbSeOoSuNIPDiYOrJPVVm1BfB8T5Wnh60eRWhLIjDTDZMRuhkPyo32E3F4u52EylhC/DeBZ7YcBV8vgW3WosS8XGzy6+Kf4NIX78C62gBupjeWrmh0TvcuWPSW368wOrij/0ButLjz5EDzJAIIyJgFd8PuQJSk7VYTuP/4wk77F0SPbIxPgRqECXOEmsqtr+ofo62ltycmU0PGHaxw2FpUNmEfIwEw+8hNIY8hJuQ3C5tnDcstXAz+VjiPNkbvdCiTNaHQ8F3Zr6vpuip/CprpLJsNZXlLcADYU1UFMkVddY5czKftdBGyfKQhkF+A0mKuINZikbwfp02YBvyUxQ1EbaqpuNJZGRo0Cpn14neN/EWI4zJPdoBef9kKGhZXAwO/510HxI5ypELenDc9GPgKFypbq+NuebTNdx3lpXrtICtiv76vId6KT2s475J9HHOQP4GYuQ7gvDeib8htg8LEJG+vUKswRXxKdSm0KomJUGbBezf9Co3nEjybGchJ0yo/JjYnR0/f6wqKjTQTWoW9B9pJCrVpfvbRSAfm9XN57hGXXAVnQj/9esNN8SJzHEAsCMu0CNh66eMegmfOpNRheJh9K+JJqtTsp8UwrskJSxSbXOj5t3Fes0sUlcP4S3Xwx5VM02Si1wL0TkjC0ePXagjnFnv11yUTOg6xq/XP91xoZlJGqC0HNLqkfEY/r9KJvjFPv0NLAx98NrdxPKOgZSyubps6hyOiUIIG93C/KB823r6I8 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6636002)(36756003)(38100700002)(66946007)(316002)(26005)(6486002)(66476007)(82960400001)(31686004)(4326008)(66556008)(2616005)(186003)(8676002)(53546011)(31696002)(6506007)(86362001)(6512007)(2906002)(110136005)(54906003)(83380400001)(508600001)(55236004)(8936002)(5660300002)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZURPMGZCVEdWeVVPdGEwTnBRMVV6ZWtiWkdMM085ckFrZkI3MnVhQ1llMjVU?= =?utf-8?B?Zko0S2VMc1RodDBtWGVINjdBbys4SWd3WFNIK1gzcDk3dzBBMi9mbTNWaVoy?= =?utf-8?B?RDZ0YWhxU3JMWXZIUktRNzA2SGhnUWswcXZiUnd6UVc1NzhvajZsNGF5cDJ0?= =?utf-8?B?UTFRMlFEVzZpWFR5TzZtQXp3OXRtRmpkKzQ4ZlNzTkZvWTI1bTdtOE51WDVi?= =?utf-8?B?ZHYwOUk0WklGbTZrcERXczR4SXByVGZMMjRzdGVRVng0WVFsQUdFdU00dmRr?= =?utf-8?B?Mk85RVg1QWFDbGJ4NDZ4UzRPNnVVWmprNTdXTjZRYkQ2UEtzTHUxdzBLbW5X?= =?utf-8?B?MXdSK3NEek0rMnlQUTdublU4OW9SRjZwRkZ6T21rWEhGZFBZbVdzUURBdVFJ?= =?utf-8?B?TTRBR1RDWjB4UWlrZ3B4cGR1Wm1hZk9UVXRMdm1BOUw2OUNkV1V6WmFDOVJw?= =?utf-8?B?RysyaWRpZWM1VkRxZUR0bVdYK09tRXozbDJZVXBYWlV2ZHdDVk5DV1VibEpr?= =?utf-8?B?ekh3SDdNYUNLNHpJUUZxZTg5YTNXT2hkQnl6cXQ1bVMwVFZqRStaVWU2OFkx?= =?utf-8?B?WHc5QjJuWGlHSG9CdjhLc2t1RVYxbmZjcUJGYUJzL0JIY093VVVmVTBwRTlD?= =?utf-8?B?Z09HUHhBUkh5TExJb1kxakdBSU40Wk1sd2FxR2ZxVVBQY3VJM25QMW1nSXNx?= =?utf-8?B?eE91V2U4RGNmeXFQdHM2Y3JVNEFmcytGOHg2RzBvU3JTSEVaQ2lnNU9xVlc5?= =?utf-8?B?TEVNTnhkaUY3MVNjTVU0elhwZ3F5VUNoVW9kQlREUEo2N2dyVmJjcWdxV1pJ?= =?utf-8?B?K0hVL0E4Um1OVDlKaUNvVUoyQnhkS293LzRQaVdxd0UzbmhXSnlFRElpNHV0?= =?utf-8?B?d1NMaWZodHVGTTBabk90cnNMdm13NHhLUVh1OWhURDlJRHVDbTQ5cGRZY29z?= =?utf-8?B?Vm1wYkYvQ2ZENmhOdGZrZ1BrYXhxZGRDMHRqSkowWEhvSmt1Lzd3bFlXSzFI?= =?utf-8?B?aXF2dk83MWEyRFRsbTZtZzB3Z3BxU05wNkpBV2x2aS94SUFNWnFzTi9IdmF2?= =?utf-8?B?WnJqSy92Y0ptWWRGTjdudC9GSGVnejhGYUxqVUxSa2tkeU9IWUs1N2dBcXIx?= =?utf-8?B?Y2dxZ1JpaEdob051RjI5VEx6SHRiTEQ3UXFsdFlpcVlFQ0E1cDhKUkc1dUVo?= =?utf-8?B?Tm14UWU1QmZqSnk3M2ZWK0lUQ1VjQWhwUllWL1JyaHZaT2dpVVhkZTVYTGdt?= =?utf-8?B?RFU5ayttMnNsTS9mOHYwRnA5czhLT3E0TTFOMXJMSi85Ni9vYWFQZ2R1cndD?= =?utf-8?B?dDFIaVB0NklTVGo1Z2hJSVpFbm82SzN6aFJpTHVZaEwzdkJuUHQveU9jb0pC?= =?utf-8?B?aSs1MWhKT2hQci8wcG5sVC9xVzZrNlA4RXdtSXZFYkN1ZjA3UUNSRmprRWZT?= =?utf-8?B?N0JXOUNIdnl5Q1dwK2tkVW9kQVUwbVh1ei9adzNsM0ZEVjZ0TFVvVzlVUmRq?= =?utf-8?B?MlRPRkE5QlZ6Sjk5YXBuZ2JSdU1nU3B3TEhSNG9jY1BFbjlDK0VLSlpKamVx?= =?utf-8?B?REdhNzNxdWNuR3dGNHM2UXJwNFo3bFltYlNvK1dPZ0RtK05QR2VoMVJhT2c5?= =?utf-8?B?ZTFRT2p1V0paOFdpcUFXcHBFMmdldlRFb0xDUEdQQzVzYk5HRFNYdS9PZzVX?= =?utf-8?B?aStDQXhscXg0WUFNUEpRUE5HbnlPcHVCT041eHpYN2JMdDNJQnl3eGpkem56?= =?utf-8?B?ZzhBWmlyUVpvSVprS3JkMndJOGdVUXZBOE4wRzYrNnNRUmRWUzFrWGsxcWFZ?= =?utf-8?B?WmhUczVpRDBUeGVneUlCSmorWXBxbXdkVHE1SnFYM0d0amltNnV6dlU5QW1V?= =?utf-8?B?Mm9LR05tL2kyUEZmbU9XaTBKcnQ1ZlFVcGJXbnFHNjc2U0x5NHJiTlJpa3Bh?= =?utf-8?B?REhLay9Ea1gwZFprT255SmdXTTV3OGlsb0hqNlBCZFp2Qlh2cnFRbVV1K1Ja?= =?utf-8?B?TjNFRkk4L2JqNEFPbHBLMFZmRU05NmFsRGJFWWJrOFdLVFJhQURLNnR2Vk51?= =?utf-8?B?V0IyczNMdVlZMWo1dWZzODhPTFhIZ2RRNEE4R1UrZGkrYitRVlg5alZzT1Zj?= =?utf-8?B?YitvRHdQQlhYV1dEZW1YMDdZR0VESy9CMWloU3Z4OGpYSzRQK3NLb2dQTkNX?= =?utf-8?Q?/lAmm/lrjOdwgHGH03ELUHE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 65ed2b37-0a61-4918-0964-08d9f07eec03 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 12:30:16.8915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DMPUvEaydvy+oYpyedIEHCRV/wcMaNeLbcAsjirToCaj13Ppc8tx0UmmZKRkfE6HQR8+HgkO07wZAbiYVOaQUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4413 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/2022 11:19 AM, Ferruh Yigit wrote: > On 2/15/2022 10:47 AM, Nicolau, Radu wrote: >> >> On 2/15/2022 10:06 AM, Ferruh Yigit wrote: >>> On 2/10/2022 1:09 PM, Radu Nicolau wrote: >>>> This reverts commit ff8b8bcd2ebe, which resulted in incorrect >>>> buffer size >>>> being computed for TSO packets. >>>> >>>> Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") >>>> >>> >>> Commit 'ff8b8bcd2ebe' was already fixing segmentation offload, >>> are we having the initial issue back when this patch reverted? >>> Is there a fix for that initial issue? >> The initial issue was around a very specific usecase - IPsec >> transport mode TSO and it is very likely back with this revert. But >> it's a much less severe impact than general traffic TSO. > > Got it, so this revert brings back an issue, should > we document this in the commit log of this patch? > Plus should we create a Bugzilla etc to record the > introduced issue? I plan to follow up with a fix shortly. As for the commit message, since this was not merged to the LTS and main, do we really need it?