From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54FFBA2F6B for ; Tue, 8 Oct 2019 09:40:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F2F91BFDF; Tue, 8 Oct 2019 09:40:52 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7EBB61BFDA for ; Tue, 8 Oct 2019 09:40:50 +0200 (CEST) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A857E89AC8 for ; Tue, 8 Oct 2019 07:40:49 +0000 (UTC) Received: by mail-wr1-f70.google.com with SMTP id c17so8433929wro.18 for ; Tue, 08 Oct 2019 00:40:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Z/rB84SNPdlIzjAuX9lbrK8x9OFlOjdIxIdueOmaw6U=; b=e3oTDpZZeyc9BawSUo6+PxNscZppy0eYXD/utqqet8UVH+4ISeq0OIQqUIN/xLYUg+ pDtpJKjokEjl0YZmfD4KFktDJ3csil4KNEzIb8K+WfQwN3LCLvIloxEqY/HhrjFKKRwd kx+b4gBYyoRpO6Oxo4qqCdYG/w/8zIbH9BgyhD9EI3zq0/jrO1Eto3VkkJpIoB6VGp+I Yb3q6wrdmwgSoRAPSnOivX3wT5mPzh3SkDAXKmOuL71pepr8Sjx6lRhyHyHpwfiUdGua fApkhUX8u6kAVICh2A5UteKju59Z6RC39uuiEA/gu7V2QO9xDG5s3WWm+XYdqOPvjGOW 0hsQ== X-Gm-Message-State: APjAAAU9H2/6PBMtc7OqDIt6/JILGGDv+7O5a0v9Rr5NLplwu2mH7pd2 4d0FIAQe64aE9tQsvcZQZpX3fX98IdKJUx+q3DY9pjSoO1D2JVjLZ3PIFaGptsgyR+kOdMjR2Oc j4cw= X-Received: by 2002:a7b:c631:: with SMTP id p17mr2624927wmk.165.1570520448442; Tue, 08 Oct 2019 00:40:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzK3xdwx7eQ/z9Vy79KQHYRRov01om5ZX+2qwcoCManX1Npxy8zAutIOLGcTVh0NMDquE8/LQ== X-Received: by 2002:a7b:c631:: with SMTP id p17mr2624905wmk.165.1570520448231; Tue, 08 Oct 2019 00:40:48 -0700 (PDT) Received: from amorenoz.users.ipa.redhat.com ([81.0.4.169]) by smtp.gmail.com with ESMTPSA id b186sm2916295wmd.16.2019.10.08.00.40.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2019 00:40:47 -0700 (PDT) To: Tiwei Bie Cc: dev@dpdk.org, zhihong.wang@intel.com, maxime.coquelin@redhat.com, stable@dpdk.org References: <20190927183759.18816-1-amorenoz@redhat.com> <20190927183759.18816-4-amorenoz@redhat.com> <20191008062314.GA25865@___> From: Adrian Moreno Autocrypt: addr=amorenoz@redhat.com; prefer-encrypt=mutual; keydata= mQENBF1syNUBCADQ9dk3fDMxOZ/+OQpmbanpodYxEv8IRtDz8PXw8YX7UyGfozOpLjQ8Fftj ZxuubYNbt2QVbSgviFilFdNWu2eTnN/JaGtfhmTOLPVoakkPHZF8lbgImMoch7L0fH8wN2IM KPxQyPNlX+K9FD5brHsV1lfe1TwAxmhcvLW8yNrVq+9eDIDykxc7tH4exIqXgZroahGxMHKy c8Ti2kJka/t6pDfRaY0J+6J7I1nrn6GXXSMNA45EH8+0N/QlcXhP3rfftnoPeVmpjswzvJqY FNjf/Q5VPLx7RX0Qx+y8mMB2JcChV5Bl7D7x5EUbItj6+Sy7QfOgCtPegk9HSrBCNYaLABEB AAG0I0FkcmlhbiBNb3Jlbm8gPGFtb3Jlbm96QHJlZGhhdC5jb20+iQFUBBMBCAA+FiEEogUD gihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgEC F4AACgkQd5C5fbYeFsX7qwgArGHSkX+ILNcujkVzjTG4OtkpJMPFlkn/1PxSEKD0jLuzx14B COzpg/Mqj3Re/QBuOas+ci9bsUA0/2nORtmmEBvzDOJpR5FH1jaGCx8USlY4WM6QqEDNZgTw hsy9KhjFzFjMk+oo3HyItXA+Uq9yrRBTjNBGTXxezMRcMuUZ4MIAfY0IRBglL2BufiuL43jD BvTENNFLoQ/wFV7qkFWSkv+8IjTsxr7M6XUo1QLd29Hn0dvwssN579HL1+BP46i2REpzeBEG L75iVChi+YnIQQNMJ9NYarVabZx4Y1Gn8+7B/1SNArDV+IDgnYgt7E58otoV2Ap310dmtuvE VbxGpbkBDQRdbMjVAQgAqyp9oA7WDu7/Y9T4Ommt69iZx8os7shUIfdgPEy5xrcPn6qGwN1/ HQ4j8nWfBG9uuX1X0RXUZIUEtYTxtED4yaCQMTqDUf9cBAwAA2mYxBfoiNYx8YqxM+sT0/J4 2qmDd+y+20UR4yzHE8AmIbspTzDFIJDAi+jKSR8F355z0sfW7CIMDC4ZWrPsskjEy1YN/U10 r6tRRH1kNyrCSbTG0d9MtcQO58h7DLXuzUhErB+BtG52A04t5cweIJTJC+koV5XPeilzlHnm RFoj0ncruGa9Odns21BNt3cy9wLfK+aUnWuAB1uc6bJGQPiAwjkilz7g7MBRUuIQ2Zt7HGLc SwARAQABiQE8BBgBCAAmFiEEogUDgihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwwFCQHhM4AA CgkQd5C5fbYeFsUlSwf8CH+u/IXaE7WeWxwFkMaORfW8cM4q0xrL3M6yRGuQNW+kMjnrvK9U J9G+L1/5uTRbDQ/4LdoKqize8LjehA+iF6ba4t9Npikh8fLKWgaJfQ/hPhH4C3O5gWPOLTW6 ylGxiuER4CdFwQIoAMMslhFA7G+teeOKBq36E+1+zrybI6Xy1UBSlpDK9j4CtTnMQejjuSQb Qhle+l8VroaUHq869wjAhRHHhqmtJKggI+OvzgQpDIwfHIDypb1BuKydi2W6cVYEALUYyCLS dTBDhzj8zR5tPCsga8J7+TclQzkWOiI2C6ZtiWrMsL/Uym3uXk5nsoc7lSj7yLd/MrBRhYfP JQ== Message-ID: <61ebab5f-c91c-16bd-17ce-78800474a522@redhat.com> Date: Tue, 8 Oct 2019 09:40:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191008062314.GA25865@___> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 3/3] vhost: prevent zero copy mode if iommu is on X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/8/19 8:23 AM, Tiwei Bie wrote: > On Fri, Sep 27, 2019 at 08:37:59PM +0200, Adrian Moreno wrote: >> The simltaneous use of dequeue_zero_copy and IOMMU is problematic. >> Not only because IOVA_VA mode is not supported but also because the >> potential invalidation of guest pages while the buffers are in use, >> is not handled. >> >> Prevent these two features to be enabled simultaneosly. >> >> Fixes: 69c90e98f483 ("vhost: enable IOMMU support") >> Cc: maxime.coquelin@redhat.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Adrian Moreno >> --- >> lib/librte_vhost/socket.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) > > Reviewed-by: Tiwei Bie > >> >> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c >> index 274988c4d..534a7ffe3 100644 >> --- a/lib/librte_vhost/socket.c >> +++ b/lib/librte_vhost/socket.c >> @@ -871,6 +871,14 @@ rte_vhost_driver_register(const char *path, uint64_t flags) >> } >> vsocket->dequeue_zero_copy = flags & RTE_VHOST_USER_DEQUEUE_ZERO_COPY; >> >> + if (vsocket->dequeue_zero_copy && >> + (flags & RTE_VHOST_USER_IOMMU_SUPPORT)) { > > It's better to add one more space before '(flags ...' OK. I'll add it in the next version. > >> + RTE_LOG(ERR, VHOST_CONFIG, >> + "error: enabling dequeue zero copy and IOMMU features " >> + "simultaneously is not supported\n"); >> + goto out_mutex; >> + } >> + >> /* >> * Set the supported features correctly for the builtin vhost-user >> * net driver. >> -- >> 2.21.0 >> Thanks. -Adrián